From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 479BB1DB8
 for <dev@dpdk.org>; Fri, 27 Jul 2018 09:00:38 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 27 Jul 2018 00:00:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,408,1526367600"; d="scan'208";a="76388891"
Received: from squirke-mobl1.amr.corp.intel.com (HELO [10.252.8.207])
 ([10.252.8.207])
 by orsmga001.jf.intel.com with ESMTP; 27 Jul 2018 00:00:35 -0700
References: <20180706132119.9013-1-remy.horton@intel.com>
 <402f4c38-6ed2-e279-b6dc-e382b0efa250@intel.com> <3135038.1Nyv25uGYd@xps>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>
To: harry.van.haaren@intel.com
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
Message-ID: <58583116-33e8-ae31-2b2f-079f3390bc47@intel.com>
Date: Fri, 27 Jul 2018 08:00:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <3135038.1Nyv25uGYd@xps>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v1] lib/metrics: add check for invalid metric
 keys
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jul 2018 07:00:39 -0000

Harry,

Can you add the following to the cheat-sheet? Don't do many patches 
these days, and I'm not the only one to miss these recently..

..Remy

On 26/07/2018 19:11, Thomas Monjalon wrote:
> Remy,
> You are not new to DPDK. Please pay attention to details:
> - subject does not start with lib/
> - fixes of old commits must have Cc: stable@dpdk.org
>
> 20/07/2018 17:31, Ferruh Yigit:
>> On 7/6/2018 2:21 PM, Remy Horton wrote:
>>> This patchset adds a check to rte_metrics_update_values()
>>> that prevents the updating of metrics when presented with
>>> an invalid metric key. Previously, doing the latter could
>>> result in a crash.
>>>
>>> Fixes: 349950ddb9c5 ("metrics: add information metrics library")
>>>
>>> Signed-off-by: Remy Horton <remy.horton@intel.com>
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied, thanks
>
>