From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id ED923B635 for ; Mon, 16 Feb 2015 19:23:38 +0100 (CET) Received: by mail-wg0-f48.google.com with SMTP id l18so27808132wgh.7 for ; Mon, 16 Feb 2015 10:23:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=POOHZllDrlUFIid3OrmK9aCfo8HOpUrb21oDe7oq+so=; b=I2vHsxbgG/l7kxQfrFPEWLTx5TkF8M7vpFZpotXktACP840U1EKEzwqXVF34Muo+y5 HTVREPgwFYx0TLuy/uWhMeAbPhWglr7TPOH31v5iPlO21zvWQZRvO4OpIIlOVUomtiVz KXzS1xsj9FdvhZl3pwmtQ4j7DHLqSyg4+IeJuRo75fD7zlT1MN1NEOvm2Zc/tp2pQ1fW h8F/AyJ662yOTnntlCiBOoB163oXJfzBf8lxUDcn6r6dcLQL0w9DAhWhX2VchuVmizE6 21aZlTDcv3PEjh3R99g9JsjAFa/hXT+sP+kae1y0JBgZOnFoacC74seOaNSFSVjCIyzq NCIQ== X-Gm-Message-State: ALoCoQmL/VGq27ov4Ws9msIuDSw6GNuUrMGvfxO0Ilb/+ZpjCHXYapqh5obZwqMKEsHUYOz0gYuv X-Received: by 10.194.77.133 with SMTP id s5mr53844534wjw.71.1424111017130; Mon, 16 Feb 2015 10:23:37 -0800 (PST) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id fm10sm20775128wib.7.2015.02.16.10.23.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Feb 2015 10:23:36 -0800 (PST) From: Thomas Monjalon To: Olivier Matz Date: Mon, 16 Feb 2015 19:23:04 +0100 Message-ID: <5865074.TUWIT6VipK@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01DDC8F1@SHSMSX101.ccr.corp.intel.com> References: <1423041925-26956-1-git-send-email-olivier.matz@6wind.com> <1423819371-24222-1-git-send-email-olivier.matz@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DDC8F1@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 00/20] enhance tx checksum offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 18:23:39 -0000 > > The goal of this series is to clarify and simplify the mbuf offload API. > > > > - simplify the definitions of PKT_TX_IP_CKSUM and PKT_TX_IPV4, each > > flag has now only one meaning. No impact on the code. > > > > - add a feature flag for OUTER_IP_CHECKSUM (from Jijiang's patches) > > > > - remove the PKT_TX_UDP_TUNNEL_PKT flag: it is useless from an API point > > of view. It was added because i40e need this info for some reason. We > > have 3 solutions: > > > > - remove the flag and adapt the driver to the API (the choice I made > > for this series). > > > > - remove the flag and stop advertising OUTER_IP_CHECKSUM in i40e > > > > - keep this flag, penalizing performance of drivers that do not > > require the flag. It would also mean that drivers won't support > > outer IP checksum for all tunnel types, but only for the tunnel > > types having a flag. > > > > - a side effect of this API clarification is that there is only one > > way for doing one operation. If the hardware has several ways to > > do the same operation, a choice has to be made in the driver. > > > > The series also provide some enhancements and fixes related to this API rework: > > > > - new tunnel types to testpmd csum forward engine. > > - fixes in i40e to adapt to new api and support more tunnel types. > > > > [1] http://dpdk.org/ml/archives/dev/2015-January/011127.html > > > > Changes in v2: > > - fix test of rx offload flag in parse_vlan() pointed out by Jijiang > > > > Changes in v3: > > - more detailed API comments for PKT_TX_IPV4 and PKT_TX_IPV6 > > - do not calculate the outer UDP checksum if packet is not UDP > > - add a likely() in i40e > > - remove a unlikely() in i40e > > - fix a patch split issue > > - rebase on head > > > > Jijiang Liu (2): > > ethdev: add outer IP offload capability flag > > i40e: advertise outer IPv4 checksum capability > > > > Olivier Matz (18): > > mbuf: remove PKT_TX_IPV4_CSUM > > mbuf: enhance the API documentation of offload flags > > i40e: call i40e_txd_enable_checksum only for offloaded packets > > i40e: remove the use of PKT_TX_UDP_TUNNEL_PKT flag > > mbuf: remove PKT_TX_UDP_TUNNEL_PKT flag > > testpmd: replace tx_checksum command by csum > > testpmd: move csum_show in a function > > testpmd: add csum parse_tunnel command > > testpmd: rename vxlan in outer_ip in csum commands > > testpmd: introduce parse_ipv* in csum fwd engine > > testpmd: use a structure to store offload info in csum fwd engine > > testpmd: introduce parse_vxlan in csum fwd engine > > testpmd: support gre tunnels in csum fwd engine > > testpmd: support ipip tunnel in csum forward engine > > testpmd: add a warning if outer ip cksum requested but not supported > > testpmd: fix TSO when using outer checksum offloads > > i40e: fix offloading of outer checksum for ip in ip tunnels > > i40e: add debug logs for tx context descriptors > > Acked-by: Jijiang Liu < Jijiang.liu@intel.com> Applied, thanks for making API clearer