From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D944A046B for ; Fri, 23 Aug 2019 12:03:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9289E1BFB0; Fri, 23 Aug 2019 12:03:47 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 0F99A1BFA7 for ; Fri, 23 Aug 2019 12:03:46 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id E7B4C300069; Fri, 23 Aug 2019 10:03:44 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 23 Aug 2019 11:03:35 +0100 To: , , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , "Beilei Xing" , Qi Zhang , Jingjing Wu , Wenzhuo Lu , Qiming Yang , Konstantin Ananyev , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Nithin Dabilpuram , Kiran Kumar K CC: References: <20190821204755.1990-1-pbhagavatula@marvell.com> <20190821204755.1990-6-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: <586772ad-a599-7f63-430e-4310e779ceca@solarflare.com> Date: Fri, 23 Aug 2019 13:03:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190821204755.1990-6-pbhagavatula@marvell.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24864.003 X-TM-AS-Result: No-3.054500-8.000000-10 X-TMASE-MatchedRID: byfwvk+IcRkeimh1YYHcKKfOxh7hvX7169aS+7/zbj+qvcIF1TcLYNWb zJ0Wt0DylBQ3ecfI/E+rWrhGlT2Co4iyoM3MvCEPqJSK+HSPY+/pVMb1xnESMgdkFovAReUogK6 qCGa1Z9eidG1ST8eyWEpw2ICA1cc0Kh5xfxw1U6HfhvTQ/n1nGUY6jpCj5qWubPfGfHxv+pFIxB qs4P46rvRMwvE67BjnCIN+uIc0iqt60j/UbRmWKPKUR83BvqItwdaE5TU9NVhtw+n+iKWyyHv6c G7t9uXqe9LKlwIjoArhhLoXIby/KBWVVkGuW6JrIj0zFI5DoJKCQxfA+iO7F6zG9MIKeG/GP9Gk 1ESLw5jOH38lNbOoTO0kh8+z6oXjl2U0xIbdl0ydOp1TjDrlaRwMMtF4a3g9+ZQPGkWiBBejxYy RBa/qJQPTK4qtAgwIawGoUBsEJrdf8IUFWFRhk86bRkm9OpVoITIS6eeKYUXzViPCBksLnY5Fxf kAj2Oo/srG3gYyabXBhOsnWJBf2hoDPaODq3CYa13v/dWhlBrDpk7P5LbK26rxPy+5SQJeZtAoy PHBstDoPeQatSHC8MQ/7OxpZHhAiOcxOu8mckOZ93QdQacVBJt6SEDiCexopzaVCi5Krq9JS3dP TrxYzw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.054500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24864.003 X-MDID: 1566554625-EIjf--hrOoTR Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 5/7] drivers/net: update Rx flow flag and mark capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/21/19 11:47 PM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action > flag and mark. > > Signed-off-by: Pavan Nikhilesh > diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c > index 695580b22..0f842e9e9 100644 > --- a/drivers/net/sfc/sfc_rx.c > +++ b/drivers/net/sfc/sfc_rx.c > @@ -619,7 +619,8 @@ struct sfc_dp_rx sfc_efx_rx = { > .features = SFC_DP_RX_FEAT_INTR, > .dev_offload_capa = DEV_RX_OFFLOAD_CHECKSUM, > .queue_offload_capa = DEV_RX_OFFLOAD_SCATTER | > - DEV_RX_OFFLOAD_RSS_HASH, > + DEV_RX_OFFLOAD_RSS_HASH | > + DEV_RX_OFFLOAD_FLOW_MARK, > .qsize_up_rings = sfc_efx_rx_qsize_up_rings, > .qcreate = sfc_efx_rx_qcreate, > .qdestroy = sfc_efx_rx_qdestroy, The change should be dropped since libefx-datapath does not support flow mark. Also when flow rule with MARK/FLAG is validated it is required to check that the offload is enabled, but don't worry about it, it is not trivial and we'll care about it and provide the patch. Thanks.