From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FD19459A4; Sun, 15 Sep 2024 22:33:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6F734028B; Sun, 15 Sep 2024 22:33:00 +0200 (CEST) Received: from fhigh8-smtp.messagingengine.com (fhigh8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id 981DF4025F for ; Sun, 15 Sep 2024 22:32:59 +0200 (CEST) Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id 0A8971140170; Sun, 15 Sep 2024 16:32:59 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Sun, 15 Sep 2024 16:32:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726432379; x=1726518779; bh=miASknX3FMjSztB/MEjevRUhffkUUSacGBDmJLlpXZE=; b= wka19zAsSCvWwl0N4U61wcpj0ko3V2lx5U0d7ZFbmFNPTShJ0bqdMrsCJmjT/RUu nCQdJ7vJ8r4DCm/jJ6vjQOeL/CxZ2KnxeQVjKySetqyq5drwf12/7WlLAJpHkZFE ZZtq46/fN/mrrnLEzeYE4BypU0cBqZxlr8kWajA0l2ySXn3Mu6vBkoBST3MIOo2m p4TcvMjETsWdhRTCFZTqd6n6IVXsPXDDQ9jOubAqHIqn8ZnNVF9ljIciaI1nJvfc GG7U++9u7WMvR9wfJaDrqwOA7ImQmi+c7mb1O3OQmWwAXVXy8sudPmuS52JS/S5V /o5DbPA0T0s9xf2TOFDqZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726432379; x= 1726518779; bh=miASknX3FMjSztB/MEjevRUhffkUUSacGBDmJLlpXZE=; b=R FWMbD63rRHMYxYkDJEO4qBo0Q5fY1dr88Vj7JntxJ2CFRYBYg9ArdgEeSVfbpyg9 PwX8JVbCndRZtk66NiT4dd09JwHqC8E6J+UNpHxLQz+gImAYITfpZzG/+TUF2Nol xCPlaqK/LLpSpeX0XHXbmMs5UJAwFK1ocYwnueyvgqroH/TQfjLqhH1mPKedMbql YKaAm4Ns4MNWfEBpUwJDRnYTE9mPZ0QgCaQf7yBhfoOv0OQCsqqMgvQt2pe1o70J 9OYDriKHA9LhEnHGnYGYT8w7zPkFusWdDJjW+WHgPtJn4m/rO9HfkHRlMfESHy2o uiPi8oxeh9XHlzatliywQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudekfedgudehvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdej necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdeg keeuveejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdp nhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepghgrrh hrvghtthesuggrmhhorhgvrdhorhhgpdhrtghpthhtohepuggvvhesughpughkrdhorhhg pdhrtghpthhtohepjhgvrhhovghnuggssehgohhoghhlvgdrtghomhdprhgtphhtthhope hruhhshhhilhhgsehgohhoghhlvgdrtghomhdprhgtphhtthhopehjohhshhifrghshhes ghhoohhglhgvrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 15 Sep 2024 16:32:57 -0400 (EDT) From: Thomas Monjalon To: Garrett D'Amore Cc: dev@dpdk.org, Jeroen de Borst , Rushil Gupta , Joshua Washington Subject: Re: Incoming changes for GVNIC Date: Sun, 15 Sep 2024 22:32:55 +0200 Message-ID: <5871788.DvuYhMxLoT@thomas> In-Reply-To: <4cbd4920-5dd2-4efa-9d47-6ddb4fdf9ddc@Spark> References: <4cbd4920-5dd2-4efa-9d47-6ddb4fdf9ddc@Spark> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, Thanks for the heads up. As you can see the GVE driver was written by Intel & Google. I Cc the maintainers from Google. Please make sure they are part of any future communication. You can use this option when sending patches: --cc-cmd devtools/get-maintainer.sh 14/09/2024 22:10, Garrett D'Amore: > This is mostly a heads up.... > > We (WEKA) use various drivers with specific alignment requirements, which causes us to need to need to use multibuffer (scatter/gather) functionality in various drivers. > > Unfortunately, the GVNIC driver was ... very... buggy in this regard (in fact it doesn't work at all in this case!), especially for the DQO mode used on gen 3 (C3) instances. It turns out it was also buggy in that it was not properly resetting the device on teardown, creating a situation where DMA could be occurring to memory regions after process exit (and thus to invalid memory!) > > I've fixed this in our code (its still under review and testing internally) -- but I'd like to upstream these fixes too. (For benefit of anyone who may have concerns about my "credentials" -- I'm well known for my work in NIC drivers (and many others) in Solaris/illumos, and to a lesser extent (and longer ago) NetBSD. > > Anyway, I think I have the detailed instructions for submitting changes to DPDK, but as this is code that is associated with a vendor (Google), I thought I'd reach out first -- if there is a specific code owner here I'd be happy to work with them. > > My changes are based on a cherry pick of this driver's code from the upstream 24.07, but mostly we (WEKA) are using DPDK 24.03. > > Thanks in advance.