From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 42233200
 for <dev@dpdk.org>; Sun, 22 Apr 2018 23:52:08 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B88F021C56;
 Sun, 22 Apr 2018 17:52:07 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 22 Apr 2018 17:52:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=y5qGfVdag5Ig15VdSQCn5puG29
 t+zidazSTdrG05XhQ=; b=kYpS4YzANBwAv0h2g+wSwD/8ar5T7Fj42e23jwcWhU
 62AD9qIdNRj5OSxu7iQwcB2VBNmu4M1kMw0SCpk8FuYk9Ck3gOUMXCz78+plbfOX
 SoUhkJc9BtUxtla/JCCw1u0qTdEhFJUqU6joTBB59huoWHttKZkXvWE83eY4x7c8
 4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=y5qGfV
 dag5Ig15VdSQCn5puG29t+zidazSTdrG05XhQ=; b=J9dbvHgX7ST9KWUKeG+coF
 knn6UK/adhSsH4IpM38L6sZcpKLEfdJlJiZ9NFaau13A6GyUDlqA+0WChq7cqc+S
 pt6gvmqDWBa+44oy8CLmVj+9BVbXhFmngf8/V8scGaELBlaNlOpQUQdnqFtI7VX+
 vpFuA8xT41zWyKC6qiY6Gf81puK0SckZwmLggbJ5h7kQxFUHKhkbDpSOYeFt3Mjb
 fY0uH7ab/Q43qqUY88J0dxb76XyTSQ13CvIzwpAjMyJcDuJZz+evx7TTCfd185TI
 XoI0/whaLItlt0sv7IgNnyZIOzaXIVbOtmqiPnm2ATSuOZKT0rxrsr8Twi7HfdLw
 ==
X-ME-Sender: <xms:BwTdWoH6-WhgoMs-Xw-Cewv67jtURnaZGIixSkmdk2rUzWT4ZsGgJQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 22F29E4483;
 Sun, 22 Apr 2018 17:52:07 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org
Date: Sun, 22 Apr 2018 23:52:05 +0200
Message-ID: <5886590.iS5MIAAj3q@xps>
In-Reply-To: <7fe49878f2716e3ad1c5cee204d50d5f3c3a2716.1521587199.git.gaetan.rivet@6wind.com>
References: <cover.1507796100.git.gaetan.rivet@6wind.com>
 <cover.1521587199.git.gaetan.rivet@6wind.com>
 <7fe49878f2716e3ad1c5cee204d50d5f3c3a2716.1521587199.git.gaetan.rivet@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 08/10] devargs: make parsing variadic
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Apr 2018 21:52:08 -0000

21/03/2018 00:20, Gaetan Rivet:
>  /**
>   * Add a device to the user device list
>   *
> - * For PCI devices, the format of arguments string is "PCI_ADDR" or
> - * "PCI_ADDR,key=val,key2=val2,...". Examples: "08:00.1", "0000:5:00.0",
> - * "04:00.0,arg=val".
> + * The format is
>   *
> - * For virtual devices, the format of arguments string is "DRIVER_NAME*"
> - * or "DRIVER_NAME*,key=val,key2=val2,...". Examples: "net_ring",
> - * "net_ring0", "net_pmdAnything,arg=0:arg2=1". The validity of the
> - * driver name is not checked by this function, it is done when probing
> - * the drivers.
> + *     bus:device_identifier,arg1=val1,arg2=val2
> + *
> + * Examples:
> + *
> + *     pci:0000:05.00.0,arg=val
> + *     vdev:net_ring0

I think this part should not be in the patch.
Or I miss something?