From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C30E042366; Wed, 11 Oct 2023 18:31:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6068A400EF; Wed, 11 Oct 2023 18:31:33 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2080.outbound.protection.outlook.com [40.107.220.80]) by mails.dpdk.org (Postfix) with ESMTP id CA624400D7 for ; Wed, 11 Oct 2023 18:31:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RHNvokkatdxaMk09dNUJTxtuguxG+PzhRABLu36py5xqZ8/ZYUhKi4vkmSvWzEpyQCq5yOrcNLkHG8bFIMfKOj9a1u+gPowp+cIwnfPdNL8mt7nt6kqp8qcHdlOEcZyBrSKEmRjxYhNzNQg5HGvs/FzA9guPxsFnxg2giRmo3bdr2MdtT+v9YublQvdYvoFIl83Kx0+2hdD7WfXg9CyIPCIYN2xYFcgBwcohnny/U7H4xZRGAiLFw19MjRZYtJ+k8q8ROP8s4GjPhkj7U8L0oL+xvAOyeeA1t1mU1a77w+kxvCLImukRgUh+MDCLeNwq+3jD4bMRtPncyRWhH6D75g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nHTxrikGCQugYqPZQ0Ipd1tQ/6s/C6IPQJnCzjc4ZVQ=; b=JUmEnx7ajtqf9dPMD4pfdACiomQloHTVQP5+yaUO92fqsWee1zl/emu57/E5lKAtC4DCyKQqAU9WhofOW4FizRgrFLZ5rw4lOQbqawBrQumErthOcwMFzMAyPfDeaiSwEev/yrnPxUaudLEGIOpin3scgbtQ7ty57HguTdZEKkJrXrMgF8mN0+WIuOoAu3iAY5MRroiM96Nkbufbvi/WRarYKmuwtkwQU9oEYxCVbN2iG3adcHl0J3vHYRoDlQKKWEAEVPTR7dFwfsr7UdNl+zDWgrZtdjXK5flOZZjR0sYRprfhGI4oWSgCO7J6Lw5HD2DjwaZtkGTQex9tETJM4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHTxrikGCQugYqPZQ0Ipd1tQ/6s/C6IPQJnCzjc4ZVQ=; b=vn65aVct97xJtqdjawOsuGitKZAtdd/1g5fbWScVoInyXg9XUxwu5rL8qXsnrJiZ8EhyNs/s169zGbLmByNaPPWkVi06gDxDWBd7h4c7G528Zp667PFilzCoHteEewNpNtGsnDwHCtUImjJWtCzyb3I247X19IDur9QnucsGAVE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB6236.namprd12.prod.outlook.com (2603:10b6:208:3e4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Wed, 11 Oct 2023 16:31:28 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Wed, 11 Oct 2023 16:31:28 +0000 Message-ID: <5886a6e6-1bd1-48e6-95c0-7384eac710e2@amd.com> Date: Wed, 11 Oct 2023 17:31:24 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/40] ethdev: overwrite some comment related to RSS Content-Language: en-US To: Jie Hai , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Ori Kam Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-2-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231011092805.693171-2-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0176.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:36f::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6236:EE_ X-MS-Office365-Filtering-Correlation-Id: 7868667a-e35d-4056-cd37-08dbca7784ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OjtApeXwod2lkEDW9LPSJJZLn0CKHp8qZSEMuMSxFEBCqdynhPlUH+YPupE39UYrBlDiuzqsgk31Tk+9KBAQBvBi+T/ouTTK1kCOR/HynMlxlGud5CzXTVKYZV7HAAQ9MwxkLxIeyb/de14HI38KEynsPpPi2z20RYEMc3DckDoR00ksb7xJgypez1reuPB9sGzNbejtsGD0d/9qxvxJV+14b8AYEuLqmHxdQynyS3siuShaFiQ7ZzxW0Uce8njYVwflH5VGUxKh8+iqGN0YxIBisWdpKam2rQSRDSMmP8zJIZpQoH4dzritAhvmUaK08nV3Kv3M0YZ7nb+dydbuFuZXdTnLqsMBmalaRerZjtQge2WgkXBC+Blxs4C1qgR5fPtT0JrTzN92wgAQ/c+sRpVpOFF3b1hellWbQwMS1iMk4UXctw0g4sPEXF3xgC4LilzsvZxG7rjoT/HiLQ/xjFVAHQIbklzy6qaIPu9B/b6quRvL/AcIJK6Fw0/J2bQ0SbCtzrHoQ/Ni0541/qzWBsf2Lgu1PUv3CNUo3UzNc5y0iy3BM/bBY8qNpgcaowi7dLh0jngyv4aSpq79Rg/jrTPf3f1oJQSXo1lX+EiNfAsBa0fOAifh6rK9FAWGFBNCfXJ3H3SuxhSzh5yR988o3g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(396003)(136003)(39860400002)(366004)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(38100700002)(31696002)(86362001)(36756003)(31686004)(6512007)(44832011)(8676002)(6486002)(53546011)(316002)(8936002)(478600001)(6506007)(41300700001)(2906002)(6666004)(5660300002)(2616005)(66556008)(66946007)(110136005)(66476007)(4326008)(83380400001)(26005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RS9TbkU1WkU4aDFmV0RvNkpGTC9OM1BKNzl0TkVqUjN0cjZIM2xqenQrQVJv?= =?utf-8?B?WCtSbEZzUTgvYWplc2VDcm0xdGUyaWdhNnhwU2dsVHlLdzJwNjlweTlGSUkz?= =?utf-8?B?L3ZkS3BGMzJDSlZVbXA2V29tNVFCS3BLSVRrN3NUV1d5alJ3WHhLZ3pXaG42?= =?utf-8?B?a01xNjVqY0tPQ3N1cit6VUdzcjNlK09rc2QzUHNDZjNIcExWaDRQd3VuRjlC?= =?utf-8?B?SmV6TmN1ckVISGhVKzBXWml4dTF5M3gvcnJ6VTljTFYxTGs2blZjNUNXaTU5?= =?utf-8?B?YVk0UlBCZHFlR3BsbE9iU0hpUFg3Y21idFUvTzhIYTkwSjlCekQzYTNEaW4w?= =?utf-8?B?eEVJVXFlNHc0R0R6YW1tOHY5YVdmVXdKOGNXK3JOR0tPZTVSQ1E5V2J4bVZk?= =?utf-8?B?dktoUktHQ2hoWXhZcHlDZ3FYUlllV09DTnhRbGl2eHJWUUh5T3ZUaTkzQ3J4?= =?utf-8?B?MnVXVCtNVVVrUURVeVl3TVhjS3gvc2ZNU3RWVy9tU2NudHBtSjFJRlQzMGJF?= =?utf-8?B?Y0xBdGZ1eE01T1dtNHl5WEJKY1ZDVm1qa0JhaHRuWTZTalh3ZXZJR2Nxc295?= =?utf-8?B?dEpNbE9YSDZoNHk1eGNVZTg3bXFHeU5OR053eWI1cko3Q1lUbGVlcG9oeW1w?= =?utf-8?B?NkdNMkozVVlwTDlsR1UrOTFEMUIrWnZJdFk5SGVabHFrdmpTRkdlTHZ5VjlQ?= =?utf-8?B?ZkpIczlkMU5PaTlkeGhnc2pJZitTMDZhMHM3T2x3NW80a0gzL0IybVNGTkd6?= =?utf-8?B?bW5JNWJ4cG43RUNCWldKSFc3L0FaR1pZS01KWHVOdnRrbnFpQ29QUlBHUE9Y?= =?utf-8?B?eHJKaENhdnZpakdXT29ZUFhjYzc5Q2tYTkZzUTk5UldHMldUM3ZZNlNpMkda?= =?utf-8?B?eU9lTVJCcUNGYjVUdi9RbmZoaWxKdDZIa25adGZMSUs5STROUmNMWVpzZmNM?= =?utf-8?B?Q1hnSENqODBNYmI3ek9WNERDaWY0U09GbUd2UzhhSnFjNFhQVFM3Y0hBb1Z3?= =?utf-8?B?dVZIWmVqaDNjeUxtb1B5V1hrd2tFRjhxbkkyZ3R5eTcvNjlxRGlwNFpHODdy?= =?utf-8?B?K3hsdU1UTHI5VEpmS21jTHIzc0ZMcEpwOEUxaUFSTzB6S0lWb3hYaEtxZEpw?= =?utf-8?B?djB0QjhkcnRXVVRyZ1d2UUFjNDVGeVRaVkM0NzljR2RpWE1TOWxMckl4ZU4w?= =?utf-8?B?L3dNaVhFZm8ycXJVdit1NnFGL21hQXR3Z08zclcySEMrSm4zbUptU21aUWIw?= =?utf-8?B?VEVaVjFYN2lsL05oSmY1cHk3UlhqQUtpZ1UxSU10UnAwNnEyOW5CZklDUm9o?= =?utf-8?B?Tjl4Q1VOMjRwOThaWW5iemp2UEwyTFByNVRyR3VPSEFDWE1XRldJdERkenJ0?= =?utf-8?B?czFKRWxvQ0tYNGtadTcwanN4VEtUb0g2MENxZWtJU3ZjT3RkOS9kZG5rSnhn?= =?utf-8?B?S0x0aGFieGRMRDE0aUpCaGxPeStlamxVSHZveDJvYXJZS204RTVIa3JDTlZL?= =?utf-8?B?Q01UUmtMd054R0ZGTlAwTU5DZllHZ1o0b1lOL013eThOeDF0U1FueElVL05K?= =?utf-8?B?QUcvN3h5aU5BQXNiQTltUFFrRTczRFBJYmNmMDRwQzJzZ051bVNVcDlrczI2?= =?utf-8?B?aEtmOWRUV1hXcEhzTjJMbXROWDJvMkllZHFJaGpGNHFoc0N6NU5pL1dqb2Er?= =?utf-8?B?akRTYmtId2J3OHljaCtiMkRDeS9LVkJLbkl1MHlQRUlmeXBncHdMQXV3czJM?= =?utf-8?B?ZGFwY1NMZWV0RmFJdXk0a1pZN1NtKzYyN3hWMUZNV3NVemNGNkVJWEtVQm81?= =?utf-8?B?djJlMWZIT2hoQ3g0VThodEY5SE5SZ1lRYlVBdDBQMzgrdVhzbVBRYVpvdGFT?= =?utf-8?B?bmhjQ0VCU2dEQThIZlJQcU5DdG0xeXhIenhqSTBydHZsSDdSZGhtbS8rUjNC?= =?utf-8?B?Tk40ZmpYTXNlYXhMZUlVUWgvT096RXBvTmFzZ1gvT2NHVXpaVGx2NWpkaG1v?= =?utf-8?B?cS9DaXljL1RMaDhpVkRQYVhlbXZOck5ibHdTUXlHVnRJNTdkeHNtOWtOaTdw?= =?utf-8?B?VGIxOU5GRERlZHlBVVZsMVN2enBhSDRZSXpZblNldFI5RTRaZk1FQzBWd1Y0?= =?utf-8?Q?ZgyzvWYKY1qLWskHSvGj3DGm0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7868667a-e35d-4056-cd37-08dbca7784ba X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 16:31:28.7264 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RjHcgprVtouiEzr2SC3Jx+IiFVtWWTuvInmC9WUGH1wOZInLamG3jMgUe6ZmQmiG X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6236 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/11/2023 10:27 AM, Jie Hai wrote: > 1. overwrite the comments of fields of 'rte_eth_rss_conf'. > 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev.h | 29 ++++++++++++++--------------- > lib/ethdev/rte_flow.h | 3 +++ > 2 files changed, 17 insertions(+), 15 deletions(-) > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 8542257721c9..b9e4e21189d2 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -448,24 +448,23 @@ struct rte_vlan_filter_conf { > /** > * A structure used to configure the Receive Side Scaling (RSS) feature > * of an Ethernet port. > - * If not NULL, the *rss_key* pointer of the *rss_conf* structure points > - * to an array holding the RSS key to use for hashing specific header > - * fields of received packets. The length of this array should be indicated > - * by *rss_key_len* below. Otherwise, a default random hash key is used by > - * the device driver. > - * > - * The *rss_key_len* field of the *rss_conf* structure indicates the length > - * in bytes of the array pointed by *rss_key*. To be compatible, this length > - * will be checked in i40e only. Others assume 40 bytes to be used as before. > - * > - * The *rss_hf* field of the *rss_conf* structure indicates the different > - * types of IPv4/IPv6 packets to which the RSS hashing must be applied. > - * Supplying an *rss_hf* equal to zero disables the RSS feature. > */ > struct rte_eth_rss_conf { > - uint8_t *rss_key; /**< If not NULL, 40-byte hash key. */ > + /** > + * If used to query, the'rss_key_len' indicates the size of rss key of > + * the hardware. And only when rss_key_len is not zero, the 'rss_key' > + * is valid. > + * If used to configure, rss_key_len indicates the length of the > + * 'rss_key' if 'rss_key' is not empty. > Ahh, different APIs have different expectations :( Can you please explicitly name the APIs, instead of "to query", "to configure"? And there is a note in original comment that *rss_key_len* is only checked by i40e, rest assume this value as 40 bytes. New comment doesn't have it. > + */ > + uint8_t *rss_key; > uint8_t rss_key_len; /**< hash key length in bytes. */ > - uint64_t rss_hf; /**< Hash functions to apply - see below. */ > + /** > + * Indicating which type of packets and which part of the packets > + * to apply for RSS hash, (see RTE_ETH_RSS_*). > There is something doesn't sound right from language perspective, perhaps someone whose native language is English can help, what about: "Indicates the type of packets or the specific part of packets to which RSS hashing is to be applied." > + * Setting *rss_hf* to zero disables the RSS feature. > + */ > + uint64_t rss_hf; > }; > > /* > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index b385741fba6d..5d9e3c68af7b 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3227,6 +3227,9 @@ struct rte_flow_query_count { > * Hash function types. > */ > enum rte_eth_hash_function { > + /** > + * DEFAULT means driver decides which hash algorithm to pick. > + */ > RTE_ETH_HASH_FUNCTION_DEFAULT = 0, > RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */ > RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */