From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alvin Zhang <alvinx.zhang@intel.com>, <xiaoyun.li@intel.com>,
<konstantin.ananyev@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v6 1/2] app/testpmd: update forward engine beginning
Date: Fri, 8 Oct 2021 18:01:16 +0100 [thread overview]
Message-ID: <58871e2c-1caf-9d8e-ba5d-6818d28e0f5b@intel.com> (raw)
In-Reply-To: <20210923080129.5068-1-alvinx.zhang@intel.com>
On 9/23/2021 9:01 AM, Alvin Zhang wrote:
> For each forward engine, there may be some special conditions
> must be met before the forwarding runs.
>
> Adding checks for these conditions in configuring is not suitable,
> because one condition may rely on multiple configurations, and the
> conditions required by each forward engine is not general.
>
> The best solution is each forward engine has a callback to check
> whether these conditions are met, and then testpmd can call the
> callback to determine whether the forwarding can be started.
>
> There was a void callback 'port_fwd_begin' in forward engine,
> it did some initialization for forwarding, this patch updates its
> return value then we can add some checks in it to confirm whether
> the forwarding can be started. In addition, this patch calls the
> callback before the forwarding stats is reset and then launches the
> forwarding engine.
>
> Bugzilla ID: 797
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Series applied to dpdk-next-net/main, thanks.
Updated log messages slightly while merging.
prev parent reply other threads:[~2021-10-08 17:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 8:20 [dpdk-dev] [PATCH] app/testpmd: fix random number of Tx segments Alvin Zhang
2021-09-06 8:58 ` Li, Xiaoyun
2021-09-06 10:03 ` Zhang, AlvinX
2021-09-06 10:54 ` Li, Xiaoyun
2021-09-07 2:25 ` Zhang, AlvinX
2021-09-07 8:05 ` Li, Xiaoyun
2021-09-17 1:39 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: update forward engine beginning Alvin Zhang
2021-09-17 1:39 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix txonly forwording Alvin Zhang
2021-09-18 3:06 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: update forward engine beginning Alvin Zhang
2021-09-18 3:06 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix txonly forwording Alvin Zhang
2021-09-18 8:20 ` Li, Xiaoyun
2021-09-18 8:31 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: update forward engine beginning Li, Xiaoyun
2021-09-18 8:50 ` Zhang, AlvinX
2021-09-22 2:49 ` [dpdk-dev] [PATCH v4 " Alvin Zhang
2021-09-22 2:49 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix txonly forwording Alvin Zhang
2021-09-22 5:58 ` Li, Xiaoyun
2021-09-22 5:59 ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: update forward engine beginning Li, Xiaoyun
2021-09-23 1:49 ` [dpdk-dev] [PATCH v5 " Alvin Zhang
2021-09-23 1:49 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: fix txonly forwording Alvin Zhang
2021-09-23 4:25 ` Ivan Malov
2021-09-23 5:11 ` Zhang, AlvinX
2021-09-23 8:01 ` [dpdk-dev] [PATCH v6 1/2] app/testpmd: update forward engine beginning Alvin Zhang
2021-09-23 8:01 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix txonly forwarding Alvin Zhang
2021-10-08 17:01 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58871e2c-1caf-9d8e-ba5d-6818d28e0f5b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).