From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id B82931B3B8 for ; Wed, 10 Oct 2018 08:50:44 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id A75A98006D; Wed, 10 Oct 2018 06:50:38 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 10 Oct 2018 07:50:33 +0100 To: Thomas Monjalon , CC: References: <20181003194039.7202-1-thomas@monjalon.net> <20181003194039.7202-2-thomas@monjalon.net> From: Andrew Rybchenko Message-ID: <588807eb-b33c-f152-2ed7-7e9a1fb0dcf1@solarflare.com> Date: Wed, 10 Oct 2018 09:49:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181003194039.7202-2-thomas@monjalon.net> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24146.003 X-TM-AS-Result: No-3.568000-8.000000-10 X-TMASE-MatchedRID: cgbqQT5W8hcOwH4pD14DsPHkpkyUphL9GFwEGDRX5uxrX6wzM0QF9An9 ofQNoBQFu5Uli5Yf9rvM/15V7ZfCwzblc6Gei4nlIj0zFI5DoJJeCrB32KOS0KMLUT/MIQivCvE 68u8U9k8R4d+Uvhl0qv1VprTjLOsRsKrmNJBIHWedOp1TjDrlaRwMMtF4a3g9+ZQPGkWiBBejxY yRBa/qJQPTK4qtAgwIEFY6gDmeXI0qyYS0oyUVZg5TcQ3PqutXsRC/sz4UEYdH7ku1JJa9lasln ILylX2uQcOpP6UlMDYu0NeBl5IIOv1pzwFFztZTMBZ7EcejrpeqwgQXWUL4V4fDZU1nsvnMgWry S34ADYwG+kc6tg4XQXy3cg3ViR/CBwlSjJS3fB20IrBUD35qHPnKyApDs6r4aPF06D3/zDnnfQy 90G7CHVZca9RSYo/b X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.568000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24146.003 X-MDID: 1539154239-yiROMm3nXQrq Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] devargs: rename enum items with singular form X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 06:50:45 -0000 On 10/3/18 10:40 PM, Thomas Monjalon wrote: > The enum names are *_params (plural form). > And the items are also using the plural form: *_PARAMS_*. > It looks more natural to use the singular form *_PARAM_* for items. > > Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko