[dpdk-dev] [PATCH 1/2] doc: use SPDX tag for bnx2x PMD guide

[dpdk-dev] [PATCH 1/2] doc: use SPDX tag for bnx2x PMD guide

[Rasesh Mody]

Signed-off-by: Rasesh Mody <rmody@marvell.com>
---
 doc/guides/nics/bnx2x.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst
index cecbfc2e7..a7dee0c10 100644
--- a/doc/guides/nics/bnx2x.rst
+++ b/doc/guides/nics/bnx2x.rst
@@ -1,6 +1,5 @@
-..  BSD LICENSE
+..  SPDX-License-Identifier: BSD-3-Clause
     Copyright (c) 2015 QLogic Corporation
-    All rights reserved.
 
     Redistribution and use in source and binary forms, with or without
     modification, are permitted provided that the following conditions
-- 
2.18.0

[dpdk-dev] [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

[Rasesh Mody]

Add and update co-existence considerations for bnx2x PMD

Signed-off-by: Rasesh Mody <rmody@marvell.com>
---
 doc/guides/nics/bnx2x.rst | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst
index a7dee0c10..358ed7927 100644
--- a/doc/guides/nics/bnx2x.rst
+++ b/doc/guides/nics/bnx2x.rst
@@ -69,9 +69,18 @@ Co-existence considerations
   bnx2fi) is not supported on the same adapter. So storage personality
   has to be disabled on that adapter when used in DPDK applications.
 
-- For SR-IOV case, bnx2x PMD will be used to bind to SR-IOV VF device and
-  Linux native kernel driver (bnx2x) will be attached to SR-IOV PF.
-
+- Linux kernel drivers and bnx2x PMD can’t be mixed on a given BCM578xx
+  adapter. This type of coexistence is unsupported. A given adapter
+  needs to be completely used by DPDK or Linux drivers, when SR-IOV
+  is not enabled. Before binging DPDK driver to one or more devices on
+  the adapter, please make sure to unbind Linux drivers from all devices
+  of the adapter. If there are multiple adapters on the system, one or
+  more adapter can be used by DPDK driver and other adapters can be used
+  by Linux drivers.
+
+- When SR-IOV is enabled, Linux native kernel driver (bnx2x) can be
+  bound to the PFs of a given adapter and either DPDK or Linux drivers
+  can be bound to the VFs of the adapter.
 
 Supported QLogic NICs
 ---------------------
-- 
2.18.0

Re: [dpdk-dev] [PATCH 1/2] doc: use SPDX tag for bnx2x PMD guide

[Rasesh Mody]

+cc Jerin and John with proper email.

On 7/31/19, 1:02 AM, "Rasesh Mody" <rmody@marvell.com> wrote:

    Signed-off-by: Rasesh Mody <rmody@marvell.com>
    ---
     doc/guides/nics/bnx2x.rst | 3 +--
     1 file changed, 1 insertion(+), 2 deletions(-)
    
    diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst
    index cecbfc2e7..a7dee0c10 100644
    --- a/doc/guides/nics/bnx2x.rst
    +++ b/doc/guides/nics/bnx2x.rst
    @@ -1,6 +1,5 @@
    -..  BSD LICENSE
    +..  SPDX-License-Identifier: BSD-3-Clause
         Copyright (c) 2015 QLogic Corporation
    -    All rights reserved.
     
         Redistribution and use in source and binary forms, with or without
         modification, are permitted provided that the following conditions
    -- 
    2.18.0
    
    

Re: [dpdk-dev] [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

[Thomas Monjalon]

31/07/2019 10:02, Rasesh Mody:
> Add and update co-existence considerations for bnx2x PMD
> 
> Signed-off-by: Rasesh Mody <rmody@marvell.com>
> ---
>  doc/guides/nics/bnx2x.rst | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst
> index a7dee0c10..358ed7927 100644
> --- a/doc/guides/nics/bnx2x.rst
> +++ b/doc/guides/nics/bnx2x.rst
> @@ -69,9 +69,18 @@ Co-existence considerations
>    bnx2fi) is not supported on the same adapter. So storage personality
>    has to be disabled on that adapter when used in DPDK applications.
>  
> -- For SR-IOV case, bnx2x PMD will be used to bind to SR-IOV VF device and
> -  Linux native kernel driver (bnx2x) will be attached to SR-IOV PF.
> -
> +- Linux kernel drivers and bnx2x PMD can’t be mixed on a given BCM578xx
> +  adapter. This type of coexistence is unsupported. A given adapter
> +  needs to be completely used by DPDK or Linux drivers, when SR-IOV
> +  is not enabled. Before binging DPDK driver to one or more devices on
> +  the adapter, please make sure to unbind Linux drivers from all devices
> +  of the adapter. If there are multiple adapters on the system, one or
> +  more adapter can be used by DPDK driver and other adapters can be used
> +  by Linux drivers.
> +
> +- When SR-IOV is enabled, Linux native kernel driver (bnx2x) can be
> +  bound to the PFs of a given adapter and either DPDK or Linux drivers
> +  can be bound to the VFs of the adapter.

Same comment as for qede: this is not specific to the PMD.
Please update and reference the Linux guide.

Re: [dpdk-dev] [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

[Shahed Shaikh]

+  is not enabled. Before binging DPDK driver to one or more devices on



Binging=>binding



Thanks,

Shahed

> -----Original Message-----

> From: Rasesh Mody <rmody@marvell.com>

> Sent: Wednesday, July 31, 2019 1:32 PM

> To: dev@dpdk.org

> Cc: Rasesh Mody <rmody@marvell.com>; John McNamara

> <john.mcnamara@intel.com>; Thomas Monjalon <thomas@monjalon.net>;

> Jerin Jacob Kollanukkaran <jerinj@marvell.com>; GR-Everest-DPDK-Dev <GR-

> Everest-DPDK-Dev@marvell.com>

> Subject: [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

>

> Add and update co-existence considerations for bnx2x PMD

>

> Signed-off-by: Rasesh Mody <rmody@marvell.com<mailto:rmody@marvell.com>>

> ---

>  doc/guides/nics/bnx2x.rst | 15 ++++++++++++---

>  1 file changed, 12 insertions(+), 3 deletions(-)

>

> diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst index

> a7dee0c10..358ed7927 100644

> --- a/doc/guides/nics/bnx2x.rst

> +++ b/doc/guides/nics/bnx2x.rst

> @@ -69,9 +69,18 @@ Co-existence considerations

>    bnx2fi) is not supported on the same adapter. So storage personality

>    has to be disabled on that adapter when used in DPDK applications.

>

> -- For SR-IOV case, bnx2x PMD will be used to bind to SR-IOV VF device and

> -  Linux native kernel driver (bnx2x) will be attached to SR-IOV PF.

> -

> +- Linux kernel drivers and bnx2x PMD can’t be mixed on a given BCM578xx

> +  adapter. This type of coexistence is unsupported. A given adapter

> +  needs to be completely used by DPDK or Linux drivers, when SR-IOV

> +  is not enabled. Before binging DPDK driver to one or more devices on

> +  the adapter, please make sure to unbind Linux drivers from all

> +devices

> +  of the adapter. If there are multiple adapters on the system, one or

> +  more adapter can be used by DPDK driver and other adapters can be

> +used

> +  by Linux drivers.

> +

> +- When SR-IOV is enabled, Linux native kernel driver (bnx2x) can be

> +  bound to the PFs of a given adapter and either DPDK or Linux drivers

> +  can be bound to the VFs of the adapter.

>

>  Supported QLogic NICs

>  ---------------------

> --

> 2.18.0

[dpdk-dev] [PATCH v2 1/2] doc: use SPDX tag for bnx2x PMD guide

[Rasesh Mody]

Use SPDX tag for bnx2x PMD guide

v2:
add short patch description

Signed-off-by: Rasesh Mody <rmody@marvell.com>
---
 doc/guides/nics/bnx2x.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst
index cecbfc2e7..a7dee0c10 100644
--- a/doc/guides/nics/bnx2x.rst
+++ b/doc/guides/nics/bnx2x.rst
@@ -1,6 +1,5 @@
-..  BSD LICENSE
+..  SPDX-License-Identifier: BSD-3-Clause
     Copyright (c) 2015 QLogic Corporation
-    All rights reserved.
 
     Redistribution and use in source and binary forms, with or without
     modification, are permitted provided that the following conditions
-- 
2.18.0

[dpdk-dev] [PATCH v2 2/2] doc: add a co-existence consideration for bnx2x PMD

[Rasesh Mody]

Add and update co-existence considerations for bnx2x PMD
Cc: stable@dpdk.org

v2:
Made co-existence considerations for QLogic adapters more specific

Signed-off-by: Rasesh Mody <rmody@marvell.com>
---
 doc/guides/nics/bnx2x.rst | 30 +++++++++++++++++++++---------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst
index a7dee0c10..00e131484 100644
--- a/doc/guides/nics/bnx2x.rst
+++ b/doc/guides/nics/bnx2x.rst
@@ -33,7 +33,7 @@ BNX2X Poll Mode Driver
 The BNX2X poll mode driver library (**librte_pmd_bnx2x**) implements support
 for **QLogic 578xx** 10/20 Gbps family of adapters as well as their virtual
 functions (VF) in SR-IOV context. It is supported on several standard Linux
-distros like Red Hat 7.x and SLES12 OS. It is compile-tested under FreeBSD OS.
+distros like RHEL and SLES. It is compile-tested under FreeBSD OS.
 
 More information can be found at `QLogic Corporation's Official Website
 <http://www.qlogic.com>`_.
@@ -64,14 +64,26 @@ The features not yet supported include:
 Co-existence considerations
 ---------------------------
 
-- BCM578xx being a CNA can have both NIC and Storage personalities.
-  However, coexistence with storage protocol drivers (cnic, bnx2fc and
-  bnx2fi) is not supported on the same adapter. So storage personality
-  has to be disabled on that adapter when used in DPDK applications.
-
-- For SR-IOV case, bnx2x PMD will be used to bind to SR-IOV VF device and
-  Linux native kernel driver (bnx2x) will be attached to SR-IOV PF.
-
+- QLogic 578xx CNAs support Ethernet, iSCSI and FCoE functionalities.
+  These functionalities are supported using QLogic Linux kernel
+  drivers bnx2x, cnic, bnx2i and bnx2fc. DPDK is supported on these
+  adapters using bnx2x PMD.
+
+- When SR-IOV is not enabled on the adapter,
+  QLogic Linux kernel drivers (bnx2x, cnic, bnx2i and bnx2fc) and bnx2x
+  PMD can’t be attached to different PFs on a given QLogic 578xx
+  adapter.
+  A given adapter needs to be completely used by DPDK or Linux drivers.
+  Before binding DPDK driver to one or more PFs on the adapter,
+  please make sure to unbind Linux drivers from all PFs of the adapter.
+  If there are multiple adapters on the system, one or more adapters
+  can be used by DPDK driver completely and other adapters can be used
+  by Linux drivers completely.
+
+- When SR-IOV is enabled on the adapter,
+  Linux kernel drivers (bnx2x, cnic, bnx2i and bnx2fc) can be bound
+  to the PFs of a given adapter and either bnx2x PMD or Linux drivers
+  bnx2x can be bound to the VFs of the adapter.
 
 Supported QLogic NICs
 ---------------------
-- 
2.18.0

Re: [dpdk-dev] [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

[Rasesh Mody]

>From: Thomas Monjalon <thomas@monjalon.net>
>Sent: Wednesday, July 31, 2019 1:33 AM
>
>31/07/2019 10:02, Rasesh Mody:
>> Add and update co-existence considerations for bnx2x PMD
>>
>> Signed-off-by: Rasesh Mody <rmody@marvell.com>
>> ---
>>  doc/guides/nics/bnx2x.rst | 15 ++++++++++++---
>>  1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst
>> index a7dee0c10..358ed7927 100644
>> --- a/doc/guides/nics/bnx2x.rst
>> +++ b/doc/guides/nics/bnx2x.rst
>> @@ -69,9 +69,18 @@ Co-existence considerations
>>    bnx2fi) is not supported on the same adapter. So storage personality
>>    has to be disabled on that adapter when used in DPDK applications.
>>
>> -- For SR-IOV case, bnx2x PMD will be used to bind to SR-IOV VF device
>> and
>> -  Linux native kernel driver (bnx2x) will be attached to SR-IOV PF.
>> -
>> +- Linux kernel drivers and bnx2x PMD can’t be mixed on a given
>> +BCM578xx
>> +  adapter. This type of coexistence is unsupported. A given adapter
>> +  needs to be completely used by DPDK or Linux drivers, when SR-IOV
>> +  is not enabled. Before binging DPDK driver to one or more devices
>> +on
>> +  the adapter, please make sure to unbind Linux drivers from all
>> +devices
>> +  of the adapter. If there are multiple adapters on the system, one
>> +or
>> +  more adapter can be used by DPDK driver and other adapters can be
>> +used
>> +  by Linux drivers.
>> +
>> +- When SR-IOV is enabled, Linux native kernel driver (bnx2x) can be
>> +  bound to the PFs of a given adapter and either DPDK or Linux
>> +drivers
>> +  can be bound to the VFs of the adapter.
>
>Same comment as for qede: this is not specific to the PMD.
>Please update and reference the Linux guide.

Please see the v2 set with documentation specific to QLogic adapters and use of bnx2x PMD.

Thanks!
-Rasesh

Re: [dpdk-dev] [PATCH v2 1/2] doc: use SPDX tag for bnx2x PMD guide

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Rasesh Mody <rmody@marvell.com>
> Sent: Monday, August 5, 2019 2:54 PM
> To: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>
> Cc: Rasesh Mody <rmody@marvell.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; GR-
> Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>
> Subject: [PATCH v2 1/2] doc: use SPDX tag for bnx2x PMD guide
> 
> Use SPDX tag for bnx2x PMD guide
> 
> v2:
> add short patch description
> 
> Signed-off-by: Rasesh Mody <rmody@marvell.com>

Series applied to dpdk-next-net-mrvl/master. Thanks.