From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id EEB6FD0B2 for <dev@dpdk.org>; Mon, 22 Oct 2018 16:19:17 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 78033B4006A; Mon, 22 Oct 2018 14:19:14 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 22 Oct 2018 15:19:08 +0100 To: Thomas Monjalon <thomas@monjalon.net> CC: <dev@dpdk.org>, <gaetan.rivet@6wind.com>, <ophirmu@mellanox.com>, <ferruh.yigit@intel.com>, <olivier.matz@6wind.com>, <remy.horton@intel.com>, <bruce.richardson@intel.com> References: <20181009021858.19216-1-thomas@monjalon.net> <20181022131530.6403-5-thomas@monjalon.net> <a4fd6d5d-2e21-73a4-8601-af98f5956ad3@solarflare.com> <1600652.GbAxOGCmMO@xps> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <589553b0-5e4f-83ec-f11f-1d26a08a8691@solarflare.com> Date: Mon, 22 Oct 2018 17:18:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <1600652.GbAxOGCmMO@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24170.003 X-TM-AS-Result: No-5.559100-8.000000-10 X-TMASE-MatchedRID: csPTYAMX1+EOwH4pD14DsPHkpkyUphL9j5Ieyo542q9794qAHfSq0oZd Y0GqfUpiMH15E661CBNOrgDJ7aGZ2nupOhUR/AE8pkIW3Gref31zd7C7BtJobgFbHA9TqNLQhbV Mkp0EYS2cYirrolnmjvSPy3QY5R6wu+rSoFW1GdiL+98BLtDce4fGLZ++QpQzNEJplIoT86wJ/a H0DaAUBSEn+59qml4SkZOl7WKIImrvXOvQVlExsFZ0V5tYhzdWxEHRux+uk8ifEzJ5hPndGd9yg Yey+RkAbQbmmD94KabnjNkyBTDswdbMxwKb6awanIq1p6RvQjECJEe3pxyYZF3QjtaLS+UVE5AE F8fM18DWJaoG52BWxdQ17CngTb9OBKmZVgZCVnezGTWRXUlrxxtsJUxyzWNSVlxr1FJij9s= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.559100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24170.003 X-MDID: 1540217955-OZa_4VKDP_3M Subject: Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 22 Oct 2018 14:19:18 -0000 On 10/22/18 5:02 PM, Thomas Monjalon wrote: > 22/10/2018 15:37, Andrew Rybchenko: >> On 10/22/18 4:15 PM, Thomas Monjalon wrote: >>> The MAC addresses of a port can be matched with devargs. >>> >>> As the conflict between rte_ether.h and netinet/ether.h is not resolved, >>> the MAC parsing is done with a rte_cmdline function. >>> As a result, cmdline library becomes a dependency of ethdev. >>> >>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net> >> I'd like to share my thought about a new dependency. >> Looking at cmdline I think that it is a bad and strange >> dependency for kvargs. IMHO, even duplication of the >> code to parse MAC address it less evil in this case. > cmdline is not a dependency for kvargs. > I have added it as a dependency for ethdev. > >> May be it is possible to provide internal wrapper >> which is implemented using ether_aton_r() and located >> in a separate C file which does not include rte_ether.h etc? > I raised the issue in technical board and it has been decided to fix the > conflict with libc in the next release (with Olivier's help). > So Bruce and me decided to use cmdline function in the meantime. OK, I see. Thanks for explanations.