From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0040.outbound.protection.outlook.com [104.47.38.40]) by dpdk.org (Postfix) with ESMTP id 0337A532C for ; Thu, 29 Jun 2017 16:20:49 +0200 (CEST) Received: from CY4PR03CA0078.namprd03.prod.outlook.com (10.171.242.147) by DM5PR03MB3163.namprd03.prod.outlook.com (10.174.190.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11; Thu, 29 Jun 2017 14:20:48 +0000 Received: from BN1AFFO11FD023.protection.gbl (2a01:111:f400:7c10::101) by CY4PR03CA0078.outlook.office365.com (2603:10b6:910:4d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1199.15 via Frontend Transport; Thu, 29 Jun 2017 14:20:48 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD023.mail.protection.outlook.com (10.58.52.83) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1199.9 via Frontend Transport; Thu, 29 Jun 2017 14:20:47 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v5TEKi8e006846; Thu, 29 Jun 2017 07:20:45 -0700 To: Ferruh Yigit CC: , References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com> <1497591668-3320-23-git-send-email-shreyansh.jain@nxp.com> <39ded621-6575-fdbe-8d7c-9f1f5dd6be6e@intel.com> From: Shreyansh Jain Message-ID: <589e8109-196c-daef-855a-6239bb7e0f7e@nxp.com> Date: Thu, 29 Jun 2017 19:59:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <39ded621-6575-fdbe-8d7c-9f1f5dd6be6e@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131432196473951283; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39410400002)(39400400002)(39450400003)(39860400002)(39850400002)(39380400002)(39840400002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(24454002)(51914003)(377454003)(199003)(189002)(9170700003)(105606002)(8656002)(8936002)(5660300001)(110136004)(53546010)(31686004)(38730400002)(6246003)(65826007)(47776003)(83506001)(50466002)(36756003)(86362001)(65956001)(305945005)(4326008)(85426001)(4001350100001)(104016004)(189998001)(54906002)(2950100002)(31696002)(6916009)(6666003)(2906002)(65806001)(229853002)(33646002)(106466001)(23676002)(498600001)(64126003)(8676002)(81166006)(53936002)(50986999)(230700001)(76176999)(54356999)(356003)(77096006)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB3163; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFBRkZPMTFGRDAyMzsxOkRnOVIwMWJ4UEtydzA0Wi9lY0N1SzJmbDEr?= =?utf-8?B?ckE2SExNaUQ5SGRvOEFiUnFlc0wvellNeEd0MExPOXE5aTFxZTVVZi9ZQll3?= =?utf-8?B?OXVoSmVvMk0zT1dQR3l5NEtHVDZPWUgwRENxeitnQXRDTjRiVVNPbEozZUJh?= =?utf-8?B?TGo4bkt0Q1ZjbGZxOFpoanpEd2IxY0RzKzRLRjlST0FoQ0I4djlTbDFmTzJS?= =?utf-8?B?VS9sUk5ETFlHbFRiSDZkTHIwRk9EaU9ENExudTRNV3RZQ2FyMmRkQXZESEUw?= =?utf-8?B?TmZybGovQ25OT2p4dGhyQmZpY2cyYjZ3VG9ON2FxUlBnV0hoL0lsNGdJM2xC?= =?utf-8?B?U2Q2NGg2ejdWZkliUVZzQStVWDBxS3NQZGV1OEdnSWdiZHNrQ05ORkVRTEMr?= =?utf-8?B?TXJlRmVVUHpiY3l3QUhjY0VENGFJMVhxaDlOVGV2MCtmSFNEZkJqaVFKeVNs?= =?utf-8?B?N2svcXd4Ukg1b2hUSFJRT1JjajN1S2t3djlicFlnNWxYdkxidC8xS09CVEpP?= =?utf-8?B?OTJmNUV3VTNLMjFyUnFiRWRFalF0MUNneVhPbGZ5RERucFdjNHdhWjV1Rytn?= =?utf-8?B?MzFqVDNnZ05Famc4Sk9VYWRwazEvV0I5dStyWHVJS1NrRGNsdC95YVBCZkI1?= =?utf-8?B?MWwyMTFWZ01KNjBEUEZuMFkxL3BxVnBoeWNmc2xjeGY4Q0RvMkFtaGNueS9m?= =?utf-8?B?OWFpNUpPeno3dUZUNGQzcjFOYW15a2cyNjhYZ3hMOXlDU2RkN1E4azc1c1JG?= =?utf-8?B?T3laZUtFSFhBcGE4K3c1UlZGMjZjTXJETjUvZlNWNXZRcDdaVzFBM2dYK2xF?= =?utf-8?B?WWJDcDFVT1pQazBXYzQ2MG1QZDdjdjlRNmtrc2RuY1o0Vi9PeGhZcmlkUXNE?= =?utf-8?B?ZEE1N0FwbkJGSXdhNGdhVjBnVGMyYUphai9LS2RRY2t6R1JFZG11ekJRMm9N?= =?utf-8?B?WGQxTnlrYzU2UkZYVDF1QWVHdXRvNTVuZlRUU2hsMit6U2ZYMjFORmJaY2ts?= =?utf-8?B?M3lTUXdpOGNzRXdsNWdKTm9FMldjZFhpei9BSGprYjNpbXVFVHVoRkp6Vjh4?= =?utf-8?B?K2xwSXRzWS85TjhMVWZ0cjJ4YTY3WG1ZQnNSUG1ib1VxSlpCYmRuRStpdWRT?= =?utf-8?B?ZDdqZnNYUnlnYk1EZHN3cWUvNEZMZVhpRzdCVUJMdjl4R3NzdXdsY3orenNB?= =?utf-8?B?clV2c0NaSmVvTDJxUzZ2U25zUW1sYkQ5bUE3SkZKdEsyOGpzUG5oUXc0SU0x?= =?utf-8?B?eFlVcUlYUE1HeGhPcnVVdExZdDBxU2dXcktoOWNpa2N4WllHNjhxQ1NXRWpD?= =?utf-8?B?ZVAyVzRUYVFhZUE9PQ==?= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41b8e4e4-c8b8-4a9f-b2d2-08d4befa0955 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR03MB3163; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB3163; 3:+1poPRFFWLxO5GMJ22brfBoVPqzHGDjRfgmXon1bGUMjcM/8II0bIW6qSrVjJHtZnTWtz/2WV2gy28/W5PDHvvKwkHctY9Eij5mSI9s7VdwVktTt+BnJErU064fMlD3afAU1AASI041jcezWAvY1jSyZ+bJDga0ZpvZcOhp64zW+SBYCFAyBsCDPQGJY0O7f7cgI8nWH27MQJFaCnL07WsQ3ec3hsk+/y1/rRv+ZEGQuUwj5U0ml1U7EE6bhWN19YbBHjcpYs0//gqLYS31X7tEmJ79Bb1E0a+6IbeXSFlcVAzNy4kvUbt7dez/OYRhCLpGaJsWGqX3oV2gLXd+XkYiOwwJm9KWx52C/3QoQGrTgr2OsTGqc+/QTaeLZu5ztLQXtHnSeadN4X5O4emjgPuYQjWYdDhAU5pLkCenuDx2BcwtUbonmlwe12qRBvKhee0yUmmbZ0rUbIWDzNb4EUfw4J3Y9yEsxwBFWCNW2RFieuVSC6puRirf5+C/fwNJwL0ls2ZHIVJULL/T+KXtSk/ISeG7rNYKr8UcUndw0BjQQ+mIXZV8fl5jc4SOrNwtv2x+ZVmMjtI3NKUesDGXZlM2hvKHvprrJ7Y1vD69d6atRJw+SCzGl0vnc74DmwIpakU0Fy5od12igXeFIcXMivYzAKPAIRdsg4r+xf+SlVAJBg38dekrLtaNMdJRtOsEddSkLaa5wbpxIHp65RQ1ZoqUqjeWrQuCemhs80F6d/fP/HNWtRia4onTyRg07KB0C1XIUKwY20g/hK6/guGzy0r1OcJ7pDudG8RT4NYI8nUs63+OOXydk7WMIYQUruRIj7JI85w+EPcgE3ZV6N0cbeA== X-MS-TrafficTypeDiagnostic: DM5PR03MB3163: X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB3163; 25:N2LnbuTb5AeCYm13q3PoWGs9saxK49XlTxjRc0SQysddZDtRTCO2XD3d2I1HBMs+Vb2D/77PD4zjFVJ/OWe4SZ+KcWU1PXkd+vqlFm6VGbxge8S9b6gWeI+Ix8lqIu1fHbF3jSriRKlD3Ng/GQCXfVrTAeA17gqIGMWjiVpcuXsQUNuabudu9ts0fm3V5fnTmFxEVfz5+2K79gA9SHRyIzY+EMkS14QumIguh8H+4qzPw8aRsXhYQaTFWP+m3U5o7u95Xz4zsTwtm0yQxV13zSqN4ecV2++wSucnbc3vg6UAOgXArs/aZqYq9exIi3BBMKUUwpNj5ujPaqnBZv96QpW5l37yNOCU9et45yC++574PMTCT2GebPMKGMOU+JhlwHTpg1DEQe5+9VU6LEVgmuvae9aXBQZVf8x2G7rWdnAy2liMt4kWFM0T3B3D5su4tDc/sDYmDaA265yEd+F/yvJMDRnnfNJpJJltbIPbB5vfqjx4zVcl5U8Z2bCUciDf79zg5ynwTDoX3MOFrkyp74pqwlw/4BT9qRNMqenyY1qfA6li3mfnlk7wZgTAYsKQ3iBtjhhWu7AK2Ucf04jqaXcedy1goQlO/vUmGG+XQIjrM83G40jWttMZjaHFpdTE+YGL7k4DGUPIhWM9vdIsBQb3eY2xVNFCnfLLlQee8/JJnfxCWWXUlXmC5Q4HymU42iYDJVfrnQqx5sZyPrQmFc7rBtcDJHznYyKKjXwYb+B0C7N8/G/+Jv8FPLeIw94kYwU/7zrxq9fS8mTWCiLs4Ub2uelxtfZEHvlgdwSoRrxS0gfmlO84y8pSsDjScW8B+xfc7XvO+1eddXdFsjDEGjgnM+isgnIzQKIdslauMV4fYQ9QhYgDzzRdS3LkIxALisARBypFNooSWHXspcoLKXzs1PD69X2qoric0NF3/8k= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB3163; 31:687TQc7GtIOL46KksGIz1qxmqrsWn2PykedmashRz0l+B1vmG/MtXgGTVP0YSZaVvfjpgc0Ki36Cw2R1eAdYoqqpHIZUfKpSoz9LpX8N+/lNRMiK1GsNBQbqEYueLORJQyNNUFbOB1u4cmIEldMmYyV/StPQk3yvFcXJzNd4ODMPoEZqK+ZR53kXY25I3xXRI0pPdQVNwi3AboOshlA97t0XhJIRC4rvGnMMFNp4JjkZw4zV616BIaKw01xQzPqg81VD74xUM6m+fE6vFpOxXMv8XeJfzmgqXdd/ZaQ90lYcCigmKpprCGToh0jfdFQuot+UhJWeVgEHINGLKnOC1sSkr15YPpK2CukwAVI7E1y0artdwCHBqOeT7WY748CiW33RUDcuRQim2CUpTSs95XA79pmFVLRrSbLADxoHYZyRzs9TC02VyyLX8p3EaGJjFs8Zfh46HEqR9PB6qlUP02k1pmHURck9Ubcu4FvtchEybqLrS3t127JuquMXUsusSU6XQdrJTsmwB09jCBJP2btlRD0POdTea94S/mjub9se+5Ft3ptzU+BzmGqPEJDJjDZvH/+aT2UTZfZk/g+grDfbqvf1pKQsO9UtF3wf7qr2f27KaFs8nlW9vfccI3Okh5gIWirFeKCIN5qk+QTeMDGNeMOsAWd1Q2Y3mPPvsk8c1msmIVOdlloNSCS+70Wr88GBcIc8MmlTcfUNg1x6qg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(133145235818549)(236129657087228)(185117386973197)(275809806118684)(247924648384137); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13018025)(8121501046)(5005006)(13016025)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6096035)(20161123559100)(20161123563025)(20161123565025)(20161123561025)(20161123556025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR03MB3163; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR03MB3163; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjAzTUIzMTYzOzQ6UmpFYTRidnUzTG9iWHFtaUk0OXhOWU9OUkhw?= =?utf-8?B?S0dWcDM2bjEzdUFlNTI3d0MzdGNHQ21CamtMNzJpS0crNU1OczlpRzhBaFZH?= =?utf-8?B?NFdMQUR1MngzcmphbnJpamRaOHpoakxmQzFVZUlIU2x0eDBmb0xYN0VTSG9p?= =?utf-8?B?ckVLL21QMlhEOS9oa3dNcGhmMExZNUI1MXhtZ3BiNjRTb1NZNFJsM2lzQStX?= =?utf-8?B?dGRkbGFLOUdKM2N6aWROKzhTWitJNUUycERzNDcxSC93ZExza0o4a3RyOXQz?= =?utf-8?B?QXRERy9HdWdJU291YXJGa3ZjYkYvRDU2ajBwOWw2QWZEeFFCdHpVMThaNmEr?= =?utf-8?B?S1RSRjQ0eDB6cVgyaU1aMDNwMDhkS2tyb29LWVRqTkdlUmxYcm5TS3FFL240?= =?utf-8?B?NUlQRFp2ZTBTemhwZ0R1NlovWlp0cithUXlLWVNKOTNQY0pEc2FHOHMwTk9q?= =?utf-8?B?Qi9oaUhsVGsyMTROVExVbGJjVGdDa05ObkxCQmJZY2hPMlpFWUNYaHk5L1ND?= =?utf-8?B?TlBBSzdwSUZnbjJiUE1VS29mbklXMG9mbTd4Rm14RTVSUUZiYm9wYml1VEYy?= =?utf-8?B?MUJKa2RrbmY0ZnZpSmFCd1VmM2pjVnl6TEtEbHZFZXkvV1djaFJsYmtqd1pM?= =?utf-8?B?eDdEL01UWGVqL1JTNnFxTDBwNnVudFpkdXQ3N2ZrQ3FJR29HZDFtOFBhSGpL?= =?utf-8?B?bkNEV2p4ZVhUcGt6MnltUlNIMDU2ZkRWOXQyZk9tTFdFU2J3ZDc0aXpucWV4?= =?utf-8?B?Uk9VeEI4YTZsUEdNcWxoK2YyeHdzUStiQmc3ZnlVb0F5bDU0SEVKZjlhbzk4?= =?utf-8?B?S1pFclc2VW5HZFVoZ3Q2ZmpQYmw5YkJrT0o4RWxaR3ZOMkFRYTBteERsMFpx?= =?utf-8?B?elVoNXJHS00zSEFWOWcrdFNINlNVRnJkeDM3Qmo5bDlGWisrdTlPRTJpU2c2?= =?utf-8?B?YVptaXR2TkdEczJobFlJeFBoNHBHR2wvNXpHcXp5LzRVVXpnZGJDbFhmZlFn?= =?utf-8?B?KzRQd210bmpXNHp0WGtaR3duYzNkek1wRk5Wa0N2eFR6TW5ITUtpaUR4bXow?= =?utf-8?B?QUR5aHc0VS96V2drOHoxQUU4ZFluamFURmNjMzhxRHdRaWpVZ1VHOGw2UUdn?= =?utf-8?B?MnJPMGxtNVpQZVlkWmZBWnVCY0Mrb01sL3puOU9zbW1vVFJ5VlVKc21GNHpM?= =?utf-8?B?N3ppWUg1Q2pPaUswZlNnaEZReFc5aGdoM05mZmpnUW53ck5Fd1RMUGV5Ymo5?= =?utf-8?B?dVRTZkhxSGhtVkJkT0RWS0lsblJDTlpxeUw3UUJIK2VKTXBCLzRFdklGSU1n?= =?utf-8?B?TUQyMkEwQkdNN0NvcTl0UUdONjYvT090bThHU3VvcngvVE9wZVg0TmNtQWVq?= =?utf-8?B?bnVxQzZQRnBuajFlZUh6a3JQclFFT05zTmwydlVoQTg5R0ptUnNRVVllUWVo?= =?utf-8?B?aWRCZDF4TkRiRUIvdmFQelA2bTNyRmZDbGpqTjFxd25SVWxPdkdZS28rSGxN?= =?utf-8?B?NUpzVXBVaHBzNHpiYTBBUXVPRnVUNmpGUVhZalpBcW5pc1JzclREazQrS3hL?= =?utf-8?B?ZEFPTmZGd1FXLzIyYjgvc3ZyTS9KdndabGZvWUxvOWVWcEoxM1ZqN0duc3F2?= =?utf-8?B?MHNBY2Y5OG0yVThhR0hQMUZzRXo2OTIzaFI1VjI2ZzdTcFF1d1ZjK2lvM2p1?= =?utf-8?B?bHFrQWxGVzA5OEpreXlqRUR1UWxPOUdHY0hqR05wVmx3ZFRKVmwrK0NveVho?= =?utf-8?B?L1grbEFZS1JWaXRJTDRGK3ZDSm54NlZNcDBNZ0V0WW9BeXNzcytIMWJGVzlT?= =?utf-8?B?bnA3QzBNeHF0RENmcTVJdjVxYTVVK0I4OWJLUlZ3VHhwYlJvd2lubTJ5dXcz?= =?utf-8?Q?89u2aJQHKRMp9EgFtUMG9p++Yp+vMof?= X-Forefront-PRVS: 0353563E2B X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjAzTUIzMTYzOzIzOkVNLzFrWDg3R0xxSnMxQlhEMnJ4bTJWSmQv?= =?utf-8?B?T2l0L2h5ZTErQk1CR0p2ckNzZ3ZNL1VIL2VYN2NkZGltTzR0b0pKWW5NcWM3?= =?utf-8?B?blVlMzd3Q000SHdOQjlJMThsZmwwSHZGbklqK3k4V1ZzWTJZaXBPZ0FZWTdL?= =?utf-8?B?VWVvRnY2aER6VHM1TWZLWVQ4dysxcFNiMEJOa1FFTW9RZ210WThUUjIxTjdy?= =?utf-8?B?RXpCbURXdEdFMWFZVXViSk5ETHFRWTI1R05Ka2JCa1Z4UHRpT2VGbzJGanFD?= =?utf-8?B?ZGoweXQzazV3VjRBZFp6bmJjeUFVdWZlMFhsZE9uK3lXQkJKS2JyVGd3Y2Y3?= =?utf-8?B?MW5namlMd1B2bE9rNGtnbGZuYkFWWmdzTXZjQU9TZDRyMUh0WnNsVkVSay9q?= =?utf-8?B?N2Z3Rzd5UHV6MUxwUVNGcUlFdk1nekdZZDdZTWcwM210OFZSS3BoS0pLMWVv?= =?utf-8?B?VVBWVjBuUisrK09pNjZUdXVEU3NQTVBVSXVlL0pGaE5XT3FnS3RYQlJkclpZ?= =?utf-8?B?c0dwdzZMbnlXd0pkelJ3Z0FoYVNxdjV4NE9VeFJQNUpIcitGVlcwa2h0dWov?= =?utf-8?B?OTRadEZORmVzNnloOWczTElZWS9FeVRCb2hJV3JFQ0Q2eXhpQmFmN1JVdnI3?= =?utf-8?B?RkN5NEloWHFRVTJ4SVlsc1lNY095cERRWkRDN1lBRHpZMEVzUHp3ZW5sazhs?= =?utf-8?B?QVpVM1MzZE9LNW9OTDF2aUlZLzRITDFxbjJEN1ZyRnYxV2pZekpSMDZ2dm1v?= =?utf-8?B?Q2RKaGFlNUZielZ4bWE4UlUzaU5oTVNvL2wzRzYyOVVYWS9zeXU5d01DZlQw?= =?utf-8?B?bUdJNXNRanJoMmtCdVZ2QzN0YU1UV0Q5dnZtOTI5bjJweHhmUFZKRTd1NmVh?= =?utf-8?B?Q0JVM3FOQi93SHY2bFRYWThiZGJXUWFYOGx1SU8ySjFMbHdQcXVUdU1VOTJK?= =?utf-8?B?QldHRHA4U1lCaVRaVlFWV2pPcmNlWWxvaVhEcmFrdCtSb3NjS0ZzbS9qUGJh?= =?utf-8?B?aitseElWRnlBVWtVaWlZbWJWc1RCVGFTdS9hd2dHZTdhL1hsd0ZiMkpmTklv?= =?utf-8?B?V0dxaEd4YVlCdzh0TEpRTUV1ZjRlKzJNbnljT3JoYnNCSys3K2o1ejhLc25T?= =?utf-8?B?dU9JVmV4THRWSmZSd2ZrZDJtVUpLNHNvTE5UWTNSS1dOREJYMUJ6SGdVeGFQ?= =?utf-8?B?WFc0eHFuTGxRUXBsTU8vWDRFTlk0RkMxUzcycys4Qks1NkxncnBoUzE3U01p?= =?utf-8?B?Rjl0R25LT3BrOGNVcGlVK29qcVF3am52a25WK01taG5wUGhGVzhDTStYTC8y?= =?utf-8?B?Q0FLc3E0amVwMmtnQytPYXVqRDJmdyttSnNSeVcrT0QwbjgvdDZ3VlVGM0hB?= =?utf-8?B?aGxSd1JJa3gzWG1iWkExdGxwZ3VPRUFJREx3MFlRN203RXdUQTIxSzU1dWFF?= =?utf-8?B?VWRwQ2U5Rml0QlFORWJVTnVmVmhJdk9uRDlYdXZnL0M0ZEtJQnI5Q3lPRDFa?= =?utf-8?B?aHpvWDRxcXhvQjNMbEVqWHVKdURudFZid3I0Zlo3UEV6QnBKeDhsdnJ6eGE2?= =?utf-8?B?MmhOdGtFOXBvemdsam1ZdTdlN1BCNEYyaW5DR1FreGRST095bFd2clpDM1B4?= =?utf-8?B?by9qR21oQzFLUWQwTUNOOXVYRXJQbmFJbWpmQTNqeWsya1gvdDh0em1tVFVT?= =?utf-8?B?MUdCNTVTYnJEOGdQSTY0ekgxSlI3RmF3M0lZWTk5MjJTUEh6dC84WG16SE5T?= =?utf-8?B?dWlXRmp1eVZXVUpFcUZuRndGbTNUaThqWW1lanhTSTIxUFpCcHUxVnpqTkFJ?= =?utf-8?B?WXBiQWIwVGZyUGxzVm5hQXRONFlYc01ycjRTdXg5OTdYQnVESlFYMjY5Wmsx?= =?utf-8?B?T2VDMWxQOC9XTG9EWktpOGlpQkhFSjNnVzlZbDc3ZjJJaUl4SEJoOTRxQkVr?= =?utf-8?B?V3NGYnoveWZQR0NlN0w1dTFFYlVFdlFjZzU2MVkyYzBNTXNXOGVPRk9yZFFR?= =?utf-8?B?Y2RhdXM5UG5LbGRTTlk1aTJxTmhJS25vYWNQcG14Tk43RTM3Nk1DLzk3Y3JE?= =?utf-8?B?eHdOVmkvZC90djFTb24wTUdrbmJlYmFoNVFtUzRxMkJRYUp6WUdDRU9xVG5S?= =?utf-8?Q?vJAwn3yVIAhDnEAiy915MkQ=3D?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjAzTUIzMTYzOzY6dXpqM0xSVWVYK1N1QTE4Z2lObElWdFNLL1Zr?= =?utf-8?B?TTBuSkYwU2FjZGNQV25JYVh0emVSZEVhL0JNeG53eS9aYnBLWHZ1ckFOQmQ4?= =?utf-8?B?bU1oQmRZWlJuV1V1UDl6TW85WGdESlNGUU1SMDU2SUJ2elFlQnN2UVdsa0c4?= =?utf-8?B?VDlGTm1zdDZsRkh1OUY1NjhJWUkvS1h1ZHRlWnJuTk5kYXpTUjNPblJNeVgw?= =?utf-8?B?cW5NNG1QaUpoUHBDWGVlaTdiRWIwS3U2WnE1U3JjTVMzajZnVzJZblpQUXUx?= =?utf-8?B?VS9wcXBQejYyRzNUME5WdXUxZm5LR1hlV21RZDFOQ0UwZDJQMWlxMDVhMmMv?= =?utf-8?B?YTZ5Yk9BWEhxK1UwcFdnV2NMeFE3MDRvTFRhVWRGdDF6WktBM3d1WDloTU5m?= =?utf-8?B?SVJYejNaSy9DTWQyQW9JTFN3aWR0WHM5Z3dFTlBPQTdpbUlxL1hHWWtlZjJm?= =?utf-8?B?bXRUQ0MyZEptN3ZDZFVnbG42azFvcU50aklybExWbEFGQ2NQTTR3cFhYNEZV?= =?utf-8?B?ejJKdmpHcHQ5UFBMdjNTMFY5UHRiNVVMd2phMHd1eHBTVTdZZGsxYldUaHpi?= =?utf-8?B?MWZmZ3gxdnYrRmJpQjV0SVREVk5CQ2RQN0l0OWU4eFNTTC90czFPbkEvOGtC?= =?utf-8?B?VWxOc2d1bmMyM0Yyd2d4Q0c0Z1RBeXJJa1BDMUtJc3JCMEZNODdCY3pDNXZs?= =?utf-8?B?UGZqK0RObDJvNnI4TUxwUWdMMmx6YkxKRXJ2VEo5UEhMa2hBbFkwMjBobmtU?= =?utf-8?B?aCtSQnpZKzhiUThhYXRkUHYzTFpWZVdPMkFoS2pKbldmNGl3WTFob3FnNk5W?= =?utf-8?B?Nk41d0pFRGgyejhVek5QTUxZLzFjUVhhUHBhS3VUeXpJUTFBdG1wYXQvNzFB?= =?utf-8?B?emxBNnZBenBPOFk0dDU5bExNNmh0R2VVM05tbUN5cUV4K05FbTFEa1NzOHVE?= =?utf-8?B?OEdha0t6aE5UajFVN243U2tWOGZJa2pJWjFCeGNHdkZMNUpPOXlIRHN0N2tJ?= =?utf-8?B?TmhaRGxNYXhZWk0xMGxOMFdnakUraG54OFNwT2JGRHRaS3o1Mkk5eUdHQ2lK?= =?utf-8?B?OWE4QTNOSWhVUW5MV0pEYXllbUtSQWRrU0xHZEQvWVFMU3JRRDlRbm5oazUv?= =?utf-8?B?MzZQZU9weGVDV1FSVG0rcmxTTnd4R1JjZFQwdVhRVWtNeUcya1BlUlpzK0lp?= =?utf-8?B?cTdCRzVUalg0aWM3VElqbG8vNElIZDJZWEZHNThDSG9ibHN5b21Ub3pqQmZw?= =?utf-8?B?bkFUNGZ2ZHFkdGdqT1htRXpnd2tEcFc2SGFJenExWnZLLzlUZ2tlbzNYeUFh?= =?utf-8?B?U3dsZ2VPOHJGUT09?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB3163; 5:QNXBqZ4aXFnVl4PVU0JTuCDk5LBJCdD9ew5ANalzjmqJ42WEBvluOdOnt/FlvRkgSQXfGG30eOdrGdHlk7lUAH4Y8aQuLJsoeC0ig6KE3JNaISAAIxCy6mq1z84cBfp/r/oOybRKrkXaR6gLcfLGVLXHVLVTy9mhIGX0zIpVgMSn7f1iTcBeWkP87BLi9RlqrvPUxtjIGcmJRNrMYl2skBPuxg3I+sKJtVR9gVOFsJgwgy6Rvy638Te7aPRjbNWJhx1sKCzUttB+huorzA22bNy+44bGJ49jHGvLb9ISZVogSfu80CaUgcnwUVoz888M6SXw43r1/29avpi9CIVem3vItF1jp6HPzLzV+1x+Us7dLMhbxMAdYkJSb7hhW7UWf5Wi9C4Zwg+NoIXbKwBDPnRv7InG/wp13HyFunXWfxl6OKJX5gBOahq8AY43K9ehqkuQYdvXdXZEsjJ1I44Y0Ln/JU4t4Lp1uuVkiboddapVwiCjAsQxNnzBoL7AsV7SFGPIMbXEaVWGic7wgOlc/w==; 24:KyXX1FcRzSNSeeyccaJkKhUZLyvy4NaUj6xRtZlSFwPUMjiYFaknJ/KclAqBTFerUuUlsV8W66+L9MWJYorrvqRmkBgOX/t0+6atjMeJdIU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB3163; 7:GA1cv97N7ZkheROnj5obMYtnIThUy/Os0RiTZpLZiPsNVdMU4OJ/oTgaYNwdUj3qTSqGUbS4JX/Fs+86THGBQieo6laJ/hR+n2bpLR1Xt6ica5OB0/j1kSA0emeIWMNNLZ0mNOZ7A0kg0fOjUtKNKDg77SLK1/Treiz7bxoRdyF4U1ozbfEGrhko16epKjcGzczVmJwfLu1q6gRMKpGPRqUfCQ1SVIZqAwoPnh6GpCFZOfVmIO1Ntt4kYxO5aCEcUoflW+XGpgTDekTXweW8Snmp8hfzR3R+27gP9/qXmktxCupUn9wBKC9PcpR9dw0VFW1FOHKu0EI9Hwa5EwK5adG+a5hBTMauPlpXmGf8w4aJLUddJakvH98A2gcKxHgPnXjN/UOQQUq0nNO7iEKus8Mnh04Ux6kWEBADydy7EvWJgKfmq7Fj56r23OeRGufPH8sWzZiCicJ5gWDCwOxwkk43/v7kG+55GcEh5S3vFc48oqLDKcgaTjuhqJlg47/DKZsoScCCjaKuMBLaqr8+F/eJzecgJqK8Q6pUhnuh7KahxGR8j/UeRWkp7VObMhkfvJdWmMKze/y9vtEwIGswxHS7AP9+2gAe0uWCVOq10qFvdLB/PvVDxhLtIGQliRL+OpqISujB/Bfd6PrdlcUwgf0dgAeSP94jqDu7yU1a4gwG1qob8l/sD9lF82LX425XZaRDzXtL6iX+Lc+qoQYNRjDMJL+1+hKwPfKw94TJUnhCAALehIApy3iIg7LB7mM7BJhXE63STGZdFPLmWS8Q+auacUwFFtWVFkZl3N3hlpc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2017 14:20:47.2079 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3163 Subject: Re: [dpdk-dev] [PATCH 22/38] net/dpaa: add NXP DPAA PMD driver skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 14:20:51 -0000 Hello Ferruh, I was almost wondering if this series has been forgotten. Thanks for the comprehensive review. My comments inline (and in some other mails): On Wednesday 28 June 2017 09:11 PM, Ferruh Yigit wrote: > On 6/16/2017 6:40 AM, Shreyansh Jain wrote: >> A skeleton which would be called after bus device scan. It currently >> fails to identify the device> >> Signed-off-by: Hemant Agrawal >> Signed-off-by: Shreyansh Jain > > <...> > >> + >> +/* Initialise a network interface */ >> +static int dpaa_eth_dev_init(struct rte_eth_dev *eth_dev __rte_unused) > > __rte_unused can be removed I will correct this. > > <...> > >> + >> +static int >> +rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused, >> + struct rte_dpaa_device *dpaa_dev) >> +{ >> + int diag; >> + int ret; >> + struct rte_eth_dev *eth_dev; >> + char ethdev_name[RTE_ETH_NAME_MAX_LEN]; >> + >> + PMD_INIT_FUNC_TRACE(); >> + >> + if (!is_global_init) { >> + /* One time load of Qman/Bman drivers */ >> + ret = qman_global_init(); >> + if (ret) { >> + PMD_DRV_LOG(ERR, "QMAN initialization failed: %d", >> + ret); >> + return ret; >> + } >> + ret = bman_global_init(); >> + if (ret) { >> + PMD_DRV_LOG(ERR, "BMAN initialization failed: %d", >> + ret); >> + return ret; >> + } >> + >> + is_global_init = 1; >> + } >> + >> + sprintf(ethdev_name, "%s", dpaa_dev->name); > > snprintf can be preferred Ok. Will fix this. > >> + >> + ret = rte_dpaa_portal_init((void *)1); >> + if (ret) { >> + PMD_DRV_LOG(ERR, "Unable to initialize portal"); >> + return ret; >> + } >> + >> + eth_dev = rte_eth_dev_allocate(ethdev_name); > > If this is done without RTE_PROC_PRIMARY check, this will cause > secondary to memset all device data. Agree. I will correct this. > > I am adding this because of below check, it multi process support is > intended, this also be protected. > >> + if (eth_dev == NULL) >> + return -ENOMEM; >> + >> + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { >> + eth_dev->data->dev_private = rte_zmalloc( >> + "ethdev private structure", >> + sizeof(struct dpaa_if), >> + RTE_CACHE_LINE_SIZE); >> + if (!eth_dev->data->dev_private) { >> + PMD_INIT_LOG(CRIT, "Cannot allocate memzone for" >> + " private port data\n"); >> + rte_eth_dev_release_port(eth_dev); >> + return -ENOMEM; >> + } >> + } >> + >> + eth_dev->device = &dpaa_dev->device; >> + dpaa_dev->eth_dev = eth_dev; > > I thought "struct rte_dpaa_device" is bus device, like "struct > rte_pci_device", if so why it has link to the eth_dev? Yes, rte_dpaa_device ~ rte_pci_device. This is used to extract the eth_dev back while de-initializing the device. driver->remove = rte_dpaa_remove(rte_dpaa_device) // fetch rte_eth_dev from rte_dpaa_device `-> .eth_dev_stop(eth_dev) So, essentially reusing the internal eth_ops for cleaning up the device. > >> + eth_dev->data->rx_mbuf_alloc_failed = 0; > > not required, data already memset via rte_eth_dev_allocate() Ok. I will remove this. > >> + >> + /* Invoke PMD device initialization function */ >> + diag = dpaa_eth_dev_init(eth_dev); >> + if (diag) { >> + PMD_DRV_LOG(ERR, "Eth dev initialization failed: %d", ret); >> + return diag; >> + } >> + >> + PMD_DRV_LOG(DEBUG, "Eth dev initialized: %d\n", diag); >> + >> + return 0; >> +} >> + >> +static int >> +rte_dpaa_remove(struct rte_dpaa_device *dpaa_dev) >> +{ >> + struct rte_eth_dev *eth_dev; >> + >> + PMD_INIT_FUNC_TRACE(); >> + >> + eth_dev = dpaa_dev->eth_dev; > > can be: > eth_dev = rte_eth_dev_allocated(dpaa_dev->device.name); Hmm, ok, now I understand why you are inquiring about eth_dev being assigned in rte_dpaa_device. I will have a relook at this and fix if required. > >> + >> + if (rte_eal_process_type() == RTE_PROC_PRIMARY) >> + rte_free(eth_dev->data->dev_private); >> + > > no pmd uninit() ? I will fix this. There is an internal commit that we had very recently (a miss in previous series). > >> + rte_eth_dev_release_port(eth_dev); >> + >> + return 0; >> +} > > <...> > >