From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A646A04C2; Mon, 25 Nov 2019 17:09:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C96142952; Mon, 25 Nov 2019 17:09:05 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 19D0928EE for ; Mon, 25 Nov 2019 17:09:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 08:09:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,242,1571727600"; d="scan'208";a="198513884" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by orsmga007.jf.intel.com with ESMTP; 25 Nov 2019 08:09:01 -0800 To: Pavan Nikhilesh Bhagavatula , Jerin Jacob Cc: Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , dpdk-dev References: <20191123085832.1730-1-pbhagavatula@marvell.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <58a875be-0ef1-904c-32bc-6e7adf0166c7@intel.com> Date: Mon, 25 Nov 2019 16:09:00 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix ptype parsing disabled by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/25/2019 3:55 PM, Pavan Nikhilesh Bhagavatula wrote: > Hi Ferruh, > >> -----Original Message----- >> From: dev On Behalf Of Ferruh Yigit >> Sent: Monday, November 25, 2019 7:32 PM >> To: Jerin Jacob ; Pavan Nikhilesh Bhagavatula >> >> Cc: Jerin Jacob Kollanukkaran ; Nithin Kumar >> Dabilpuram ; Kiran Kumar Kokkilagadda >> ; dpdk-dev >> Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix ptype parsing >> disabled by default >> >> On 11/25/2019 1:00 PM, Jerin Jacob wrote: >>> On Sat, Nov 23, 2019 at 5:58 PM wrote: >>>> >>>> From: Pavan Nikhilesh >>>> >>>> Enable Ptype parsing by default, only disable when >> `rte_eth_dev_set_ptypes` >>>> is called with ptype_mask as 0. >>>> This would enable applications that are dependent on packet type >> parsing >>>> like l3fwd. >> >> This also helps to store the configuration set by >> 'rte_eth_dev_set_ptypes()', >> right? Previously it seems this was lost in next 'otx2_nix_configure()' >> call, >> not sure if it worth mentioning in commit log. >> > > I agree it is worth mentioning in the commit log. But since it has already been > pulled to next-net-mrvl can you please add it when you pull it to next-net?. > Something along the lines of > "This patch preserves configuration set by `rte_eth_dev_set_ptypes` across > multiple calls of `rte_eth_dev_configure`" Updated in next-net, thanks. > > Many Thanks, > Pavan. > > >>>> >>>> Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet >> types") >>>> >>>> Signed-off-by: Pavan Nikhilesh >>> >>> Acked-by: Jerin Jacob >>> >>> Applied to dpdk-next-net-mrvl/master. Thanks >>> >>> >>>> --- >>>> drivers/net/octeontx2/otx2_ethdev.c | 4 ++++ >>>> drivers/net/octeontx2/otx2_ethdev.h | 1 + >>>> drivers/net/octeontx2/otx2_lookup.c | 7 +++++-- >>>> 3 files changed, 10 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/octeontx2/otx2_ethdev.c >> b/drivers/net/octeontx2/otx2_ethdev.c >>>> index ddab3aa06..eaf7ba917 100644 >>>> --- a/drivers/net/octeontx2/otx2_ethdev.c >>>> +++ b/drivers/net/octeontx2/otx2_ethdev.c >>>> @@ -622,6 +622,9 @@ nix_rx_offload_flags(struct rte_eth_dev >> *eth_dev) >>>> if ((dev->rx_offloads & DEV_RX_OFFLOAD_TIMESTAMP)) >>>> flags |= NIX_RX_OFFLOAD_TSTAMP_F; >>>> >>>> + if (!dev->ptype_disable) >>>> + flags |= NIX_RX_OFFLOAD_PTYPE_F; >>>> + >>>> return flags; >>>> } >>>> >>>> @@ -2168,6 +2171,7 @@ otx2_eth_dev_init(struct rte_eth_dev >> *eth_dev) >>>> >>>> dev->configured = 0; >>>> dev->drv_inited = true; >>>> + dev->ptype_disable = 0; >>>> dev->base = dev->bar2 + (RVU_BLOCK_ADDR_NIX0 << 20); >>>> dev->lmt_addr = dev->bar2 + (RVU_BLOCK_ADDR_LMT << 20); >>>> >>>> diff --git a/drivers/net/octeontx2/otx2_ethdev.h >> b/drivers/net/octeontx2/otx2_ethdev.h >>>> index eb1626309..987e7607c 100644 >>>> --- a/drivers/net/octeontx2/otx2_ethdev.h >>>> +++ b/drivers/net/octeontx2/otx2_ethdev.h >>>> @@ -276,6 +276,7 @@ struct otx2_eth_dev { >>>> uint8_t configured_cints; >>>> uint8_t configured_nb_rx_qs; >>>> uint8_t configured_nb_tx_qs; >>>> + uint8_t ptype_disable; >>>> uint16_t nix_msixoff; >>>> uintptr_t base; >>>> uintptr_t lmt_addr; >>>> diff --git a/drivers/net/octeontx2/otx2_lookup.c >> b/drivers/net/octeontx2/otx2_lookup.c >>>> index 17c44e20e..bcf2ff4e8 100644 >>>> --- a/drivers/net/octeontx2/otx2_lookup.c >>>> +++ b/drivers/net/octeontx2/otx2_lookup.c >>>> @@ -67,10 +67,13 @@ otx2_nix_ptypes_set(struct rte_eth_dev >> *eth_dev, uint32_t ptype_mask) >>>> { >>>> struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); >>>> >>>> - if (ptype_mask) >>>> + if (ptype_mask) { >>>> dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F; >>>> - else >>>> + dev->ptype_disable = 0; >>>> + } else { >>>> dev->rx_offload_flags &= ~NIX_RX_OFFLOAD_PTYPE_F; >>>> + dev->ptype_disable = 1; >>>> + } >>>> >>>> otx2_eth_set_rx_function(eth_dev); >>>> >>>> -- >>>> 2.17.1 >>>> >