From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 140FBA0A02; Thu, 14 Jan 2021 09:43:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91AF6140FFB; Thu, 14 Jan 2021 09:43:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id E4ABA140FEC for ; Thu, 14 Jan 2021 09:43:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610613812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YshmS9u3PvayuChAokaF6fOwvj1tSS19EdPAaz7uyLQ=; b=T5aXTBx6ehyucuSUdAazrvNh1+BulRPV9gkB1muls4XqEzCyxSdOdGiWKPkgMQveNR239U 8LCDP2aAs045WkVUQ0IPkOyUBu4S9A1bnn0EWrOdPbmNtV/khz5JhGP9Whmo6x370aafQL 7X5pUGOAGAOjJ49U82++qhJ7Wa6ZUbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-bQIWAGWwPvCLEk2YSy5nng-1; Thu, 14 Jan 2021 03:43:30 -0500 X-MC-Unique: bQIWAGWwPvCLEk2YSy5nng-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 434C4802B49; Thu, 14 Jan 2021 08:43:29 +0000 (UTC) Received: from [10.36.110.24] (unknown [10.36.110.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2248119C71; Thu, 14 Jan 2021 08:43:25 +0000 (UTC) To: "Xia, Chenbo" , "dev@dpdk.org" , "olivier.matz@6wind.com" , "amorenoz@redhat.com" , "david.marchand@redhat.com" References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-21-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <58b99056-f1d3-2198-95b2-fcec0c80e7f8@redhat.com> Date: Thu, 14 Jan 2021 09:43:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 20/40] net/virtio: make interrupt handling more generic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/30/20 4:17 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.matz@6wind.com; >> amorenoz@redhat.com; david.marchand@redhat.com >> Cc: Maxime Coquelin >> Subject: [PATCH 20/40] net/virtio: make interrupt handling more generic >> >> This patch aims at isolating MSIX notion into PCI >> layer. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio.c | 6 ++ >> drivers/net/virtio/virtio.h | 11 +- >> drivers/net/virtio/virtio_ethdev.c | 7 +- >> drivers/net/virtio/virtio_pci.c | 131 ++++++++++++------------ >> drivers/net/virtio/virtio_pci.h | 25 ++--- >> drivers/net/virtio/virtio_user_ethdev.c | 4 +- >> 6 files changed, 90 insertions(+), 94 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio.c b/drivers/net/virtio/virtio.c >> index ba3203e68b..7e1e77797f 100644 >> --- a/drivers/net/virtio/virtio.c >> +++ b/drivers/net/virtio/virtio.c >> @@ -63,3 +63,9 @@ virtio_get_status(struct virtio_hw *hw) >> { >> return VIRTIO_OPS(hw)->get_status(hw); >> } > > [snip] > >> >> static uint16_t >> @@ -640,7 +640,7 @@ virtio_user_eth_dev_alloc(struct rte_vdev_device *vdev) >> * MSIX is required to enable LSC (see virtio_init_device). >> * Here just pretend that we support msix. >> */ >> - hw->use_msix = 1; >> + hw->intr_lsc = 1; > > As virtio-user does not have the notion of msi-x, should we also clean up the code > comments? I mean 'MSIX is required ... that we support msix'. The comment no more makes sense, I'll just drop it. Thanks, Maxime > Thanks! > Chenbo > >> hw->use_vec_rx = 0; >> hw->use_vec_tx = 0; >> hw->use_inorder_rx = 0; >> -- >> 2.29.2 >