From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 268F8A04B1; Tue, 24 Nov 2020 02:47:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 961CEC914; Tue, 24 Nov 2020 02:47:23 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 71D3C5928 for ; Tue, 24 Nov 2020 02:47:21 +0100 (CET) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Cg6MR15q8z6v2P for ; Tue, 24 Nov 2020 09:46:59 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Tue, 24 Nov 2020 09:47:10 +0800 To: Ferruh Yigit CC: , References: <1606141948-42313-1-git-send-email-oulijun@huawei.com> From: oulijun Message-ID: <58be93fc-a810-e96f-67e9-63d3d32d5b59@huawei.com> Date: Tue, 24 Nov 2020 09:47:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] doc: update features for hns3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2020/11/24 0:41, Ferruh Yigit 写道: > On 11/23/2020 2:32 PM, Lijun Ou wrote: >> Since the hns3 NIC hardware features are not counted >> and it is supported in fact. Besides, the flow director >> is not supported and need to delete it. >> > > Hi Lijun, > > Normally these should be updated when the feature is added but it seems > we have missed them. > Yes. Maybe it is ignoranted. As a result，it needs to add. > Can you please add the commits that introduces the features as "Fixes: " > line, to have them as reference? > Yes, I can. I will add it in next patch. >> Signed-off-by: Lijun Ou >> --- >> doc/guides/nics/features/hns3.ini | 8 ++++++++ >> doc/guides/nics/hns3.rst | 3 ++- >> 2 files changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/doc/guides/nics/features/hns3.ini >> b/doc/guides/nics/features/hns3.ini >> index fc61dde..f897a14 100644 >> --- a/doc/guides/nics/features/hns3.ini >> +++ b/doc/guides/nics/features/hns3.ini >> @@ -7,8 +7,12 @@ >> Link status = Y >> Rx interrupt = Y >> Queue start/stop = Y >> +Runtime Rx queue setup = Y >> +Runtime Tx queue setup = Y >> +Burst mode info = Y >> MTU update = Y >> Jumbo frame = Y >> +Fast mbuf free = Y >> Scattered Rx = Y >> TSO = Y >> LRO = Y >> @@ -20,19 +24,23 @@ RSS hash = Y >> RSS key update = Y >> RSS reta update = Y >> DCB = Y >> +SR-IOV = Y >> VLAN filter = Y >> Flow control = Y >> Flow API = Y >> CRC offload = Y >> VLAN offload = Y >> +QinQ offload = P > > Is "QinQ offload" supported? I don't see the driver setting neither > 'PKT_RX_QINQ_STRIPPED' nor 'PKT_RX_QINQ' to mbuf.ol_flags. > Can you please describe in the commit log why it is supported partially > (P)? > . Sorry. hns3 support to QinQ insert in the Tx direction and the QinQ stripped in Rx direction is not supported. QinQ offloading is considered as the former. I will fix it. >