From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECF53A04B3; Wed, 29 Jan 2020 00:46:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5F0E1C2EE; Wed, 29 Jan 2020 00:46:28 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C8A3E1C2DD for ; Wed, 29 Jan 2020 00:46:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2020 15:46:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,375,1574150400"; d="scan'208,217";a="217783058" Received: from unknown (HELO [10.241.225.137]) ([10.241.225.137]) by orsmga007.jf.intel.com with ESMTP; 28 Jan 2020 15:46:25 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, Harini.Ramakrishnan@microsoft.com, keith.wiles@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinjacobk@gmail.com, ranjit.menon@intel.com, antara.ganesh.kolar@intel.com, stephen@networkplumber.org References: <20200109031312.6344-1-pallavi.kadam@intel.com> <20200113215534.10084-1-pallavi.kadam@intel.com> <20200113215534.10084-9-pallavi.kadam@intel.com> <3035070.44csPzL39Z@xps> From: Pallavi Kadam Message-ID: <58ca460d-1bba-07f5-c9b5-0f741724544f@intel.com> Date: Tue, 28 Jan 2020 15:46:25 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <3035070.44csPzL39Z@xps> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v5 8/9] build: add additional common files support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/27/2020 2:55 PM, Thomas Monjalon wrote: > 13/01/2020 22:55, Pallavi Kadam: >> Added support for additional common files in meson build >> to expand Windows EAL and to support the lcore parsing >> feature on Windows. >> >> Signed-off-by: Pallavi Kadam >> Signed-off-by: Antara Ganesh Kolar >> Reviewed-by: Ranjit Menon >> Reviewed-by: Keith Wiles >> --- >> --- a/lib/librte_eal/windows/eal/meson.build >> +++ b/lib/librte_eal/windows/eal/meson.build >> common_sources = files( >> + '../../common/eal_common_bus.c', >> + '../../common/eal_common_class.c', >> + '../../common/eal_common_devargs.c', >> '../../common/eal_common_errno.c', >> '../../common/eal_common_launch.c', >> '../../common/eal_common_lcore.c', >> - '../../common/eal_common_log.c' >> + '../../common/eal_common_log.c', >> + '../../common/eal_common_options.c', >> + '../../common/eal_common_thread.c', >> + '../../common/rte_option.c' > Please add a comma after the last item of the list, so the next patch > won't need to change this line. Thanks, will update this in v6. > > >