DPDK patches and discussions
 help / color / mirror / Atom feed
From: Marat Khalili <marat.khalili@huawei.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH 2/2] app/test: make parameters clearer when adding fast tests
Date: Tue, 2 Dec 2025 16:53:02 +0000	[thread overview]
Message-ID: <58ce8da5c4094fb4b292fd58d068fc5f@huawei.com> (raw)
In-Reply-To: <20251202154948.1757169-3-bruce.richardson@intel.com>

> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Tuesday 2 December 2025 15:50
> To: dev@dpdk.org
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Subject: [PATCH 2/2] app/test: make parameters clearer when adding fast tests
> 
> For the fast tests, we have two extra parameters specifying when the
> test can be run without hugepages or using ASan. The true/false nature
> of these parameters is not very clear, so change things so that they are
> explicitly specified as NOHUGE/HUGEPAGES and NOASAN/ASAN instead.
> Explicitly validate the options in the meson.build files, rather than
> just checking for one of the pair of options - which can hide errors.

I like the idea. However, I think that NOASAN/ASAN is still not fully self-documenting, and may be misleading. Without reading some docs I'd think NOASAN means test will be run without sanitizer and ASAN means it will be run with. As a minimal fix, what about NOHUGE_OK/NOHUGE_SKIP and ASAN_OK/ASAN_SKIP?

More intrusive option, to simplify most normal uses and highlight exceptions:
* 0 (or DEFAULT, or RUN_ALWAYS)
* SKIP_IF_ASAN
* SKIP_IF_NOHUGE
* SKIP_IF_ASAN | SKIP_IF_NOHUGE

  reply	other threads:[~2025-12-02 16:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-02 15:49 [PATCH 0/2] improve fast-tests suite Bruce Richardson
2025-12-02 15:49 ` [PATCH 1/2] app/test: add some unattached tests to fast-test suite Bruce Richardson
2025-12-02 15:49 ` [PATCH 2/2] app/test: make parameters clearer when adding fast tests Bruce Richardson
2025-12-02 16:53   ` Marat Khalili [this message]
2025-12-02 18:16     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58ce8da5c4094fb4b292fd58d068fc5f@huawei.com \
    --to=marat.khalili@huawei.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).