From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4ED02A0530; Thu, 23 Jan 2020 19:32:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C37DC2C6D; Thu, 23 Jan 2020 19:32:55 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E8AAEDE3; Thu, 23 Jan 2020 19:32:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jan 2020 10:25:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,354,1574150400"; d="scan'208";a="222419060" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.35]) ([10.237.221.35]) by fmsmga008.fm.intel.com with ESMTP; 23 Jan 2020 10:25:19 -0800 To: "Iremonger, Bernard" , "Lu, Wenzhuo" , "Wu, Jingjing" , Matan Azrad Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20200123151509.3207419-1-ferruh.yigit@intel.com> <3bec9d91-fe4c-1429-2922-2af8cbdb2e67@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <58d25937-0677-86a3-283c-08c355c0a4df@intel.com> Date: Thu, 23 Jan 2020 18:25:18 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/23/2020 5:46 PM, Iremonger, Bernard wrote: > Hi Ferruh, > >> >> >>>>> Subject: [PATCH] app/testpmd: fix hotplug >>>>> >>>> This is reverting the original patch, which breaks hotplug. >>>> I think the commit message should make this clear. >>>> This patch is not fixing hotplug, the original patch seems to have >>>> revealed a >>> problem with hotplug. >>>> Reverting this patch will not fix the underlying hotplug issue. >>> >>> What is the problem revealed by the original patch? Did you able to >>> reproduce it? >> >> No, I thought you had. I can't reproduce the problem mentioned in original patch, but can reproduce now, so from my perspective "fixing testpmd hotplug" >> There is a lot of information in the commit message, but is not clear that you >> are reverting a patch. OK I can add a note >> I am ok with reverting the original patch as it has caused a problem. > > Just had another look at the patch, there are two changes. > One reverts the original patch. > The second is a fix. Not exactly, fix is reverting, second change is removing log which is to reduce the noise. Both changes mentioned in the commit log. > Suggest splitting patch into two, one for revert and second one for fix. > >> >>> >>>> >>>>> The 'port_id_is_invalid()' check in the 'detach_port_device()' is >>>>> breaking the hotplug support, since at that stage port will be >>>>> closed and validity check always fail [1] and removing the device >>>>> is not really >>> completed. >>>>> >>>>> But this cause the vfio request interrupt keep triggered >>>>> continuously and makes the application unusable, since port is >>>>> closed but device is not removed, the remove path keep generating >> error log: >>>>> >>>>> EAL: can not get port by device 0000:00:05.0! >>>>> EAL: can not get port by device 0000:00:05.0! >>>>> EAL: can not get port by device 0000:00:05.0! >>>>> EAL: can not get port by device 0000:00:05.0! >>>>> EAL: can not get port by device 0000:00:05.0! >>>>> EAL: can not get port by device 0000:00:05.0! >>>>> >>>>> Fixed by removing 'port_id_is_invalid()' check from >>>>> 'detach_port_device()', anyway it shouldn't be required. Without >>>>> this check device remove works as expected. >>>>> >>>>> Only "Invalid port_id=0" logs seen a few times, which is because >>>>> the actual removal not done synchronously but an alarm set for it, >>>>> until the alarm fired application may receive many interrupts, >>>>> expect the first ones cause the error. >>>>> So this patch also removes the logging from checking the invalid >>>>> port in 'rmv_port_callback()' to reduce the noise. >>>>> >>>>> [1] >>>>> rmv_port_callback() >>>>> stop_port(port_id); >>>>> close_port(port_id); >>>>> detach_port_device(port_id); >>>>> >>>>> Fixes: 43d0e304980a ("app/testpmd: fix invalid port detaching") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Ferruh Yigit >>>>> --- >>>>> app/test-pmd/testpmd.c | 6 ++---- >>>>> 1 file changed, 2 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>>>> f9f4cd1d3..3323013bb 100644 >>>>> --- a/app/test-pmd/testpmd.c >>>>> +++ b/app/test-pmd/testpmd.c >>>>> @@ -2641,9 +2641,6 @@ detach_port_device(portid_t port_id) >>>>> >>>>> printf("Removing a device...\n"); >>>>> >>>>> -if (port_id_is_invalid(port_id, ENABLED_WARN)) -return; >>>>> - >>>>> dev = rte_eth_devices[port_id].device; if (dev == NULL) { >>>>> printf("Device already removed\n"); @@ -2875,7 +2872,8 @@ >>>>> rmv_port_callback(void *arg) int org_no_link_check = >>>>> no_link_check; portid_t port_id = (intptr_t)arg; >>>>> >>>>> -RTE_ETH_VALID_PORTID_OR_RET(port_id); >>>>> +if (!rte_eth_dev_is_valid_port(port_id)) >>>>> +return; >>>>> >>>>> if (!test_done && port_is_forwarding(port_id)) { need_to_start = >>>>> 1; >>>>> -- >>>>> 2.24.1 >>>> >>>> Otherwise >>>> Acked-by: Bernard Iremonger >>>> > Regards, > > Bernard. >