From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 72A4CFA31 for ; Thu, 19 Jan 2017 15:58:49 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 19 Jan 2017 06:58:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,254,1477983600"; d="scan'208";a="32720467" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69]) ([10.237.221.69]) by orsmga002.jf.intel.com with ESMTP; 19 Jan 2017 06:58:39 -0800 To: Bruce Richardson References: <1482381428-148094-2-git-send-email-david.hunt@intel.com> <1483948248-91364-1-git-send-email-david.hunt@intel.com> <1483948248-91364-2-git-send-email-david.hunt@intel.com> <20170113151955.GA201464@bricha3-MOBL3.ger.corp.intel.com> Cc: dev@dpdk.org From: "Hunt, David" Message-ID: <58d98518-7204-32d7-f0b7-c459a5be70fb@intel.com> Date: Thu, 19 Jan 2017 14:58:38 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170113151955.GA201464@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/6] lib: distributor performance enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 14:58:49 -0000 On 13/1/2017 3:19 PM, Bruce Richardson wrote: > On Mon, Jan 09, 2017 at 07:50:43AM +0000, David Hunt wrote: >> Now sends bursts of up to 8 mbufs to each worker, and tracks >> the in-flight flow-ids (atomic scheduling) >> >> New file with a new api, similar to the old API except with _burst >> at the end of the function names >> >> Signed-off-by: David Hunt >> --- >> lib/librte_distributor/Makefile | 2 + >> lib/librte_distributor/rte_distributor.c | 72 +-- >> lib/librte_distributor/rte_distributor_burst.c | 558 +++++++++++++++++++++ >> lib/librte_distributor/rte_distributor_burst.h | 255 ++++++++++ >> lib/librte_distributor/rte_distributor_priv.h | 189 +++++++ >> lib/librte_distributor/rte_distributor_version.map | 9 + >> 6 files changed, 1014 insertions(+), 71 deletions(-) >> create mode 100644 lib/librte_distributor/rte_distributor_burst.c >> create mode 100644 lib/librte_distributor/rte_distributor_burst.h >> create mode 100644 lib/librte_distributor/rte_distributor_priv.h >> > Run a documentation sanity check after this patch throws up a few > warnings: > > --- /dev/null 2017-01-10 10:26:01.206201474 +0000 > +++ /tmp/doc-check/doc.txt 2017-01-13 15:19:50.717102848 +0000 > @@ -0,0 +1,6 @@ > +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_burst.h:187: > warning: argument 'mbuf' of command @param is not found in the argument > list of rte_distributor_return_pkt_burst(struct rte_distributor_burst > *d, unsigned int worker_id, struct rte_mbuf **oldpkt, int num) > +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_burst.h:199: > warning: The following parameters of > rte_distributor_return_pkt_burst(struct rte_distributor_burst *d, > unsigned int worker_id, struct rte_mbuf **oldpkt, int num) are not > documented: > + parameter 'oldpkt' > + parameter 'num' > +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73: > warning: Found unknown command `\in_flight_bitmask' > +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73: > warning: Found unknown command `\rte_distributor_process' > > Regards, > /Bruce Will be cleaned up in next revsion. Thanks, Dave.