From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BB7A45500; Wed, 26 Jun 2024 13:58:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0062E43363; Wed, 26 Jun 2024 13:55:29 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 7D7D642E95 for ; Wed, 26 Jun 2024 13:43:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719402225; x=1750938225; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Wx0lVKxgCBQsgtf0GpiUy5Yqk+/WqMHUorOe878HrCo=; b=fWmPYPDqIouJ+5rLyLvyjrJRFxSCX2Zfho4LgA1C8l1CTJb+JGj3qjFY QvmUDBHZ5TDWcfrgn1KoXaO9uc2o7QHc4GNYZD/Db9ekZIMZ0fOgNVIqk +QDDkIhZMs3ncM2ZV2qsX5wfJ7d4WIq7XgfWJGASbWV2hB3Tz7zYcYiCt 2JcsnaJYGAWgLxLlsQwkb3uPqBUJl4KPwidmYscfmmJBXBXWx7bJ0fltk +27KMTgflkwKVsSdxQHjpwvD3DeGjdUVDc5vD35708oaCblsryE7Mi3SF aHGjHkkowOLr4+FSZhcOXWhsRHrB+Ci5cb89TJhdRfXwjf+LcQgP33R+C Q==; X-CSE-ConnectionGUID: Q5mPuqRQSOiRhgIuoWJhaQ== X-CSE-MsgGUID: qj7wmWsNTEqrMx8bU7XlYw== X-IronPort-AV: E=McAfee;i="6700,10204,11114"; a="38979360" X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="38979360" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 04:43:45 -0700 X-CSE-ConnectionGUID: WIp/ATezQl60bBwQSdbjxg== X-CSE-MsgGUID: 1zBrh2mGQsqZ+P3XAGc8cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="43873633" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa010.jf.intel.com with ESMTP; 26 Jun 2024 04:43:44 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Jacob Keller , ian.stokes@intel.com, bruce.richardson@intel.com Subject: [PATCH v4 027/103] net/ice/base: use ICE_PTP_NOP to better indicate no action Date: Wed, 26 Jun 2024 12:41:15 +0100 Message-ID: <58e7555fc892a4b8c008325ca8a0eae11c311a25.1719401847.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jacob Keller A couple of E822 PTP functions use ICE_PTP_READ_TIME on the main timer to avoid any side effects when programming a single PHY port. Match the ETH56G code by using ICE_PTP_NOP instead, which better reflects the intended behavior. Signed-off-by: Jacob Keller Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_ptp_hw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c index 27451a5897..e4b621591d 100644 --- a/drivers/net/ice/base/ice_ptp_hw.c +++ b/drivers/net/ice/base/ice_ptp_hw.c @@ -4114,8 +4114,8 @@ static int ice_sync_phy_timer_e822(struct ice_hw *hw, u8 port) if (status) goto err_unlock; - /* Init PHC mstr/src cmd for exec during sync */ - ice_ptp_src_cmd(hw, ICE_PTP_READ_TIME); + /* Do not perform any action on the main timer */ + ice_ptp_src_cmd(hw, ICE_PTP_NOP); /* Issue the sync to activate the time adjustment */ ice_ptp_exec_tmr_cmd(hw); @@ -4242,8 +4242,8 @@ ice_start_phy_timer_e822(struct ice_hw *hw, u8 port, bool bypass) if (status) return status; - /* Init PHC mstr/src cmd for exec during sync */ - ice_ptp_src_cmd(hw, ICE_PTP_READ_TIME); + /* Do not perform any action on the main timer */ + ice_ptp_src_cmd(hw, ICE_PTP_NOP); ice_ptp_exec_tmr_cmd(hw); -- 2.43.0