From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <amin.tootoonchian@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 4C5992BA2
 for <dev@dpdk.org>; Wed, 20 Jul 2016 19:25:22 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP; 20 Jul 2016 10:25:07 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,395,1464678000"; d="scan'208";a="1010686329"
Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130])
 by fmsmga001.fm.intel.com with ESMTP; 20 Jul 2016 10:25:07 -0700
Received: from orsmsx109.amr.corp.intel.com ([169.254.11.206]) by
 ORSMSX103.amr.corp.intel.com ([169.254.5.146]) with mapi id 14.03.0248.002;
 Wed, 20 Jul 2016 10:25:06 -0700
From: "Tootoonchian, Amin" <amin.tootoonchian@intel.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Kerlin, MarcinX"
 <marcinx.kerlin@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] ethdev: ensure consistent port id assignment
Thread-Index: AdHb4OxXvCXtsLkTSc+EWpRn1GpjVgGftbBwAA3FvRAADzZlgAAMwVkg
Date: Wed, 20 Jul 2016 17:25:05 +0000
Message-ID: <5905C8E33883CA46A8878E2D7724E2151729BE@ORSMSX109.amr.corp.intel.com>
References: <5905C8E33883CA46A8878E2D7724E21516DF5D@ORSMSX109.amr.corp.intel.com>
 <68D830D942438745AD09BAFA99E33E812746D0@IRSMSX102.ger.corp.intel.com>
 <5905C8E33883CA46A8878E2D7724E215172927@ORSMSX109.amr.corp.intel.com>
 <29406326.BbypyUUmXA@xps13>
In-Reply-To: <29406326.BbypyUUmXA@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.22.254.140]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] ethdev: ensure consistent port id assignment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jul 2016 17:25:22 -0000

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, July 20, 2016 8:12 AM
> To: Tootoonchian, Amin <amin.tootoonchian@intel.com>
> Cc: dev@dpdk.org; Kerlin, MarcinX <marcinx.kerlin@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ethdev: ensure consistent port id assignm=
ent
>=20
> Hi,
>=20
> 2016-07-20 15:07, Tootoonchian, Amin:
> > Thomas, your thoughts?
>=20
> I have 2 thoughts:
> - it is too big for 16.07
> - it is related to multi-process mechanism, maintained by Sergio ;)
>=20
> Sorry I won't look at it shortly.

[Adding Sergio to the thread for review.]

The actual change of this patch is quite small (see below) but I understand=
 that it may be too late for 16.07:

* The main addition is getting the port id using rte_eth_dev_get_port_by_na=
me for secondary processes in rte_eth_dev_allocate. Also zeroing out rte_et=
h_dev_data after freeing a port to avoid false positives in rte_eth_dev_get=
_port_by_name.

* The rest of the patch moves parts of rte_eth_dev_allocate to be executed =
only by the primary.