From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B8FA42D14; Wed, 21 Jun 2023 14:44:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 238DE4068E; Wed, 21 Jun 2023 14:44:23 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2079.outbound.protection.outlook.com [40.107.100.79]) by mails.dpdk.org (Postfix) with ESMTP id 97A3F4003C for ; Wed, 21 Jun 2023 14:44:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ibMeOm6mRtUYPkkU7DO3GEsX1PtjiC0lHbntPTAR4FOSyunj2Y/xdmPtPNl5CNgoVEmmtEg3OrKXZsKtgI5a9CDL7MwC0F35WFlLU/NM+97x5T+YMmbhS4Rd7uF1PG0nVjsVU3xoAZw9QXnJHeuevu/7hS7vvaUM8ODJe5U/LdJ09w32YVZGswLDi5L2jz2+e3cew+HrGzEe0SLAOSw18S8jvAT2oDj/VHaN60UqCp19fSDwG8Bo3BtEurTX8rHkXu+zb34rGaO9Z3cLDuwAR/T8GrnHp6pUJJbg8nkQT9YE2HUKLOM2lQE3FlJvape2TmiUVJiqCgKI5mPaOKGTRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6uHHZkRufmxLQgqfdWLPD2irSyTsz+XI6u2Bhl/8jTs=; b=Rz+WrPiI3ZJyjr7PExl5ULFkx2yiwtVRRFkOU/2rLdRKAOvOS6dVJOmzZw9gwlfC9TSId88pG0s3YuZ1fKkdPJN64xhi4o3WlHzplXb39XJCTcxQXZ6UqPgAlWELblCv38CYPBZVWb7NHdh2WvK0Y8wFQkEfHQp03EmuMReBzatQuz5u7UewuxMozeuuo/DfCpeZSosw0VRWmrnjmJytC9I2Yv4XcE4I9SqkhlP5KKYg/I6AK++F1zT0CbCOu79fUraCNKxUrA0JX35HIaZ+qiCHSM1YylO7Ya/WgZL4n48Y9ng/1absEmKW145retpAKsktIh/BeeTSMxr+3ab3mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6uHHZkRufmxLQgqfdWLPD2irSyTsz+XI6u2Bhl/8jTs=; b=MKmU7y8P61b0VYTs/IgfiqmIVrMcuogt3U4MO6N6Xtln2gjJcU2+W+Eh+FuzxEjZG7TI32d9ErdtEDXSVOJf7yGiu/BUanuJmUEzGC9ol81DF1+ImLTADk6gdovzUFmTvkgQlOgCkP6xRP8OTCZGwz/FLr61qkXcOcSGqezjA2Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW6PR12MB8951.namprd12.prod.outlook.com (2603:10b6:303:244::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.35; Wed, 21 Jun 2023 12:44:19 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.023; Wed, 21 Jun 2023 12:44:19 +0000 Message-ID: <590864e0-0dcf-9165-f43c-8ce879fff31b@amd.com> Date: Wed, 21 Jun 2023 13:44:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] net/nfp: fix getting firmware version Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu , Peng Zhang References: <20230615013038.1243099-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230615013038.1243099-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0481.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW6PR12MB8951:EE_ X-MS-Office365-Filtering-Correlation-Id: a2864360-ddef-42d6-f198-08db72553ad3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E5LRB/WDfv3Yi3XCuUgoky/oiYPNPyOT5Y2/rzcjvsJu/fpIj7A3sKJsFurAI49+fyCXm1r0HFMMakr0l/SWcrp3rXthGmNyUg/MH+C5iu6Lr679sH4i6n1V3+/J9m46Uq8wwM/zYHa0c/azL14xnIsvcjVk05ZdXHWaeDU+mi8MiagSoxz6GrlUQpaYX2jgvWu8C4C7TdaAG7rcAxNfU9C/vZFh3PZ7kNmWHiJ6om1z6Aiy5sNoXBn1x49Avya8m2aZBrRAgQKj1GMweANVZofWiHCkxEFm9FDxNpIMQdCEhkYS2tb/wnKMY4P1awh6zdjA8d7YAhl/glzks5h2q0y9T+KmXH0SJt+24Q9TGWBrghdpVc7PWVlZVbu2tS3YFbNzMLrugumfOFUW9/6EVvHZNpaO3X/5gcPGX/TPxoDdo9vDSjlk/Xx4AHoaXpVUhyooxc7VN5L+u2u39ysPmejHayRFAa9vtQvmp6acMWgUy+vu5Z1JIMCkYKkD1GOtcT+8QEVT5QWw/lC+f4xouZvxeqCB0SgatndigxyWZzTQsqIgMFpCOJyRdOI6RqAI/KBIOfW746FMBCPH0K+FPpnnycd18Sl8Ff8OAAcPGxgyni8Uq6vjoXIpU0qEICnSmie0faUazFLGrSDRQGF7RA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199021)(6666004)(38100700002)(36756003)(86362001)(31696002)(6486002)(186003)(53546011)(6506007)(26005)(8676002)(8936002)(5660300002)(4744005)(44832011)(2906002)(478600001)(6512007)(316002)(31686004)(66946007)(54906003)(41300700001)(4326008)(66556008)(66476007)(2616005)(83380400001)(66574015)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2xlUXFpVmI5NTVhS080TzJZdmxkWUFWUVFQdVNXU2htU0dod2tzbkEzYmc0?= =?utf-8?B?UzdKWnhnTHNKYnNWTXJhbWJKNlM0QnRmWFF4cjVRclVCTGtFVElQYW82R1ZY?= =?utf-8?B?ZnpzS0RkU3FEK0VBeHZ0SFJ4VEhwOHpqM09iWTZ6YVBYN3pXZGNrZ2JNVnUv?= =?utf-8?B?ZTBtZUxObndtQkJwWHhZLzZJWEVLbk0zaWtrTEhNUGNCNW1xY3VlWWIxbkF3?= =?utf-8?B?NXJOcTd4T05tQlJMejFDbmp1cUZyWkJGVEl0VC8wSm1pZmFEZXlzVkpOUTZB?= =?utf-8?B?NTAvWXdRaHdacU9pRmxFbjd0Q2lBTWNVeFR5Uk9uYlFWRStEMXl5ZjN3T1JE?= =?utf-8?B?SUxsaHF5MU1Mb1JLVDFLTlg2L21RRzJIdDVPSVdpUlhMdWxkZ3g4di8rOURY?= =?utf-8?B?L3Y3Ky9aMXV3VHNsSktrREhHWlNhSzhNODBBTnVKL05JUEc4T2NIbGwxNmhZ?= =?utf-8?B?YnJFNld3LzVnSzZidFdYUERFTGI2RkNIalhUSVFDUmsyZlplNWszRU43TVdk?= =?utf-8?B?dmwzeVZ6bVNZM0Ezc0doMkF6WEdTQThla3VBSjNjQlhab2dmdUhKZUdaQmdh?= =?utf-8?B?dkdGc2svbkdvdllRV3JoS0dhZE05WDdiMVNFRUZjNmZqMDFLQlU2Qk9LMVhh?= =?utf-8?B?a2oxN1Q4cjI1aTI5Vy9oQ0ZnNGhxbUxVaENFMngrVkpsQ3BiaXVaVytTZ2FE?= =?utf-8?B?c0QxWWRpUkIzQUVlWkRTYnRsbjBnSUQzUnF2dDZzMzk1ZDRLZE5oNWkzOXFL?= =?utf-8?B?MXJhWjZXY1NVbmFsRy9temZGQUtXV1lOQ044Z2wyYU9xNVdHYVpoTk1IYkN4?= =?utf-8?B?L2Fia3dUM2RkTWt2eCtPOEQ1dExra0ZCNkI1c2ZhV2NqYlFxWlQ3SCszeERV?= =?utf-8?B?bFhYUUVGc2pSaW1lRmlpb293eE1QUlhVNmY5VG4wYnBuSVYxMnp6TkZtclI5?= =?utf-8?B?cHBBbTB0ZDVnUldYYTlhbEtVb2k5NHMxOFJBM0xkM3VxMXpoUGswVDZ0UnJ5?= =?utf-8?B?WlZPaWI1ZFFPS015K1hpYkwxVmh6eXJ5b09zb1FyQ0hZbHhvRDhKOUgzNUtq?= =?utf-8?B?d25Zc0xwQ09XN3dveEVsZVRtdHlvMFVNU2hYNWFoNjhiMjNQeFI3QVRvQitq?= =?utf-8?B?ZUxYNlg4VU1EODhQdkdyTTVsY2x0L1ZyYlNYOGdHVXZJc3RRRjQ2L3Z6dThj?= =?utf-8?B?Tk1Velg3M3lLcGxRNG5meXdDdzk5UEtxM25GQXZUbzBzbTMwMWc2TndxdEZ0?= =?utf-8?B?aGlJRzdsT25BallQTXVjWWl3Z0ZMWmYwV3p1MTQ4aUVsMERNaXVNUVVtU0lR?= =?utf-8?B?amtDaWlMREVjQ3p4ZlorRjAweVRxU3h3SUVZVWVtM2lUZjQ5b2VLakZ2Yk9v?= =?utf-8?B?WTNjNkdhWjdWWUI4VWN1d0RCMlhnVkhxUVhZUGJuYjZYdDR1Qkpqb1puMlNO?= =?utf-8?B?OWEzYnk5cUZzV2pwbklidGZ5RFNCOXhManZaNmVkVndGQVhEdVl1K2psOVhZ?= =?utf-8?B?MXVtU3RjdWZkNEFrTnkrcGZ5bFdmK0VLaDk2N3RwK3JZSkh2ZVdPZVpnRkhI?= =?utf-8?B?QmlCclhUTTJqU21EdXhkM2dZZnE2RWhlaVVPZkcvMXFQbGdMNWw1TVBuT0Rl?= =?utf-8?B?bEdaOHdCanA2RVpvTGlQR2RnL0YrQ2tPSGhVcXU4dFZaZktHdkdIWmZ2Q3Fw?= =?utf-8?B?ZGNocEZ0dUxqMVpHL1YxUEdlN0dmTi94TVNtbFNiMWJsRkVHZnk5OW9XQk5C?= =?utf-8?B?YmdpSy9JSXpTeEQzNEVsUmxXK2dmSzBHZmh4T0NwVy85WDhFdnZxQkxJc1Br?= =?utf-8?B?VDBSRGVGaE5PTm56UnZMNUNDLytIZXBNK1dJRlpEZzhMM05HK2pvQjFTeFh3?= =?utf-8?B?aTZqRE11alVjeWRzTjUrUjVMWjhoUko5cDlYUEdSNDhvQWJHRlJtOGRRaXFY?= =?utf-8?B?c1BUMHZRM09jM0Z0cDVzQVM3TTQyaW1PbDFpNlB2Q3FrS1drSi9ZS2k1Zjg1?= =?utf-8?B?OGV1VkxLSmRpNGs1Uk9jRTAyZmJhWEZPaUdIbTVCUDVkR1Z2YitOWUNWNnI4?= =?utf-8?B?Q0Q5UkwwRU9FT25rMGxHNHNHYzRtUjd0TDdLMmFjdkFPY1BvUnU2ZS9jQ3k5?= =?utf-8?Q?aGHZL8mA7nmtaN+8hv5iPZmEh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2864360-ddef-42d6-f198-08db72553ad3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 12:44:19.0653 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fka2antE4Wm6JhIxCWzc0M4lUSHqcl74chovdfGdPSm6+iwcWFMRXG28b404VAPe X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8951 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/15/2023 2:30 AM, Chaoyong He wrote: > The VF PMD can not get a valid 'cpp' data filed in the 'struct > nfp_net_hw', the value of which will be NULL always. This cause any > logic which use of 'cpp' will make the app crash. > It is not fixing getting FW version, but fixing crash by removing FW get, updating patch title while merging. > Fix this by delete the support of getting firmware version of VF. > > Fixes: 128c8ad951bf ("net/nfp: support getting firmware version") > Cc: chaoyong.he@corigine.com > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Niklas Söderlund > Reviewed-by: Peng Zhang Applied to dpdk-next-net/main, thanks.