From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 22DA78055
 for <dev@dpdk.org>; Tue, 16 Dec 2014 00:24:46 +0100 (CET)
Received: by mail-wg0-f48.google.com with SMTP id y19so15990644wgg.35
 for <dev@dpdk.org>; Mon, 15 Dec 2014 15:24:46 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=GefbgpN5Y2JCdGMq+lADFA+RjpBAiEb/XE2xbrjx0z8=;
 b=JcCVJ6AIUEjiWQvLDiU2rYcpGfzgQMgRuHlVbBm58g3xybVbAsCHSOeECwEzMx/28W
 NCgs/W6aGu8yVpPFnadHdtddKu2PcWtEccXm1yQOZl/G3B5IY9+E5gqMZlVk5+0E05sG
 E/At5TI3yUGwni5B7BBfrURS2ehuLuRwSnFCFcnaX192UCZrFBtxpMFF+bgEOvmkUvAM
 NYY1lonjPxFzmPI2hmUpz+iKeshxI8usT99z2qWuTHu7R1hnhHE6H34MJ0xvBMJPLCd8
 HYIqwfAsdQNLDtqQH7VVHlZ3D19FW/ctgTe3mTk2gTJq4ifWT3o6ew6fmUwExciuBiov
 tzRw==
X-Gm-Message-State: ALoCoQmTOgwyKzf8vgW8OVHdLI3reFs0vxzfvNeSXNVVbbsHd9r98VNFgNCDPJjMb6Zo3obksI97
X-Received: by 10.194.19.38 with SMTP id b6mr56771202wje.44.1418685885947;
 Mon, 15 Dec 2014 15:24:45 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id n3sm14847581wiw.5.2014.12.15.15.24.44
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 15 Dec 2014 15:24:44 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sujith Sankar <ssujith@cisco.com>
Date: Tue, 16 Dec 2014 00:24:19 +0100
Message-ID: <5911790.4rCTPaIceN@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1418372303-31565-1-git-send-email-ssujith@cisco.com>
References: <1418372303-31565-1-git-send-email-ssujith@cisco.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Dec 2014 23:24:46 -0000

2014-12-12 13:48, Sujith Sankar:
> This patch corrects the usage of the flag VFIO_PRESENT in enic driver.

Please, could you explain why the flag VFIO_PRESENT was not well used?

> This has uncovered a few warnings, and this patch corrects those too.
[...]
> --- a/lib/librte_pmd_enic/enic_main.c
> +++ b/lib/librte_pmd_enic/enic_main.c
> @@ -39,6 +39,7 @@
>  #include <sys/mman.h>
>  #include <fcntl.h>
>  #include <libgen.h>
> +#include <sys/ioctl.h>
>  
>  #include <rte_pci.h>
>  #include <rte_memzone.h>
> @@ -46,6 +47,7 @@
>  #include <rte_mbuf.h>
>  #include <rte_string_fns.h>
>  #include <rte_ethdev.h>
> +#include <eal_vfio.h>

This header was not designed to be included by PMDs.
It will break compilation on BSD.

>  #include "enic_compat.h"
>  #include "enic.h"
> @@ -561,6 +563,7 @@ enic_free_consistent(__rte_unused struct rte_pci_device *hwdev,
>  	/* Nothing to be done */
>  }
>  
> +#ifndef VFIO_PRESENT
>  static void
>  enic_intr_handler(__rte_unused struct rte_intr_handle *handle,
>  	void *arg)
> @@ -572,6 +575,7 @@ enic_intr_handler(__rte_unused struct rte_intr_handle *handle,
>  
>  	enic_log_q_error(enic);
>  }
> +#endif

-- 
Thomas