From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 24AC02952 for ; Wed, 10 May 2017 14:33:31 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id w50so42208167wrc.0 for ; Wed, 10 May 2017 05:33:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-transfer-encoding; bh=0LBLWNU410EpJuzj05R2buTAiBoI4isb7Eyub6y7gD4=; b=xebmrLmF6s37/FRLpKoly0G1qweb+s+3G3u+/gqOdKrZiWk/Pu0cnAhm8Yukd0trao Ojx+BSBmMlQwdlDgizKJPK44Ge2vAoKrDPVejtY+3llw/FDUqhjtgXoDx/xfsiOO9Ft1 deHM7gy8UbGfy0p4k5wGwLVTOZxd6JhgqcN7MrecLuIs/4+c03p7Y3px3aT9eEmXFBWp tGTVWrtTC+ldEr5bVXIkgNPLOqtQkw/rAfHSGbWDx2w6ZVBj/2b5rJC9oWiOR1AwZ5Ij qqDUBxQ6QHPiNfAfdBZi067FDs7GpEqEL5kx0IYGgKt+dkdNyb4U1qNhhvX5qYg7S7WP pJ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-transfer-encoding; bh=0LBLWNU410EpJuzj05R2buTAiBoI4isb7Eyub6y7gD4=; b=LSHAmBb91Og48n+x+7SJmXOs0MFge0JaTAXNw0Jv3bxlzW2eDTT6ypVkjUj+b1As1w Fm1Y57abVlJEVhDyDC+U+J7LxxanrYL/5bSo5gvYqes/lANKYbqa17KmUE8WEGeRVF6Y dzUp0g65GtCPG5xWgqfEfl1rvPksik4Wh1AOpB8vqDzku11cmbHUsD7H1LsxlosId4XW pTSjWpE7sI1/AqJyRN6FgkJJnHW/q9xo9jEGTQxKgM3I/RZeNyzo98IyMP66ch2Yu931 f7g0AdFCg0PwW3xy8gwpqpuomOEnbr7P8ccbs09s/y0yktduA1l5FuGs7gbhS4NkcVVA 5A0A== X-Gm-Message-State: AODbwcBGm3OR3XTXSlVW5N+3d7zxVRuqSfVoBhxLbR9/GomeK44Ym4ZV FtYHnOgd1Up8Imee X-Received: by 10.28.63.142 with SMTP id m136mr3349589wma.87.1494419611659; Wed, 10 May 2017 05:33:31 -0700 (PDT) Received: from [10.16.0.207] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.googlemail.com with ESMTPSA id x20sm3999388wme.0.2017.05.10.05.33.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 05:33:30 -0700 (PDT) Message-ID: <59130895.90503@6wind.com> Date: Wed, 10 May 2017 14:33:25 +0200 From: Laurent Hardy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "Roger B. Melton" , Ferruh Yigit , Wei Dai , wenzhuo.lu@intel.com, konstantin.ananyev@intel.com CC: dev@dpdk.org, stable@dpdk.org References: <1494399602-33955-1-git-send-email-wei.dai@intel.com> <8ad4912d-05d5-fdad-8bb5-a3e414c45738@cisco.com> In-Reply-To: <8ad4912d-05d5-fdad-8bb5-a3e414c45738@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 12:33:32 -0000 Hi Ferruh, Wei, Roger, PSB I also redo test plan provided through http://dpdk.org/dev/patchwork/patch/20502/ Thanks & regards, Laurent On 05/10/2017 02:20 PM, Roger B. Melton wrote: > > > On 5/10/17 5:50 AM, Ferruh Yigit wrote: >> On 5/10/2017 8:00 AM, Wei Dai wrote: >>> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not >>> be called directly. It had better be replaced by calling >>> ixgbe_get_media_type( ) to avoid crash. >>> >>> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Wei Dai Acked-by: Laurent Hardy >> Hi Roger and Laurent, >> >> This is very close the release, can you please support verifying this >> defect? >> >> An explicit Acked-by and/or Tested-by would help a lot. >> >> Thanks, >> ferruh > > Hi Ferruh, > > Happy to test it. I'll get back to you shortly. > > Regards, > Roger > >> >> >>> --- >>> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >>> b/drivers/net/ixgbe/ixgbe_ethdev.c >>> index ec667d8..ed2baec 100644 >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >>> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, >>> int wait_to_complete) >>> hw->mac.get_link_status = true; >>> if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && >>> - hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { >>> + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { >>> speed = hw->phy.autoneg_advertised; >>> if (!speed) >>> ixgbe_get_link_capabilities(hw, &speed, &autoneg); >>> >> . >> >