From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 979BF439A8; Tue, 23 Jan 2024 15:59:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DCEA402C5; Tue, 23 Jan 2024 15:59:35 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2061.outbound.protection.outlook.com [40.107.212.61]) by mails.dpdk.org (Postfix) with ESMTP id 38A04402B0 for ; Tue, 23 Jan 2024 15:59:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z727RGfFq8h1MVrOCKzDq2WvgQx/qPDQrfq2PZkYOa6JDK+jtJ0qeASO0SNGdP1xUthKPnlsICmk++P9PbNpCkrGToi3KZ18iYNcnBBIwFgSie1EScjhZ0MQ6A0U2JipktaJbsPajsaK2PqQYVlehCDheqdEKkX1SBuUAtpEnM36Dk+GT5v9jk70QYTiopC8h3kEzw73zx8u7DPZReMqpE3ojHG4XoT86oiBGg5KgCpABdWcecr7kJGmTjLZxpBRUPlmDeBP2WomoN3kDdAl9aB6Qcwg+sBgULutnJUZL5QDnzomhUmVa/oBTVmroyW/G+LPTY4yKB+8xktHWMUKZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bkWkFZhPApuGGCxR3wbHGH2b1605y5FbQEgC0IvyOjs=; b=F7npfmkIY9nyFx5mc21GBX1wlzWV89hl57k374Rxt7Onq2nOUUfnpx9XJSqzB+3N5je2kzQWrfrXIaCjuBd2bHI01fxq8L3FGwofeMNLzzdyeJ73ttaL/Bw4ZsN42SKyq8EFuIyI1QCQdwlYrhhL/a4c3xVMDvwtEl1JmfTMF4X1PmbUcdZRvq5gK74XyUt/IX4ZlJZ7ZGB6rxC+atkX4BOWptEyYjByVLtym9e0djCW1ekgGNb4sr2NVh/4h1CYflwk+Naxj5ou1hq6NiylA3kcEDVTvHHYvDOL2ISf5BPBuT+Rb6jlHYJLycX0FHv5SQkLNtas8S7fPWjxyTGXGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bkWkFZhPApuGGCxR3wbHGH2b1605y5FbQEgC0IvyOjs=; b=k8rN73zp1zmFg2iDfA9hIyit9276qDB4aikJw7LRcpRhh0JfSgZqznyaql0KU88VvvTg8L4WX/kl4FFRYow4+iyGFIhYjt04ovrjePDuM82JH3S4gT2ZstOOnorQJnZ9IopfcMvzBY7YutARBJQLVe+VB+8a0BCJdQQK29RyFEQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM8PR12MB5431.namprd12.prod.outlook.com (2603:10b6:8:34::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.34; Tue, 23 Jan 2024 14:59:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7202.035; Tue, 23 Jan 2024 14:59:30 +0000 Message-ID: <591812fb-e73d-4e0a-9e6d-eccd549d0b81@amd.com> Date: Tue, 23 Jan 2024 14:59:19 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] drivers/net: return number of types in get supported types Content-Language: en-US To: "Power, Ciara" , "Sivaramakrishnan, VenkatX" , Igor Russkikh , Selwin Sebastian , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , "Zhang, Yuying" , "Xing, Beilei" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , "Su, Simei" , "Wu, Wenjun1" , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , "Zhang, Qi Z" , "Wang, Xiao W" , Jie Hai , Yisen Zhuang , "Wu, Jingjing" , "Yang, Qiming" , "Guo, Junfeng" , Andrew Boyer , Long Li , Matan Azrad , Viacheslav Ovsiienko , Dariusz Sosnowski , Ori Kam , Suanming Mou , Chaoyong He , Jiawen Wu , Harman Kalra , Devendra Singh Rawat , Alok Prasad , Andrew Rybchenko , Jerin Jacob , Maciej Czekaj , Jian Wang , "Behrens, Jochen" , Thomas Monjalon Cc: "dev@dpdk.org" References: <20231212143722.1803259-1-venkatx.sivaramakrishnan@intel.com> <20240118120741.1434286-1-venkatx.sivaramakrishnan@intel.com> <20240118120741.1434286-2-venkatx.sivaramakrishnan@intel.com> <0d66b7f9-5cbd-4fc8-b3c0-b127580a699c@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0195.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM8PR12MB5431:EE_ X-MS-Office365-Filtering-Correlation-Id: 4daf6a2a-8faa-464c-93b4-08dc1c23e702 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hWn91NFhGZavyAS4JJeRYl4C40rabac+XbdIHkk3Lgf+B1kafjqIhY75NLXFdGCPdrj/k1jtxTSERat8llhZpe0kWjzuk7iO/lv0ntwrIXzWYvp6JuLAY+0YXPhsxmZUCeq6x/f0T2VijC7g2xrHpJKCan+HCAZr7ZOVhvizawJ9DnOv8t1FY9CoIuKX77B8QWFK6Y1vIUVW0r51KT9uSTR1X+Con8iqNjGYESz5w3tHU9mqDl1s3aqUvKqBgT8U4Sl4+YEq854Rx/4pe22UJAyY2rXOtALDFhCiVl9NI8am+vjh55c4gUFX0UlgMtE1pcdJKYIIL2uflS3Y5dzFnY7kUuQYpl2tFqF3vjlksNn6/bROa3toCrT9DSvJd2MHDqBe5jQPzrPRouuxs4Ow8h+FmRB1lP9xfRDX9yfl89Yhcstgdvun+TAqDxjLMh2JzVLda4H9KsDDXwaN97zCHxkBgzWUYa2AcHWMi+nBaE8FysaQvgN84XR+bvfGjtpM8iz7bDJ4aC9M0S7PzkIodfd1GD9m2EKZXhCDekR6GKSaUNkWDGPV7qFRblngaDn2HJczClavsucIFxiUXpJwJWTQAj+WOuICmSIFqZxZryVE4Li6L1uaZHd3jhVyk+NAmvLagZ2ygGWQNB7w9/KrNsazUQ6YF+P19mrXTI3iCmA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(136003)(346002)(396003)(39860400002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(31686004)(41300700001)(6486002)(8936002)(5660300002)(2906002)(8676002)(7416002)(7406005)(316002)(110136005)(66946007)(66556008)(66476007)(478600001)(45080400002)(53546011)(26005)(6666004)(6506007)(6512007)(2616005)(44832011)(4326008)(86362001)(83380400001)(1191002)(38100700002)(921011)(31696002)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mk1lV2E5RVNQM0hGalJQc3R3RTlvejRRRUdkWjFIL0Z2dzREakhFa0VNYXE3?= =?utf-8?B?Y1o2QXl0S212Yi92WTRlVC9vaFFSOGkzT0h3OWMxaWNvTlNOLzlvb3BDb01N?= =?utf-8?B?QnFIZGJHYmlQTzdYUXVkb3N1VHZ2dUJlRlUzQmRLcitNdjEvaFhKRC9uREhq?= =?utf-8?B?UkFSZjJWTmsrV3JGMGs5aTZ4Q0g0Tkw0TkoyOG52ZkdlUUZtVlpNZUFTeVlk?= =?utf-8?B?dHpWb0lUa1dBTFVRU29pY1N3YVJrRFhNNDh6TS9kblhhdGVUcU0waXUxWVpW?= =?utf-8?B?QmIxdzdWV2U0RGVyM2NibXMweGpwaGVpSU0xWmJaaEVObDRZQ2pvYmJrdS9V?= =?utf-8?B?MXlWUXlNejF5ZFhrQnlpTncwSW9JZjRPSE1ITFNVcmZCNnBEdmFzYlF2SFFN?= =?utf-8?B?UTB3ajl3dm1EUVAwOWQ4VVlCNXg2TXhuRUdjLzhickgwcFhGbUJyd2lNTEpj?= =?utf-8?B?L0NyYVp0b25qMmFMdll3ekljOVFKMXE2dVJKb2UzZ281eVNrUks2b0puYjZ2?= =?utf-8?B?R3BFQTRUQ09qUEJxcHJUTnVFaGtjQVRoNTNablBTQ3EwalZhTy9SbE9XUXVz?= =?utf-8?B?ekV0Mkx3STJ1YTY4am1taHhZL3ovSHpaMXM2RmxWRnh6ZktLQ1N1V2daakgr?= =?utf-8?B?NVkzYlRnMmtPVld2ZGphSEtrL0l1cmFPSmpiUGVHNi8rWFdIS2Z4SDR6L0hi?= =?utf-8?B?QjIwdHQ1MklwWWJYQVRSajdkMlBiYUUrT3Ziek5WZ2JCbXEvT2VtR0h3REJm?= =?utf-8?B?NlloZHNMbEJaalZjS1AxV1VMcE92WUZ5dzVkenRaa25DTzFyRUtwRkVLT0gy?= =?utf-8?B?L0w5bENpN2xuRXVsU091WGZXYytoeDFXbzVxQWpCRnJwOVRTUlEvMEN3eWwr?= =?utf-8?B?U2tLUzAzNGRPdVhFM21lQytpMGViYTJmbVFoSnZJeWlYdUgvd2RMSXpYbmc2?= =?utf-8?B?NFlJVVRXRDBsa3h4YTR2YnNxRmxRNFJXb2xnWUozU3NrWGFMVTRNVnhkeTNU?= =?utf-8?B?VmY0ZFoxK1Y1T3lnWFBMdWtlUWs0YldBRVNtVHNLV0ltT0k2UTd3eG5Na01w?= =?utf-8?B?T2g3LzRIWHNVbURpWUw5UEc4V3haZm5VTHcwbzZ6OENJSmdPVzh0ZC9IZjNB?= =?utf-8?B?aDBMd2FuQ0F5Q2xTbGtmSDNUK0lBUEZnenFRMERHSWZBc3A4N21wblBoR3ZE?= =?utf-8?B?TXNlSW9WYy9zUEh2ZG8yaXE1NkJtSUxHL09UZmlVcE9vNGdPSW9ISlhUWnZP?= =?utf-8?B?SmFNbFpKQS81RmR0b0xpZ3dWQlJVc3VjNE1GSlV1bjExZjZyWTVkRGhkMGty?= =?utf-8?B?RnFuVlp4YU1YcDJoL2htaXJUWWpHaVkzN2l3dGpZVFBaSTZ1cGMxZmI2b2Ev?= =?utf-8?B?cXFrL0k2dXNlQkg1cDNQbGphVW5vZ1ZabG0rRno3cHVwVk1CTk5uUGF3NmJG?= =?utf-8?B?YVhjOXZya25Od0h1VVNiWVNIN2kvVnpVWkluMVdOYXlXUjEvL0p3d2ZaNXpn?= =?utf-8?B?UkN2TnoxVlJHeE9GSGZENXdFMTh1b1Q3RFMwWTQ4QVJsZnl2V1FvWkNMNFRX?= =?utf-8?B?R2pnUmVaYVBob2w5MXpBRDY4YnBlWCtDWUxWY250MVgvMHVLbGhpWjFPMTRw?= =?utf-8?B?enc0U0h1WlYxby9obHZQNVM1NnNaWEU2RStyOFphbFFDWjV4U0F3Tm5YYTJj?= =?utf-8?B?ZG5oeHJZSjRwZHdndGpyNS9vTHRhZU8zdHRsY2F0alRLVzBmc0NlNC83eThO?= =?utf-8?B?b1Vpclk0dDV4YzNLY1BGcW5kMm8rY1Z3aEptQ3pOVzVUTVdHNTJveER2T1Fl?= =?utf-8?B?TE41YnhWZjJPeGI0OUMvWVpRbVVhWWNMM0ViWEg2alJKdFQ1WlB1ZUFYNVQ0?= =?utf-8?B?M2NNeGN3YWhSeHFVWXlJSkVzYWcvUDZIYWdQOFp3WWhrNEtXbFFyeURRczVF?= =?utf-8?B?V3FmZDdQQTRFd3JiaW42UWh3M0MyRERkblp0cXlkTWhzU2s0TVBQNjRFMTdV?= =?utf-8?B?VGEyemJJcnRlV2syMXYvUnNKaWZzSnVMQU56TFVvWVJQcUJsM2dZcndpcUxu?= =?utf-8?B?ZWpSNEJtZ1RXNUtUUTNzZFRqMnIrMjYwekRiNHZFNmhxa2xKb0ZEU1U4UFZq?= =?utf-8?Q?7WNSVhivtyIlg97zv7hq++AJK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4daf6a2a-8faa-464c-93b4-08dc1c23e702 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 14:59:30.7642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wY2bm2JQKlaV2YB71fboAbhIim+FuOeilCiUZSA3PVmq9nOYraPyyBTiSeXhSg3Z X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5431 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/23/2024 12:07 PM, Power, Ciara wrote: > Hi Ferruh, > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, January 19, 2024 2:51 PM >> To: Sivaramakrishnan, VenkatX ; Igor >> Russkikh ; Selwin Sebastian >> ; Ajit Khaparde >> ; Somnath Kotur >> ; Nithin Dabilpuram >> ; Kiran Kumar K ; >> Sunil Kumar Kori ; Satha Rao >> ; Zhang, Yuying ; Xing, >> Beilei ; Rahul Lakkireddy >> ; Hemant Agrawal >> ; Sachin Saxena ; Su, >> Simei ; Wu, Wenjun1 ; >> Gagandeep Singh ; John Daley ; >> Hyong Youb Kim ; Gaetan Rivet ; >> Zhang, Qi Z ; Wang, Xiao W ; >> Jie Hai ; Yisen Zhuang ; >> Wu, Jingjing ; Yang, Qiming >> ; Guo, Junfeng ; Andrew >> Boyer ; Long Li ; Matan >> Azrad ; Viacheslav Ovsiienko ; >> Dariusz Sosnowski ; Ori Kam ; >> Suanming Mou ; Chaoyong He >> ; Jiawen Wu ; >> Harman Kalra ; Devendra Singh Rawat >> ; Alok Prasad ; Andrew >> Rybchenko ; Jerin Jacob >> ; Maciej Czekaj ; Jian Wang >> ; Behrens, Jochen ; >> Thomas Monjalon >> Cc: dev@dpdk.org; Power, Ciara >> Subject: Re: [PATCH v5 2/2] drivers/net: return number of types in get >> supported types >> >> On 1/18/2024 12:07 PM, Sivaramakrishnan Venkat wrote: >>> Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. >>> Enhance code such that the dev_supported_ptypes_get() function pointer >>> now returns the number of elements to eliminate the need for >>> "RTE_PTYPE_UNKNOWN" as the last item. >>> >>> Signed-off-by: Sivaramakrishnan Venkat >>> >>> >>> -- >>> v5: >>> - modified commit message. >>> - tidied formatting of code. >>> - added doxygen comment. >>> v4: >>> - split into two patches, one for backporting and another one for >>> upstream rework. >>> v3: >>> - reworked the function to return number of elements and remove the >>> need for RTE_PTYPE_UNKNOWN in list. >>> v2: >>> - extended fix for multiple drivers. >>> --- >> >> <...> >> >>> 59 files changed, 188 insertions(+), 141 deletions(-) >>> >> >> Some driver still have the flag: >> - drivers/net/mvneta/mvneta_ethdev.c >> - drivers/net/mvpp2/mrvl_ethdev.c >> - pfe >> - dpaa >> - drivers/net/thunderx/nicvf_ethdev.c >> - drivers/net/nfp/nfp_net_common.c >> >> Above seems the ones updated in previous patch, flags added in previous >> patch should be removed in this one. >> >> >> And following seems missed and still has the flag: >> >> - drivers/net/ngbe/ngbe_ptypes.c >> >> <...> >> >>> @@ -3971,9 +3975,6 @@ rte_eth_dev_set_ptypes(uint16_t port_id, >> uint32_t ptype_mask, >>> } >>> } >>> >>> - if (set_ptypes != NULL && j < num) >>> - set_ptypes[j] = RTE_PTYPE_UNKNOWN; >>> - >>> >> >> This change is new in this version and not mentioned in the changelog. >> >> 'rte_eth_dev_set_ptypes()' returns 'set_ptypes' that terminated with >> 'RTE_PTYPE_UNKNOWN', this is how that API works. >> Why changing it in this patch? > > Apologies, yes, we missed this in the changelog. > > For the change itself, if we are removing the need for RTE_PTYPE_UNKNOWN in the supported ptypes lists to mark the last element, do we still need to add it here when setting ptypes list? > Maybe a misunderstanding on my part - I thought it would be the same for both cases. > > They are two different APIs, and 'rte_eth_dev_set_ptypes()' returns ptypes to user that will be terminated by RTE_PTYPE_UNKNOWN, so to not break the user code we can't change it.