From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 745492BF7
 for <dev@dpdk.org>; Sat, 31 Mar 2018 02:01:23 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 82A9A2115D;
 Fri, 30 Mar 2018 20:01:22 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Fri, 30 Mar 2018 20:01:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=Yzb2VoX9ccjwhU+8lYO0e630Se
 Kf0bqG9C+M3YCdcvM=; b=sQbWz6ZU6j8LThr0sJIsWXdsfyZsceXcY7436Ul4bD
 nxwuhK0CGqye3eBclDIRO0Gh2ITCYOQWa+qXtpyotDsfoADxgUgRsPadp6avlLVk
 7ZB0DNopEQ3cfDmcr5VKWRkbGtqEwUKkKr1oAaCpm5IRJBAyejz4iWu8HAb0h86x
 A=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Yzb2Vo
 X9ccjwhU+8lYO0e630SeKf0bqG9C+M3YCdcvM=; b=hCIM8LYpBDeZx/xifqlzoC
 N5YXOq4ekB3YE3y13Y9J3RNJFenDJLWFSRR5jltqulIoS2jW+WnKK5VeMtZ070sA
 BkohQhaxPYOIbMIcjSrbOgmWzhgWoEraxCJIdCCqGKMoPLY5Zuqik61GgH4uIAj5
 QsjwX87kKl03vST2ZxF9E4emlnyTDntIkVXmoU5L7xStgqc5Z/QvxX4JdUZ39aPi
 0xZnkOq7BdQHBsRXeI9nyb2BunKz3SgBDW6COJjkE+pKBL24Uc+RaTbi8+qY4uGo
 /RUrSVHmfcK+SyDDqheKFo3NzRP4G67F9CFAQu/UW2Igz1VGjQh4K0b01teYAjtA
 ==
X-ME-Sender: <xms:0s--WjFr_4Wa0SlVdtkgNhT4FP-BbxhRlWaqRiR3if8iuE89yJYsoA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 7A07210255;
 Fri, 30 Mar 2018 20:01:21 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>
Date: Sat, 31 Mar 2018 02:01:05 +0200
Message-ID: <5922778.WOJhgh4gTO@xps>
In-Reply-To: <20180321142749.27520-5-remy.horton@intel.com>
References: <20180321142749.27520-1-remy.horton@intel.com>
 <20180321142749.27520-5-remy.horton@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx
	parameters
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Mar 2018 00:01:23 -0000

21/03/2018 15:27, Remy Horton:
>  /*
>   * Configurable number of RX/TX ring descriptors.

Configurable, really?

> + * Defaults are supplied by drivers via ethdev.

And fallback values are in ethdev.

>   */
> -#define RTE_TEST_RX_DESC_DEFAULT 1024
> -#define RTE_TEST_TX_DESC_DEFAULT 1024
> +#define RTE_TEST_RX_DESC_DEFAULT 0
> +#define RTE_TEST_TX_DESC_DEFAULT 0

We do not need a define for 0.
Better to rework a bit above and below comments.

>  uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; /**< Number of RX descriptors. */
>  uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; /**< Number of TX descriptors. */

These doxygen comments in the middle of the code are totally useless.