From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id B82FDA0096
	for <public@inbox.dpdk.org>; Tue,  4 Jun 2019 17:23:47 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id AA1321BB86;
	Tue,  4 Jun 2019 17:23:46 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 6D7571BAA8;
 Tue,  4 Jun 2019 17:23:45 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id ADA31356FF;
 Tue,  4 Jun 2019 15:23:39 +0000 (UTC)
Received: from [10.36.117.226] (ovpn-117-226.ams2.redhat.com [10.36.117.226])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 0D24060BC3;
 Tue,  4 Jun 2019 15:23:37 +0000 (UTC)
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, Yongseok Koh <yskoh@mellanox.com>
Cc: stable@dpdk.org, michael.luo@intel.com, dev@dpdk.org
References: <1558929727-56647-1-git-send-email-michael.luo@intel.com>
 <1986574.YHl94pmo8i@xps> <2e6a3472-03d8-bc4f-6345-e02faca89645@intel.com>
From: Kevin Traynor <ktraynor@redhat.com>
Message-ID: <5925cca9-be86-7369-cb4b-407635cf76e5@redhat.com>
Date: Tue, 4 Jun 2019 16:23:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <2e6a3472-03d8-bc4f-6345-e02faca89645@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.30]); Tue, 04 Jun 2019 15:23:44 +0000 (UTC)
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix build on RHEL8
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 04/06/2019 16:00, Ferruh Yigit wrote:
> On 5/29/2019 10:48 PM, Thomas Monjalon wrote:
>> 27/05/2019 06:02, michael.luo@intel.com:
>>> From: Luo Gaoliang <michael.luo@intel.com>
>>>
>>> Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>>>
>>> Build error log:
>>> /root/kni/dpdk-19.05/kernel/linux/kni/ethtool/igb/kcompat.h:3928:25:
>>> error: 'const struct net_device_ops' has no member named 'extended'
>>>  #define ndo_set_vf_vlan extended.ndo_set_vf_vlan
>>>                          ^~~~~~~~
>>
>> This module has been removed from DPDK:
>> 	http://git.dpdk.org/dpdk/commit/?id=ea6b39b5b84
>>
>> Do we want to apply this patch directly in older releases (LTS)?
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> stable mail list already in the cc, but
> 
> Kevin, Yongsek,
> This patch won't be in the master repo, is there anything needs to be done to
> include the patch in LTS, or is this mail sufficient?
> 

Hi Ferruh, this mail is enough, will note it.

thanks,
Kevin.

> Thanks,
> ferruh
>