From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 1F69F4C8F for ; Mon, 11 Mar 2019 16:53:33 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 74CC44C0072; Mon, 11 Mar 2019 15:53:31 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Mar 2019 15:53:24 +0000 To: David Marchand , CC: , , , References: <1550158972-21895-1-git-send-email-david.marchand@redhat.com> <1552318522-18777-1-git-send-email-david.marchand@redhat.com> <1552318522-18777-3-git-send-email-david.marchand@redhat.com> From: Andrew Rybchenko Message-ID: <59347eba-5a0b-8933-4199-71020c35143b@solarflare.com> Date: Mon, 11 Mar 2019 18:53:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1552318522-18777-3-git-send-email-david.marchand@redhat.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24482.004 X-TM-AS-Result: No-13.197900-8.000000-10 X-TMASE-MatchedRID: 6otD/cJAac12LasmHuCXMSa1MaKuob8PC/ExpXrHizyzrjcceM7LC7p6 uNXZtNFnGiHcq0WQFE4tXweg2cv0t9LDec/x7CA8Z1f+XQd5zc/hwsEcDDUFFlxTR00Ss4P6ilv Ab18i4hMzAiHUi8j73eHYtAALsoaBZvjinbSBPqHuykw7cfAoICHAogh2SU5XXCmcAC8DBrMAvo VwPlG+DqRGASDuetHK660+DqvfilOCIg7tJ//usTTR2TFg0xG3ifgN14P+4s3Dv5dDcuT2eRqGc 7het5hm5FG8mnmnbWO3QVvAJGcE1/z/jVa2JSBDBxsweNg3EaGFkCkkB0UMNpsoi2XrUn/JyeMt MD9QOgChMIDkR/KfwCIQ5mZ5SqHPy9i+1xMMqcWBPFhgLUGQ7UzjZtsFRE4+hHhQ/19DbdmM9o3 rJkyCBOVwMCICOwktf4OU/YuvkpwaWWh86UXMQ8cFGZK0zeEAYDttQUGqHZU= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--13.197900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24482.004 X-MDID: 1552319612-PjZPmnEyDCBV Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 2/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 15:53:33 -0000 On 3/11/19 6:35 PM, David Marchand wrote: > Having the standard stats and the rx burst stats on the same line gives a > really long line and is not consistent with the rest. > > Before: > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > After: > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > Signed-off-by: David Marchand > Reviewed-by: Rami Rosen > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 98c1baa..984155a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1459,7 +1459,7 @@ struct extmem_param { > "TX Port=%2d/Queue=%2d %s\n", > fwd_top_stats_border, fs->rx_port, fs->rx_queue, > fs->tx_port, fs->tx_queue, fwd_top_stats_border); > - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u", > + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n", > fs->rx_packets, fs->tx_packets, fs->fwd_dropped); > > /* if checksum mode */ I'd suggest to add Fixes tag since it looks like a bug Rx burst stats should be printed on its own line regardless Rx checksum stats printed or skipped. Fixes: af75078fece3 ("first public release") Andrew.