From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A87F45915; Fri, 6 Sep 2024 02:59:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E68104025D; Fri, 6 Sep 2024 02:59:45 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id D00904025C for ; Fri, 6 Sep 2024 02:59:42 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4X0Hpw5qr8z1HJ8w; Fri, 6 Sep 2024 08:56:08 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 0F47414037D; Fri, 6 Sep 2024 08:59:38 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 6 Sep 2024 08:59:37 +0800 Subject: Re: [PATCH v4 0/6] refine argparse library From: fengchengwen To: , CC: , Jie Hai , Dengdui Huang References: <20240220131502.47510-1-fengchengwen@huawei.com> <20240318111838.16991-1-fengchengwen@huawei.com> Message-ID: <59413e6c-8e07-5d88-3bea-138615881e5d@huawei.com> Date: Fri, 6 Sep 2024 08:59:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas and David, This patchset is good enhance for argparse library, we hope it could upstream to DPDK 24.11. Please look at it. Thanks On 2024/7/4 11:07, fengchengwen wrote: > Kindly ping. > > Best regards, > Chengwen Feng > > On 2024/3/18 19:18, Chengwen Feng wrote: >> I found a couple of issues when I revisited the argparse_autotest >> output, so got this patchset. >> >> Chengwen Feng (6): >> argparse: refine error message >> argparse: remove dead code >> argparse: replace flag enum with marco >> argparse: fix argument flags operate as uint32 type >> test/argparse: refine testcases >> argparse: fix doc don't display two hyphens >> >> --- >> v4: address Thomas's comment on 4/6 commit: >> - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and >> TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. >> v3: >> - address Thomas's comment on 4/6 comit. >> - add commit: fix doc don't display two hyphens. >> v2: address David Marchand's comment: >> - replace flag enum with marco. >> - replace flag's hardcode with macro in test_argparse.c. >> >> app/test/test_argparse.c | 65 +++++++++++--------- >> doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- >> lib/argparse/rte_argparse.c | 61 +++++++++--------- >> lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- >> 4 files changed, 127 insertions(+), 131 deletions(-) >> > . >