From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 15E062C6D; Wed, 24 Apr 2019 03:13:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 18:13:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,387,1549958400"; d="scan'208";a="340200074" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 23 Apr 2019 18:13:44 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 23 Apr 2019 18:13:44 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.25]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0415.000; Wed, 24 Apr 2019 09:13:42 +0800 From: "Pei, Andy" To: Thomas Monjalon CC: "Xu, Rosen" , "stable@dpdk.org" , "dev@dpdk.org" , "Kovacevic, Marko" , "liq3ea@163.com" Thread-Topic: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr Thread-Index: AQHU+TQrsiKyHWiccUeFrB7zp9m+y6ZI8kywgAB9HRiAARO2YA== Date: Wed, 24 Apr 2019 01:13:42 +0000 Message-ID: <5941F446C088714A85408FA3132CFCBB0100BAEB@SHSMSX105.ccr.corp.intel.com> References: <1555483757-48188-1-git-send-email-andy.pei@intel.com> <5941F446C088714A85408FA3132CFCBB0100B26D@SHSMSX105.ccr.corp.intel.com> <0E78D399C70DA940A335608C6ED296D73A6CE8A2@SHSMSX104.ccr.corp.intel.com> <2416997.dOrgfSpHr6@xps> In-Reply-To: <2416997.dOrgfSpHr6@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2019 01:13:47 -0000 Hi, I saw Qiang's patch on patchwork today, [v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr So I think it seems OK to ignore my patch. -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net]=20 Sent: Tuesday, April 23, 2019 4:45 PM To: Pei, Andy Cc: Xu, Rosen ; stable@dpdk.org; dev@dpdk.org; Kovacevi= c, Marko ; liq3ea@163.com Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte = fpga do pr When you need to re-send a patch, please apply it with "git am" so the original author is kept. Another nit: the title is full of abbreviation, it is hard to read. The title prefix should be "raw/ifpga", even if checkpatch complains. Please re-send, thanks. 23/04/2019 03:36, Xu, Rosen: > Hi Thomas, >=20 > Qian has some problem with his email. So some patch can't be found in pat= ch work. > For it's a urgent bug. After we have aligned with Qian, Andy send this pa= tch. Thanks. >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, April 23, 2019 9:19 > > To: Thomas Monjalon ; Xu, Rosen=20 > > > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko=20 > > ; liq3ea@163.com > > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak=20 > > in rte fpga do pr > >=20 > > Hi Thomas, > >=20 > > My patch is the same as LI Qiang's patch. > > I was told that Qiang's patch cannot get onto the patchwork, so I=20 > > just help him do this. > >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Tuesday, April 23, 2019 1:52 AM > > To: Xu, Rosen ; Pei, Andy > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko=20 > > ; liq3ea@163.com > > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak=20 > > in rte fpga do pr > >=20 > > > > In rte_fpga_do_pr() function, if 'stat' returns error, > > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd'=20 > > > > that has been opened. > > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr()=20 > > > > returns -EINVAL when 'stat' returns error > > > > > > > > Coverity issue: 279441 > > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev=20 > > > > driver") > > > > Cc: rosen.xu@intel.com > > > > Cc: marko.kovacevic@intel.com > > > > Cc: liq3ea@163.com > > > > Cc: andy.pei@intel.com > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Andy Pei > > > > > > Acked-by: Rosen Xu > >=20 > > Li Qiang proposed the same patch. > > Why he is not referenced here? > > Which patch should I merge? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5D6CBA05D3 for ; Wed, 24 Apr 2019 03:13:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 248CA324D; Wed, 24 Apr 2019 03:13:49 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 15E062C6D; Wed, 24 Apr 2019 03:13:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 18:13:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,387,1549958400"; d="scan'208";a="340200074" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 23 Apr 2019 18:13:44 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 23 Apr 2019 18:13:44 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.25]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0415.000; Wed, 24 Apr 2019 09:13:42 +0800 From: "Pei, Andy" To: Thomas Monjalon CC: "Xu, Rosen" , "stable@dpdk.org" , "dev@dpdk.org" , "Kovacevic, Marko" , "liq3ea@163.com" Thread-Topic: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr Thread-Index: AQHU+TQrsiKyHWiccUeFrB7zp9m+y6ZI8kywgAB9HRiAARO2YA== Date: Wed, 24 Apr 2019 01:13:42 +0000 Message-ID: <5941F446C088714A85408FA3132CFCBB0100BAEB@SHSMSX105.ccr.corp.intel.com> References: <1555483757-48188-1-git-send-email-andy.pei@intel.com> <5941F446C088714A85408FA3132CFCBB0100B26D@SHSMSX105.ccr.corp.intel.com> <0E78D399C70DA940A335608C6ED296D73A6CE8A2@SHSMSX104.ccr.corp.intel.com> <2416997.dOrgfSpHr6@xps> In-Reply-To: <2416997.dOrgfSpHr6@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190424011342.GGbOSqnej2B1dUbNiJxVtPfj5jIETU_1uLagiEHt49Y@z> Hi, I saw Qiang's patch on patchwork today, [v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr So I think it seems OK to ignore my patch. -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net]=20 Sent: Tuesday, April 23, 2019 4:45 PM To: Pei, Andy Cc: Xu, Rosen ; stable@dpdk.org; dev@dpdk.org; Kovacevi= c, Marko ; liq3ea@163.com Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte = fpga do pr When you need to re-send a patch, please apply it with "git am" so the original author is kept. Another nit: the title is full of abbreviation, it is hard to read. The title prefix should be "raw/ifpga", even if checkpatch complains. Please re-send, thanks. 23/04/2019 03:36, Xu, Rosen: > Hi Thomas, >=20 > Qian has some problem with his email. So some patch can't be found in pat= ch work. > For it's a urgent bug. After we have aligned with Qian, Andy send this pa= tch. Thanks. >=20 > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, April 23, 2019 9:19 > > To: Thomas Monjalon ; Xu, Rosen=20 > > > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko=20 > > ; liq3ea@163.com > > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak=20 > > in rte fpga do pr > >=20 > > Hi Thomas, > >=20 > > My patch is the same as LI Qiang's patch. > > I was told that Qiang's patch cannot get onto the patchwork, so I=20 > > just help him do this. > >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Tuesday, April 23, 2019 1:52 AM > > To: Xu, Rosen ; Pei, Andy > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko=20 > > ; liq3ea@163.com > > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak=20 > > in rte fpga do pr > >=20 > > > > In rte_fpga_do_pr() function, if 'stat' returns error, > > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd'=20 > > > > that has been opened. > > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr()=20 > > > > returns -EINVAL when 'stat' returns error > > > > > > > > Coverity issue: 279441 > > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev=20 > > > > driver") > > > > Cc: rosen.xu@intel.com > > > > Cc: marko.kovacevic@intel.com > > > > Cc: liq3ea@163.com > > > > Cc: andy.pei@intel.com > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Andy Pei > > > > > > Acked-by: Rosen Xu > >=20 > > Li Qiang proposed the same patch. > > Why he is not referenced here? > > Which patch should I merge?