From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7396A0A02; Wed, 24 Mar 2021 12:30:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 556DB4067B; Wed, 24 Mar 2021 12:30:44 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 2B85E4014F for ; Wed, 24 Mar 2021 12:30:42 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 99F2F109C; Wed, 24 Mar 2021 07:30:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 24 Mar 2021 07:30:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Jlw9EqIAfRYdFzDpNYTUpB2/J//ChUQbzNNdl1pVcP4=; b=D7JIp0v+FChQfyff Z/pITmcu8AldO4tCpbl0CcNDPk5vGXiGANAHJ7veumTzFmtiSFEmNOGJYWRrt49O A7Q5EY10VGAQ06TKGiMvQsnsj/JALYekXS0NruJCEI2N60+CgbjDWoNgarwUnEyt j+ibQj65+vA9YGIdVma9Vk/URBiV/RMJdyFtwWzxl0uxmR5wQzT3sIj98JJrVCp2 IPlB1se1xJY7tjwzJrOndv/7GFXbLkIvEKw9MNbMxaw4aLZPC2vJwXYQuaSpk8yt oOGvtG4NBD4th0f6d4ISeHdr3fE0eMbgf17j+yja7ouKlDIATz5YgM3FCeAtsUrr U97azw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Jlw9EqIAfRYdFzDpNYTUpB2/J//ChUQbzNNdl1pVc P4=; b=r/P9qfWkB/628DKfNa/jHX+1CWIpxXX/lZcyG3CYAL9Xk3mGRzygXO+N3 FuyNPAHbOtZdisXbHNTUcxKE+xICucNxoGHpipPDJImzaMtol9nzDFqNrniepK3D oCCQLJBD8aVvP27JxrCaxVOrcccPsw6H+FXiVT0pyg5O3YNVD9z5+6lGBKSmySIA +5OuSiVfNpaAk2jEislIMdJ6Bl9s2r+wfR9/uOVdmDiRDw9KnXLJ8h9U9uM4pHfB QsEs4efpriRaBUrzN3LqvBgmiXXnIjVbi1pDrc1of2s3aHfIWYLmdTMb8qbv4VTh +L0o+RvCpFYQMk0sk2EzYXzUXqDAw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegkedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 93364240426; Wed, 24 Mar 2021 07:30:38 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Tyler Retzlaff , dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, Shepard Siegel , David Marchand Date: Wed, 24 Mar 2021 12:30:36 +0100 Message-ID: <5945384.p3lA8Brad8@thomas> In-Reply-To: <7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com> References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/03/2021 12:27, Ferruh Yigit: > On 3/24/2021 4:32 AM, Tyler Retzlaff wrote: > > On Tue, Mar 23, 2021 at 05:04:08PM +0000, Ferruh Yigit wrote: > >>> diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build > >>> index c37b2e377..4353fa6b7 100644 > >>> --- a/lib/librte_ethdev/meson.build > >>> +++ b/lib/librte_ethdev/meson.build > >>> @@ -20,8 +20,14 @@ headers = files('rte_ethdev.h', > >>> 'rte_mtr_driver.h', > >>> 'rte_tm.h', > >>> 'rte_tm_driver.h') > >>> + > >>> indirect_headers += files( > >>> 'rte_ethdev_core.h', > >>> 'rte_eth_ctrl.h') > >>> +driver_sdk_headers += files( > >>> + 'ethdev_driver.h', > >>> + 'ethdev_pci.h', > >>> + 'ethdev_vdev.h') > >>> + > >>> deps += ['net', 'kvargs', 'meter', 'telemetry'] > >> > > > > i feel like i missed a reply here. but just to clarify only ethdev will > > be covered by this patch. inclusion of other driver headers was > > discussed off list (sorry) and it emerged that it would result in > > withdraw a number of driver api/abi that had not been marked as > > __rte_internal. > > > > for driver api that were being exported as 'stable' a deprecation notice > > will need to be issued in order to make them part of the > > driver_sdk_headers. for that reason only ethdev is being made available > > under this option for now. > > > > please ack/nack the patch as-is > > > > I am OK the patch for the ethdev part, hence > Acked-by: Ferruh Yigit > > > But not sure how to manage the same problem for whole project, if install all > headers in one patch, or add them gradually via separate patches by time ... We did a cleanup in ethdev but not in other driver classes. When the cleanup will be done gradually, the headers must move in this new category driver_sdk_headers.