From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D77542DAF; Mon, 3 Jul 2023 13:51:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B70340EF0; Mon, 3 Jul 2023 13:51:20 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id F1A3240ED5 for ; Mon, 3 Jul 2023 13:51:18 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9FEE05C0046; Mon, 3 Jul 2023 07:51:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 03 Jul 2023 07:51:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688385078; x=1688471478; bh=9D6m/qFLwVBC6/P3kfPuxLEwB6aJ89KBcO4 4WUtaX2M=; b=EInIIQEiGJbGw3ETJXUre3d6vMTovDQdznhu/FvSLW23fR8OEys UdzYcT+KUzrZ+8ym7KqZmgiVDQmmlEGgjtyeHZA2sxkw1n9IP0/ZFx5kYsF7JKb6 9JjbwzEAYq8EdOeq3lOeHjHfwNNWfvWsH7mp+v/xCZ+Gbq8hDHnFhnkTKBmXUHmG /tyZyyQyJBaMAzfOXeOv18ei+8Qu70s4gk1jndKL4bHhuJtkNytY7UmnDWCyW+8v Jw1s/0J/mNySisz2k89CSUwfzZxCgelOPAn2RVd4k1+l+ThS1h8RvEaFA264O97+ nXcrCyevyH3k97/HQZS1islJS7F5mp+3Jxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1688385078; x=1688471478; bh=9D6m/qFLwVBC6/P3kfPuxLEwB6aJ89KBcO4 4WUtaX2M=; b=R2th4RsbxzsdkSSmGjehrCPg5ggSYRxAPDDLKTSBRLsXdeHsdoJ 4GRCd9GNEe8pZJJcx/pv93hXPFcr0cao7/54hN/mhDgDztaRSu5pXmm+mHuOeQuU LpvP63X+YB8hm9owO3FwpYHETTxGNqhMbSIEbSxSzdP6uQ2NYqdPnipeo8Y16SO8 5xoarZtVWrfE6EAdkfaEMEVdJ7F6PJB2Hflc/Tddfz6qsL/HJrNdIs/9VwyTEQKg 0yQHaINT3rVJ2cwpHd+xkedkQHJVLWUPX0EEWEVa2y1ZXAsS1r0q39evf6MQ9r0l mk3b9pSivU8fBQOVD67ETAxIvMZiTXXvRGQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Jul 2023 07:51:17 -0400 (EDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , Volodymyr Fialko Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Anoob Joseph Subject: Re: [PATCH v3] bitmap: add scan from offset function Date: Mon, 03 Jul 2023 13:51:15 +0200 Message-ID: <5946701.lOV4Wx5bFT@thomas> In-Reply-To: References: <20230613154013.2648333-1-vfialko@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/07/2023 12:56, Volodymyr Fialko: > Since it's header-only library, there is issue with using __rte_intenal (appeared in v4). What is the issue? > Even if the function itself is not used directly, it get's included to the other public files. > It explains why other functions in this library does not have the rte_internal prefix, but the double underscores. > So, should I simply remove __rte_internal from v4, or there's another approach to resolve this issue(beside creating .c file)? > > /Volodymyr > > > -----Original Message----- > > From: Dumitrescu, Cristian > > Sent: Friday, June 23, 2023 2:41 PM > > To: Thomas Monjalon ; Volodymyr Fialko > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Anoob Joseph > > > > Subject: [EXT] RE: [PATCH v3] bitmap: add scan from offset function > > > > External Email > > > > ---------------------------------------------------------------------- > > > > > > > -----Original Message----- > > > From: Thomas Monjalon > > > Sent: Thursday, June 22, 2023 6:45 PM > > > To: Volodymyr Fialko > > > Cc: dev@dpdk.org; Dumitrescu, Cristian > > > ; jerinj@marvell.com; > > > anoobj@marvell.com > > > Subject: Re: [PATCH v3] bitmap: add scan from offset function > > > > > > 21/06/2023 12:01, Volodymyr Fialko: > > > > Currently, in the case when we search for a bit set after a > > > > particular value, the bitmap has to be scanned from the beginning > > > > and > > > > rte_bitmap_scan() has to be called multiple times until we hit the value. > > > > > > > > Add a new rte_bitmap_scan_from_offset() function to initialize scan > > > > state at the given offset and perform scan, this will allow getting > > > > the next set bit after certain offset within one scan call. > > > > > > > > Signed-off-by: Volodymyr Fialko > > > > --- > > > > v2: > > > > - added rte_bitmap_scan_from_offset > > > > v3 > > > > - added note for internal use only for init_at function > > > [...] > > > > +/** > > > > + * @warning > > > > + * @b EXPERIMENTAL: this API may change without prior notice. > > > > + * > > > > + * Bitmap initialize internal scan pointers at the given position > > > > +for the scan > > > function. > > > > + * > > > > + * Note: for private/internal use, for public: > > > > + * @see rte_bitmap_scan_from_offset() > > > > + * > > > > + * @param bmp > > > > + * Handle to bitmap instance > > > > + * @param pos > > > > + * Bit position to start scan > > > > + */ > > > > +__rte_experimental > > > > +static inline void > > > > +__rte_bitmap_scan_init_at(struct rte_bitmap *bmp, uint32_t pos) > > > > > > I think it should marked with __rte_internal instead of experimental. > > > > > > > > > > > > +1 >