* [dpdk-dev] [PATCH] hash: Correctly set the compare function.
@ 2016-09-17 9:43 Masoud Hasanifard
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
0 siblings, 1 reply; 4+ messages in thread
From: Masoud Hasanifard @ 2016-09-17 9:43 UTC (permalink / raw)
To: dev; +Cc: Masoud Hasanifard
Set cmp_jump_table_idx to KEY_CUSTOM in rte_hash_cmp_eq so that the custom
function we are setting in rte_hash_set_cmp_func properly works. The custom
function is only called by rte_hash_cmp_eq if cmp_jump_table_idx is set to
KEY_CUSTOM.
---
lib/librte_hash/rte_cuckoo_hash.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c
index 26e54f6..2e6429f 100644
--- a/lib/librte_hash/rte_cuckoo_hash.c
+++ b/lib/librte_hash/rte_cuckoo_hash.c
@@ -98,6 +98,7 @@ rte_hash_find_existing(const char *name)
void rte_hash_set_cmp_func(struct rte_hash *h, rte_hash_cmp_eq_t func)
{
+ h->cmp_jump_table_idx = KEY_CUSTOM;
h->rte_hash_custom_cmp_eq = func;
}
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
@ 2016-09-21 21:29 ` Thomas Monjalon
2016-09-21 21:30 ` De Lara Guarch, Pablo
2016-09-22 15:42 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2016-09-21 21:29 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev, Masoud Hasanifard
2016-09-19 18:36, De Lara Guarch, Pablo:
> Commit titles start with lowercase ("correctly") and without a dot at the end.
[...]
> I think this is a fix, so probably it should contain the following "Fixes" line in the commit message:
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
[...]
> Good catch! Two comments inline.
> Could you send a v2 with those two things added?
I can do these trivial changes when applying.
Pablo, do you ack?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
2016-09-21 21:29 ` Thomas Monjalon
@ 2016-09-21 21:30 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2016-09-21 21:30 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Masoud Hasanifard
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, September 21, 2016 2:29 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Masoud Hasanifard
> Subject: Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
>
> 2016-09-19 18:36, De Lara Guarch, Pablo:
> > Commit titles start with lowercase ("correctly") and without a dot at the
> end.
> [...]
> > I think this is a fix, so probably it should contain the following "Fixes" line in
> the commit message:
> > Fixes: 95da2f8e9c61 ("hash: customize compare function")
> [...]
> > Good catch! Two comments inline.
> > Could you send a v2 with those two things added?
>
> I can do these trivial changes when applying.
> Pablo, do you ack?
I do!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
2016-09-21 21:29 ` Thomas Monjalon
@ 2016-09-22 15:42 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-09-22 15:42 UTC (permalink / raw)
To: Masoud Hasanifard; +Cc: dev, De Lara Guarch, Pablo
2016-09-19 18:36, De Lara Guarch, Pablo:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Masoud
> Commit titles start with lowercase ("correctly") and without a dot at the end.
> >
> > Set cmp_jump_table_idx to KEY_CUSTOM in rte_hash_cmp_eq so that the
> > custom
> > function we are setting in rte_hash_set_cmp_func properly works. The
> > custom
> > function is only called by rte_hash_cmp_eq if cmp_jump_table_idx is set to
> > KEY_CUSTOM.
>
> I think this is a fix, so probably it should contain the following "Fixes" line in the commit message:
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
[...]
> Good catch! Two comments inline.
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-22 15:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-17 9:43 [dpdk-dev] [PATCH] hash: Correctly set the compare function Masoud Hasanifard
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
2016-09-21 21:29 ` Thomas Monjalon
2016-09-21 21:30 ` De Lara Guarch, Pablo
2016-09-22 15:42 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).