From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 1600F2B96 for ; Thu, 22 Sep 2016 17:42:57 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id l132so335069245wmf.0 for ; Thu, 22 Sep 2016 08:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=AbKuY3AxQLp8Nb3ADhhUYqdy0eJvB362s+ZicVSgUTU=; b=i9tuB0q0GNA0cCv8dxPG9Hwpq+jSOMzRDMn9xCAMbMJiV1TwLHqkPLFQ9N+rDcSVq1 3Z28edylXp4deU9oWrC5eVwvqahP6M/G4hyeAK0wrJ3+YGuCGd4MEvhQGfWF5kpTkREv MxduzslqINLSq0Zzhk3PfjFiCFZ+kfOoPIKlxmfA0hGAJAKvWBBI012luytuYrU5hi2i E+qAZmWrVCP12wi97vzJRZumS39g80BOiw8s86PW50nSb4ssy+EbqL+qWq3nmM4xnG2f pDTre53Wpel+i2odurWGIQtVgh2iHBJIn4deXRmCtJBd8j7mF+IAm+LNWsxHPjiGOIcC dVCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=AbKuY3AxQLp8Nb3ADhhUYqdy0eJvB362s+ZicVSgUTU=; b=IHukjm9ElBE6qTsgl/xPHAZHMdUyGCzebVddkqSFejnaaVE3b41dQQLzEdkXJ/Dg1O gvZRSUKCdihay0x6oth+WdchCt59lkJbtsXlP+DmIsEI90dyEGn/S5wb2yUzkmY2Lynp USfaUR9qgyM+wW7WLHlhprCmgih16DdakKfZ2jnx1qc6K9LrxYJqe9If4GaisdEYmmtk J2r5j8WtI1u88hrPoBLKCoT/DMBpd2I4Uq+WOz3nAczan3fS2/4CGPqjsjih9PsaefDb WvvkMUbQleRFR9CU21OK3k5WkMcePArevWK2ejpeQtlrZaXfT2k9447WQ0PKd2RyNSeX bIrA== X-Gm-Message-State: AE9vXwMbLt/1JDlOVdLdudMDpHBq/JHElF0TI8JKIWL7i0kPdpod/wnzMIqXh3Ewh3iJ9XIj X-Received: by 10.28.138.205 with SMTP id m196mr9520773wmd.44.1474558976855; Thu, 22 Sep 2016 08:42:56 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id q10sm3115823wme.6.2016.09.22.08.42.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Sep 2016 08:42:56 -0700 (PDT) From: Thomas Monjalon To: Masoud Hasanifard Cc: dev@dpdk.org, "De Lara Guarch, Pablo" Date: Thu, 22 Sep 2016 17:42:55 +0200 Message-ID: <5960468.PdAfGihvNv@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1474105404-27654-1-git-send-email-masoudhasanifard@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 15:42:57 -0000 2016-09-19 18:36, De Lara Guarch, Pablo: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Masoud > Commit titles start with lowercase ("correctly") and without a dot at the end. > > > > Set cmp_jump_table_idx to KEY_CUSTOM in rte_hash_cmp_eq so that the > > custom > > function we are setting in rte_hash_set_cmp_func properly works. The > > custom > > function is only called by rte_hash_cmp_eq if cmp_jump_table_idx is set to > > KEY_CUSTOM. > > I think this is a fix, so probably it should contain the following "Fixes" line in the commit message: > Fixes: 95da2f8e9c61 ("hash: customize compare function") [...] > Good catch! Two comments inline. Applied, thanks