From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 095F64334D; Fri, 17 Nov 2023 07:55:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC8A4402CB; Fri, 17 Nov 2023 07:55:29 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2041.outbound.protection.outlook.com [40.107.93.41]) by mails.dpdk.org (Postfix) with ESMTP id 45AE940271 for ; Fri, 17 Nov 2023 07:55:28 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVxyT4AFn93ecP3c3YkuBY5JNTd38+5N85292cuymwESAuJN/j8R0oh0Pmmb/IvvLrtbmtiGiS7XTMNVcRsKpIRyai/yF52Du8V5mSVp5hK7HZG96iQ8pL41GX+7wC2Tj3M/1OObdwgau9BocNSyr8R9hw+SbnO7W5etBKjoxw/d0/Ivj07r8JGvyy4tvGa3VQrY4dHCU3+EUMWX7zMgBoHl1EC9JyGYQ3P8eEEcsAFo/ddloIhp6uVfYYtkgZ81dZld1OPAJDvzfA2T2yw29ITfNOy4Kab2fhnYls+Gf9v/0i0LHzkuVi2c8LdU9Fe86ToeuNb6PRyKz6wcfGGBBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w9kEh6r1KDcpohkCcpZSCBBOkqsZkSQUHo+AiBwRxFk=; b=I0HYWHCF6ek9wZNDEZUc8SIxuhV1rTTzM1mFG6Gb9RYP6ySKG0K60rd1nXNvPwb10YuG3cXoCxn4yYuSBLfBEv2UK/TkSOS4xNw1N03jtDOCBwbRagC51ykoPBMgE7v09z+kLVqFzqv+Y4e5d/PomrgGGgSimqxTflKwBVuzcF5G9iSp/0DcEJ2HVKgTodK86RYY3F1zDvZs14AV5CLDRGN4ZDTnv1J2+Zsk3VG7yVCTsZF/kDk7ftk2DjSN58lNM0CY4+4RRdSG4oevyI+AHtsD4fb/OKK9gpjLaJjixUi289ggkTgKGbfNBLYudOm9dncbyUvRlGu8Al+E72Q1tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w9kEh6r1KDcpohkCcpZSCBBOkqsZkSQUHo+AiBwRxFk=; b=n8aMgy4IOa+jPMOy0dTALbNxlqQ7Ghl9yeT4tQe2q+z/reh+gXrQLETgVjN17Ds81YggFGOBFFWCiB2OYo2jHARx2sgn7v3IbCynOy4VrI/OV/i0F/vqUS46HqSiVcP8Z+Lq5zeBdgFCt18gmSeKUxmls6x9Y1ERPOMR+TqIOGpDHmmAROYE5tX1IvXlg+LfffVxm0T33GkyQa6NYm0LJJ+storxc83hTniq7J77CLQ5D8CDKJ/X7DCbQdsRvziXqBJs5zbaE4FzXQo+Vv5Geg8nouk8K/pvzN93N+qTW4ZQeGJ1ZYwJX6c5QAFaqJ4sWKmGMv+OQNdlJRd+frdrpQ== Received: from MN0PR12MB6341.namprd12.prod.outlook.com (2603:10b6:208:3c2::13) by BL1PR12MB5352.namprd12.prod.outlook.com (2603:10b6:208:314::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov 2023 06:55:24 +0000 Received: from MN0PR12MB6341.namprd12.prod.outlook.com ([fe80::87c1:7938:fd9e:e088]) by MN0PR12MB6341.namprd12.prod.outlook.com ([fe80::87c1:7938:fd9e:e088%3]) with mapi id 15.20.7002.021; Fri, 17 Nov 2023 06:55:24 +0000 From: Chenbo Xia To: Abdullah Sevincer CC: "dev@dpdk.org" , "jerinj@marvell.com" , "mike.ximing.chen@intel.com" , "bruce.richardson@intel.com" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , David Marchand , "nipun.gupta@amd.com" Subject: Re: [PATCH v2] bus/pci: revise support PASID control Thread-Topic: [PATCH v2] bus/pci: revise support PASID control Thread-Index: AQHaFyESAyQGq+CSukC0mjIMZYEUBbB+F8MA Date: Fri, 17 Nov 2023 06:55:24 +0000 Message-ID: <5960A21E-7108-4659-A0C1-9C610E4A5377@nvidia.com> References: <20231113172759.3529518-1-abdullah.sevincer@intel.com> <20231114173609.3590237-1-abdullah.sevincer@intel.com> In-Reply-To: <20231114173609.3590237-1-abdullah.sevincer@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR12MB6341:EE_|BL1PR12MB5352:EE_ x-ms-office365-filtering-correlation-id: 02383193-dbc9-4dcc-8643-08dbe73a2c5c x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NkSwuxxaSjf/FVt9keZCOL9fQI7OCVo0s3ZQrys50ksPuVVZP1daZp371WXbwYPz1NJ8HQG5kpnOdsDtp8zAESG4+lxhbmRw14f9u+jmz+2Q/x7HOnH/LFvJc3vVLpoLfT8HnE5OFMt8hMoHFRHTqqbHjBXfjR5IkNJbQZ69sHwikpak+3oONh5hm0jjydWNfbGzFvM+oBQaojTHT705qLGebX/zzWJTPXtFCsCy5e6u8Gsc65hKy42//6IMgolOHdefSpl7mQs7EyzRhfftLKsDVhCSHCwMrQ4S+FFjhiLfXT67V3BosqnIXLcfL10jP7t3SC48FVEd8B3hSKumv446gYyuIGOJyaUjbpj1h3m68YAbbUq7oBp6Uenq9fbCYlpgsxIq7eD5SRELnzCx0e7rl0BJSd6PM4uBhbsHKAeHzbYvznJroniv3CzVp6meNN80u3ekTefy32RvCSmySIjh+K0JJzyhBctwq3ukxmZqjRp54DkZcrI2p6ilfsrGa9ovpOobaG7rsUbN/spxfz4bbcS5Dbgd6Nka0pHRfiB8CNBb6r30tUl7phDn3lWifzUvsQN+9iOy+gevdfRHn5t180dRHIrR2RykP+b2KmdFjcBQHJ2XNsUB7khyc9rQhk3SJVCKtPYf/pi0ULFvvoWfZV4ji33MwxDKnjXG5RfqjVep9vdERXO7DyDHKf5x x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR12MB6341.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(346002)(396003)(39860400002)(376002)(230173577357003)(230273577357003)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(83380400001)(6916009)(316002)(76116006)(64756008)(66446008)(66556008)(54906003)(66946007)(66476007)(4326008)(8936002)(8676002)(5660300002)(6512007)(6486002)(478600001)(2616005)(122000001)(41300700001)(33656002)(38100700002)(86362001)(71200400001)(53546011)(6506007)(26005)(2906002)(91956017)(38070700009)(36756003)(45980500001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oqJLVYNBbIOL3jUgL/oiXIBBiHe3ooGWKN58rWBTpZpB+NtMlsD0yuvSgMQZ?= =?us-ascii?Q?OTRxuZlSuB0ZTtsTIBhR4mdphCWoe0MKeKM0P3AvuqyxLGzJ3yICjwwZpB1p?= =?us-ascii?Q?SIMjFyzojOzsOrTQxV2ed2PmcuuZ1MccAL1AkDm88vycPR3EgVvyXU4cQ9Mp?= =?us-ascii?Q?yeob16xDrImpCxYiqM2pQH/ODG2QVidxAuay+pFE0sMjGwOcm6SwZvevBJjN?= =?us-ascii?Q?oZyZY7Pa8QooX/qPd/lPBBTiHmKiaaAnj+H8IR2kSUdwn2nwU/XdjYy7CEo2?= =?us-ascii?Q?Mcyw1DCg/XfYqmoolndX948i+fquDFGXNUSqQVefuXePyv7Oq+tnmwPXocOI?= =?us-ascii?Q?VIzPXlPiAjjgxb858abmzkWVm3JNnIStKLyWznBAY2NIUzriGiDhXf0dXMiW?= =?us-ascii?Q?nCIONgN4O4gD+Uk1MkYzxPd1rq+kOAuof4DslTshAG5ZjjEJuKGNiyjqXnWF?= =?us-ascii?Q?YSDuGmGQh98FwTWY9nuwhmLbB0KqoMpJwyddPRNbXBBucffIAvBIHhgr7Ecu?= =?us-ascii?Q?sk/0VV2EiEG4vD9W1cr3qTqZnj5TFQwjvgLvA4bHjq/HqEFTRAGnoD/eim3y?= =?us-ascii?Q?7ULS3xihFAmm832Pp9h/32CRgv++NmXpmmuOqBxE5H4mC8vtXn4ucb0tneby?= =?us-ascii?Q?axjsWEv30RTKV7uKWMf4Y6/y2MdHR6aLH3wW7tMRjs/l39gKVoLfm308QiPx?= =?us-ascii?Q?J3o5gvQUutdDGhE2r8NmEMmfZf9tkYVP5sQAbRUTXigT+wAcloHu3Mo+xkSM?= =?us-ascii?Q?tQRw0Fua4puEmhQBkH+yGJqjlahoXK57I4MaEsALTDzXsjcV/1sdKeofgw4d?= =?us-ascii?Q?kdLO4P/RAW33bYYWYnCHjkAN4dCHj77GoXyEsTZPFrUXROf6ekFnk+DSAPbR?= =?us-ascii?Q?Iy7e0AH2cT6vyrb8IpyBkQ+3K991dhsWeEbo/zdx8Z5NbY+SqaprD6DN0EyW?= =?us-ascii?Q?15bo3o3EgVeG5Ib9m50dkdaFi9tPCj6nZ9I8FGtqwWAWqolarX11aM7aXxwb?= =?us-ascii?Q?Ywh4Ko0yB5ljN95qYz21rDa0A87xxW4Mr78C2HCvrZ8Ne6a7mOY+DbTSHod/?= =?us-ascii?Q?O4FC57er0NSnYE0Hu6I1awZhKHRGI8yaJWT2QsfGWNF6wyuTuPEa6VnyeO6l?= =?us-ascii?Q?klZ0gkJulETXsat8lOFgVNYBJEkHN8lVHm88J0jAnJEdk/mKJ8XHjF82U7cH?= =?us-ascii?Q?chhRQrbzswpoDWnqntemUFv6/FfFB95bTjjT+T6XzKTQejwZmf69Bf8ixXZC?= =?us-ascii?Q?OneZjHmWWpCHXt6gfAtj48uHuH7Ipcc0lVflkD4MHU0WECm4VNB7F34JoYDF?= =?us-ascii?Q?jyDab3mJdQYm54rkLShpfyMZ2/r/HHFuZmj2/ysK674+kxO1nfwlVe8u2Ncr?= =?us-ascii?Q?GPRnH2iXxSTIRmE8P9RL85dmyT9SnkvmCGhb712ElDIa3NhvrAhEHOYUeE4I?= =?us-ascii?Q?d7L3lHKrzALKJBxCmWE/rRhPbjGwHLUwZx5W5iHBVUG+cZXUQf3zYlB+hjxC?= =?us-ascii?Q?wgBtN7+LlMIVHnVDDkrA/LeuIWxf1BwRS9Ol8UiAsLeIXk2k7Kj+lZ1qKWFt?= =?us-ascii?Q?rbqbym8BN3IK0FtKZPV7zk4ztA8mE/ABe8WBSL8m?= Content-Type: text/plain; charset="us-ascii" Content-ID: <28244FC1B7FAA34CAA98BFB00005B96B@namprd12.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6341.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02383193-dbc9-4dcc-8643-08dbe73a2c5c X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2023 06:55:24.0973 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZokTwgFP0lvWRatc4NgLu7oHBxdwFBkUlKNZ55gfUNf+YS/6Bm82NLak/gsq0ylJF+BSAC1cKbFRKbe8ums2rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5352 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Nov 15, 2023, at 01:36, Abdullah Sevincer wrote: >=20 > External email: Use caution opening links or attachments >=20 >=20 > This commit revises PASID control function to accept PASID offset to > pasid *structure* instead of taking exact register for controlling the > feature. >=20 > PASID control function was introduced in earlier commit. > Please see commit 5a6878335b81 ("event/dlb2: disable PASID") and > commit 60ea19609aec ("bus/pci: add PASID control"). >=20 > Signed-off-by: Abdullah Sevincer > --- > drivers/bus/pci/pci_common.c | 5 ++--- > drivers/bus/pci/rte_bus_pci.h | 5 ++++- > drivers/event/dlb2/pf/dlb2_main.c | 4 ++-- > lib/pci/rte_pci.h | 2 +- > 4 files changed, 9 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c > index ba5e280d33..889a48d2af 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -943,9 +943,8 @@ rte_pci_pasid_set_state(const struct rte_pci_device *= dev, > off_t offset, bool enable) > { > uint16_t pasid =3D enable; > - return rte_pci_write_config(dev, &pasid, sizeof(pasid), offset) <= 0 > - ? -1 > - : 0; > + return rte_pci_write_config(dev, &pasid, sizeof(pasid), > + offset + RTE_PCI_PASID_CTRL) !=3D sizeof(pasid) ?= -1 : 0; > } >=20 > struct rte_pci_bus rte_pci_bus =3D { > diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.= h > index f07bf9b588..35d07d8294 100644 > --- a/drivers/bus/pci/rte_bus_pci.h > +++ b/drivers/bus/pci/rte_bus_pci.h > @@ -161,9 +161,12 @@ int rte_pci_set_bus_master(const struct rte_pci_devi= ce *dev, bool enable); > * @param dev > * A pointer to a rte_pci_device structure. > * @param offset > - * Offset of the PASID external capability. > + * Offset of the PASID external capability structure. > * @param enable > * Flag to enable or disable PASID. > + * > + * @return > + * 0 on success, -1 on error in PCI config space read/write. > */ > __rte_internal > int rte_pci_pasid_set_state(const struct rte_pci_device *dev, > diff --git a/drivers/event/dlb2/pf/dlb2_main.c b/drivers/event/dlb2/pf/dl= b2_main.c > index 61a7b39eef..a95d3227a4 100644 > --- a/drivers/event/dlb2/pf/dlb2_main.c > +++ b/drivers/event/dlb2/pf/dlb2_main.c > @@ -518,8 +518,8 @@ dlb2_pf_reset(struct dlb2_dev *dlb2_dev) > /* Disable PASID if it is enabled by default, which > * breaks the DLB if enabled. > */ > - off =3D DLB2_PCI_PASID_CAP_OFFSET + RTE_PCI_PASID_CTRL; > - if (rte_pci_pasid_set_state(pdev, off, false)) { > + off =3D DLB2_PCI_PASID_CAP_OFFSET; > + if (rte_pci_pasid_set_state(pdev, off, false) < 0) { > DLB2_LOG_ERR("[%s()] failed to write the pcie config space= at offset %d\n", > __func__, (int)off); > return -1; > diff --git a/lib/pci/rte_pci.h b/lib/pci/rte_pci.h > index 0d2d8d8fed..c26fc77209 100644 > --- a/lib/pci/rte_pci.h > +++ b/lib/pci/rte_pci.h > @@ -101,7 +101,7 @@ extern "C" { > #define RTE_PCI_EXT_CAP_ID_ACS 0x0d /* Access Control Services= */ > #define RTE_PCI_EXT_CAP_ID_SRIOV 0x10 /* SR-IOV */ > #define RTE_PCI_EXT_CAP_ID_PRI 0x13 /* Page Request Interface = */ > -#define RTE_PCI_EXT_CAP_ID_PASID 0x1B /* Process Address Space = ID */ > +#define RTE_PCI_EXT_CAP_ID_PASID 0x1b /* Process Address Space = ID */ >=20 > /* Advanced Error Reporting (RTE_PCI_EXT_CAP_ID_ERR) */ > #define RTE_PCI_ERR_UNCOR_STATUS 0x04 /* Uncorrectable Error Sta= tus */ > -- > 2.25.1 >=20 Reviewed-by: Chenbo Xia