From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E02CA04B7; Wed, 14 Oct 2020 15:40:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20BE21BDF8; Wed, 14 Oct 2020 15:40:55 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 480721B80B for ; Wed, 14 Oct 2020 15:40:52 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.137]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id BCBDA200C0; Wed, 14 Oct 2020 13:40:50 +0000 (UTC) Received: from us4-mdac16-68.at1.mdlocal (unknown [10.110.50.185]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id B9BAE600A1; Wed, 14 Oct 2020 13:40:50 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.104]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 54EC2220072; Wed, 14 Oct 2020 13:40:50 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id F2F71B80069; Wed, 14 Oct 2020 13:40:49 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 14 Oct 2020 14:40:44 +0100 To: Thomas Monjalon , Ivan Ilchenko CC: Ray Kinsella , Neil Horman , "Ferruh Yigit" , References: <1602682146-4722-1-git-send-email-arybchenko@solarflare.com> <1602682146-4722-2-git-send-email-arybchenko@solarflare.com> <3910167.mFdbjSblXh@thomas> From: Andrew Rybchenko Message-ID: <5968aca3-8bd5-a6f5-a4e7-8afea92a8dbc@solarflare.com> Date: Wed, 14 Oct 2020 16:40:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <3910167.mFdbjSblXh@thomas> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25724.003 X-TM-AS-Result: No-3.129400-8.000000-10 X-TMASE-MatchedRID: zGP2F0O7j/vA46G+uSzVzfZvT2zYoYOwC/ExpXrHizybwQeq9XJggKLo SLE/BAxZopQtjaUqZfsokSiKFlVT4FWv6mJ+J+GWcI7vRACwF0LdXhRKGhNdp2Ic12gbXAOc8xf 51HO7e/X+gT4nOtD5yh5Ba9OgpgouYzZeA2K2mq3D0ZWEZr/ntqbwyy5bAB/91tMhXOTffbA4GJ 4peJPEBWi21Xaf04wkkZOl7WKIImrvXOvQVlExsJaWKijZlsbB2bNx1HEv7HAqtq5d3cxkNW7hd qEzCAa84aIur+nX7HAj1bFPc0lvirrsRjHGIsvdemeyvTLxpr/7fGdAsfhMp3hvEuQBy9/mrStO pAX6bSF9VygdIYstYtoQy0xZsLaTBsRAh8WmTAcG2WAWHb2qekrMHC7kmmSWc5S6hNczuvhDDKa 3G4nrLQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.129400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25724.003 X-MDID: 1602682850-EuZ9gE-3b9nI X-PPE-DISP: 1602682850;EuZ9gE-3b9nI Subject: Re: [dpdk-dev] [PATCH 01/11] ethdev: change eth dev stop function to return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/20 4:33 PM, Thomas Monjalon wrote: > 14/10/2020 15:28, Andrew Rybchenko: >> From: Ivan Ilchenko >> >> Change rte_eth_dev_stop() return value from void to int >> and return negative errno values in case of error conditions. >> Also update the usage of the function in ethdev according to >> the new return type. >> >> Signed-off-by: Ivan Ilchenko > Please no capital letter in the email address. OK >> Signed-off-by: Andrew Rybchenko > Thanks for taking care of this cleanup. > > A note in the API changes of the release notes is missing. I'll wait for tomorrow for more reviews and send v2 with both notes fixed. > Except that miss, > Acked-by: Thomas Monjalon Thanks.