From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 780171AEEB
 for <dev@dpdk.org>; Mon, 18 Sep 2017 16:51:59 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga104.jf.intel.com with ESMTP; 18 Sep 2017 07:51:58 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="1173319664"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57])
 ([10.237.220.57])
 by orsmga001.jf.intel.com with ESMTP; 18 Sep 2017 07:51:57 -0700
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Cc: hemant.agrawal@nxp.com
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-14-shreyansh.jain@nxp.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <596a7bff-1179-1590-c9b2-92e8362460d0@intel.com>
Date: Mon, 18 Sep 2017 15:51:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170909112132.13936-14-shreyansh.jain@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v4 13/41] bus/dpaa: add support for FMAN
 frame queue lookup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 14:51:59 -0000

On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
> Signed-off-by: Geoff Thorpe <geoff.thorpe@nxp.com>
> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

<...>

>  
> +#if !defined(CONFIG_FSL_QMAN_FQ_LOOKUP) && defined(RTE_ARCH_ARM64)
> +#error "_ARM64 requires _FSL_QMAN_FQ_LOOKUP"
> +#endif

This PMD enabled with new added config
"defconfig_arm64-armv8a-linuxapp-gcc", which is 64bits. So this means
CONFIG_FSL_QMAN_FQ_LOOKUP always defined for the bus.

Does is make sense to keep above check, but for rest of the code assume
CONFIG_FSL_QMAN_FQ_LOOKUP always set and remove the #ifdefs, to simplify
the code?

<...>