From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 25F75AF87
 for <dev@dpdk.org>; Thu, 19 Jun 2014 17:32:46 +0200 (CEST)
Received: by mail-wg0-f46.google.com with SMTP id y10so2485507wgg.29
 for <dev@dpdk.org>; Thu, 19 Jun 2014 08:33:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=gMtRfXKhEWCgTgPpjJZ27nAL5eZKsdVX9vGwqarDioE=;
 b=ajCiyF0pLEXQUejVc0yHE4FFFAzSRe7Qa5VxZlKsOYR/S++v9ZgT3wMOh6fxVVdaw/
 98R55H3VaSHE2KaYwDl6scSG7v6iEjwJSw7ss9H3gExP3L/YSy2L35lCfHTZWOEEqLsT
 7HgB5lBkJGosrcOZ9cdacycj/kOM8etRM3UT53LUzUtA2JMUYDVyiQkoL0MdxKH0KYYk
 AET2Lhzb39fvVuYQ+tgOlljYfGYiIzmV03AMV8jBJnduRKKWf+nNifc0gEiEY0GyNAIO
 j3TUdSX6WlJQyFz73pjdLVzjNE3Wna9o6IpPdPI2Xr3lMH1rg/y6HqI1tDb8n/+p6Jhj
 uYRw==
X-Gm-Message-State: ALoCoQl6san3onHg6H54llHdojA/fXfPCftKwp7AcqmPvLZv6/NCkex61XTZAjuVu6oqQgslSACT
X-Received: by 10.180.74.131 with SMTP id t3mr7444664wiv.23.1403191982222;
 Thu, 19 Jun 2014 08:33:02 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id i6sm12480982wiy.17.2014.06.19.08.33.00
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 19 Jun 2014 08:33:01 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Thu, 19 Jun 2014 17:32:57 +0200
Message-ID: <5971655.KRkzbCMV6h@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <1402494218-9203-1-git-send-email-helin.zhang@intel.com>
References: <1402494218-9203-1-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: fix compile errors on Oracle
	Linux6.4 and RHEL6.5
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jun 2014 15:32:46 -0000

2014-06-11 21:43, Helin Zhang:
> -#if !(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(6,4))
> -static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
> +static inline bool __kc_ether_addr_equal(const u8 *addr1, const u8 *addr2)
>  {
>  	return !compare_ether_addr(addr1, addr2);
>  }
> -#endif
> +#define ether_addr_equal(_addr1, _addr2) __kc_ether_addr_equal((_addr1),(_addr2))

Why not defining it in one line (as Neil suggested)?
#define ether_addr_equal(_addr1, _addr2) (!compare_ether_addr(addr1, addr2))

-- 
Thomas