From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1598FA034F; Fri, 10 Sep 2021 23:14:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BD4B40041; Fri, 10 Sep 2021 23:14:33 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 2D9B34003E for ; Fri, 10 Sep 2021 23:14:32 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 23D2C320005D; Fri, 10 Sep 2021 17:14:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 10 Sep 2021 17:14:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= UVBHx7sjYcxS5HdRq89vaVUC5EFFnb4Gfd0YEtnG2BQ=; b=dXprBUE3c28KoRkX 0ey9m/rRubohlHm2s7x5OpjSFMNrcuYEVPWlaTdVk4355pFUIroeY1ELTTPcuMch iVAWq/ovjbBT+XeGkad7p/jpaiclMzN/WGELmmlGKS7beA27EiEwQ8Is4WgRmZSg x6nhku7S7BK0vJbSS4Tgo+AnwOmG2gKN8aLdlRJghi6FUOlmj5/uyGYhQIUnla48 UtEsUpZa7RSWOPqXFOX8u+ToykG6cRoVZ9K22CQR+w8t+g3n8LVqQnl9IPsRWSTb lZq71MBfXu8mwkjdWffSww9w1w8xVcKDsbEgxKhuT6dDTMBYLMZEt51rze+xIYfR /jRB/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=UVBHx7sjYcxS5HdRq89vaVUC5EFFnb4Gfd0YEtnG2 BQ=; b=k21cjagpdQ5FUPq+UawCPbsYB08L8YDN3dAmqUCzueWok/g3kekFqueJc kwjNT4hpUXzCkiUdcNV+f+kShdNRSThR8HWnFvyUWplx8ARAapKNVpyObWBzqYD7 RTHUHfsFWmf1hEfQFzHXo/5NdmCP2q96Udrvv1bfrIGkUYd5+CBGA2hJ6MwiiQFe pLv0Oqe/RCN2yQsNnHzs3g/HdLbRTF9GqLtQyBb4ZjsLo9UFohPiwMjOynaAqJhu fCI1Tt4QVgre9cCpAHwkYoyQBjwIlmPGN/fxe5F7OSZIalo2PFW6OkgypewBWZx1 x6yS0P0IBWRgyfoVnpkBxuquOkoHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeguddgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtuf ertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfe eglefghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Sep 2021 17:14:28 -0400 (EDT) From: Thomas Monjalon To: Ben Pfaff Cc: dev@dpdk.org Date: Fri, 10 Sep 2021 23:14:26 +0200 Message-ID: <5977659.pG1F7i0IUM@thomas> In-Reply-To: <20210910175733.1248739-1-blp@ovn.org> References: <20210910175733.1248739-1-blp@ovn.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: Document what the application does. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/09/2021 19:57, Ben Pfaff: > I could not find anything in the documentation that says what > testpmd does. This should save other people time trying to > figure that out in the future. Good move indeed :) > --- a/doc/guides/testpmd_app_ug/run_app.rst > +++ b/doc/guides/testpmd_app_ug/run_app.rst > @@ -15,6 +15,12 @@ a list of available EAL command-line options. > Testpmd Command-line Options > ---------------------------- > > +By default, testpmd receives packets on each configured port and > +forwards the received packets to its paired port. Ports 0 and 1 are > +paired, as are ports 2 and 3, and so on. With an odd number of ports, > +the last port is paired with itself: packets received on the port are > +sent back out on the same port. So the intent is to say what is the default behaviour? We could also update the introduction which is outdated: " The testpmd application can be used to test the DPDK in a packet forwarding mode and also to access NIC hardware features such as Flow Director. It also serves as a example of how to build a more fully-featured application using the DPDK SDK. " The last sentence should be removed. The first sentence is a bit outdated. We should say "testpmd is a tool to test ethdev NIC features". May I take the opportunity of this patch to improve this intro as well?