From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D4A845CDD; Sun, 10 Nov 2024 19:36:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29A5F40151; Sun, 10 Nov 2024 19:36:03 +0100 (CET) Received: from fhigh-b5-smtp.messagingengine.com (fhigh-b5-smtp.messagingengine.com [202.12.124.156]) by mails.dpdk.org (Postfix) with ESMTP id A3873400EF for ; Sun, 10 Nov 2024 19:36:00 +0100 (CET) Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfhigh.stl.internal (Postfix) with ESMTP id 8D6F52540120; Sun, 10 Nov 2024 13:35:59 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Sun, 10 Nov 2024 13:35:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731263759; x=1731350159; bh=Oxukm16YbSRpPLVjL9Kx/weHIIhE4e0E/szDVjeReHs=; b= COppFXD3JTTGqPkMsoQLmbaNwGwsyLej+somYsVfYEoARh0idk3GpX6aaEJ2uazQ K4z/pl1loGsvje5EIn5iSv6ig6Mf/8/UXZ77nN0cYcW4BZhR8mUsQjkB67SGMtaN PvOHSC5ty85c49lls4FfycDUawX0zJRFXO0+tZ2wv42q4Au+Gi7ibHrgO8QNYjA7 cDqECvxMxakHhD6Lu2cyn4t5IDyIDv5ysdEC0FSqzZJIfAehfhP/v1I9o+H7Pkqz YEMhKo5f9wSbwKEtoNouuRbhtoo4ry0XdZaqx3ZqS0o0OzRc9sVwkKKU1h5VEC1o 91BfSeElVAY2lXCJOt9cUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731263759; x= 1731350159; bh=Oxukm16YbSRpPLVjL9Kx/weHIIhE4e0E/szDVjeReHs=; b=K JuZDkL6hElYEZVclml2TCKM20j8ah1Kb/UfkWs1uRo2dihZM6Drp5Xc8IgoA4JKg 0CdMGsyjjz4oal5P2d6PRY8Yz0ZxcmZY//Ds0zY8Y396lP6D/ApWHQN9Xcd0EW6z Qr/wC4ydTVl/cyDCdYqeTBOORI2WiUty2nCuT/N/XsBhHsomHWKs10Zx/Q7wFFuI 45LkbE4FocQJObbjzt9lwrIG1v/127YzY4uI9hT4qpshNK3kkbiVoUWgE/ZDKAvr 9PKXY3s2Ck9UULNaNDzz3bnBzKIcanddxeYDc4VRzT76Uv183isLtER82WsDh7pQ l3qp5a/UT5tWcK9LdBZ2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddtgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeduuddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhivh grphhrrghsrggurdhtuhhmmhgrlhgrsegrmhgurdgtohhmpdhrtghpthhtohepuggrvhhi ugdrhhhunhhtsehinhhtvghlrdgtohhmpdhrtghpthhtoheprghnrghtohhlhidrsghurh grkhhovhesihhnthgvlhdrtghomhdprhgtphhtthhopehjvghrihhnjhesmhgrrhhvvghl lhdrtghomhdprhgtphhtthhopehrrgguuhdrnhhitgholhgruhesihhnthgvlhdrtghomh dprhgtphhtthhopehgrghkhhhilhesmhgrrhhvvghllhdrtghomhdprhgtphhtthhopegt rhhishhtihgrnhdrughumhhithhrvghstghusehinhhtvghlrdgtohhmpdhrtghpthhtoh eplhhihhhuihhsohhngheshhhurgifvghirdgtohhmpdhrtghpthhtohepfhgvrhhruhhh rdihihhgihhtsegrmhgurdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Nov 2024 13:35:57 -0500 (EST) From: Thomas Monjalon To: Sivaprasad Tummala Cc: david.hunt@intel.com, anatoly.burakov@intel.com, jerinj@marvell.com, radu.nicolau@intel.com, gakhil@marvell.com, cristian.dumitrescu@intel.com, lihuisong@huawei.com, ferruh.yigit@amd.com, konstantin.ananyev@huawei.com, dev@dpdk.org Subject: Re: [PATCH v10 0/6] power: refactor power management library Date: Sun, 10 Nov 2024 19:35:55 +0100 Message-ID: <5996777.Isy0gbHreE@thomas> In-Reply-To: <20241028195556.450033-1-sivaprasad.tummala@amd.com> References: <20241023051139.1066426-1-sivaprasad.tummala@amd.com> <20241028195556.450033-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/10/2024 20:55, Sivaprasad Tummala: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers/power/uncore/*'. > > This refactor significantly improves code organization, enhances > clarity, and boosts maintainability. It lays the foundation for more > focused development on individual drivers and facilitates seamless > integration of future enhancements, particularly the AMD uncore driver. > > Furthermore, this effort aims to streamline code maintenance by > consolidating common functions for cpufreq and cppc across various > core drivers, thus reducing code duplication. > > Sivaprasad Tummala (6): > power: refactor core power management library > power: refactor uncore power management library > test/power: removed function pointer validations > drivers/power: uncore support for AMD EPYC processors > maintainers: update for drivers/power > power: rename library sources for cpu frequency management I'm a bit sad there is not more reviews. I've moved the pointers check removal first, renamed intel_pstate files (not the functions), fixed few things like __cplusplus, include guards, sorting and maintainers file. Applied