From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id C1A3E7F00 for ; Wed, 5 Oct 2016 11:51:51 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id f193so218222369wmg.0 for ; Wed, 05 Oct 2016 02:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=2BpLAz/XkNoufetyttjidWAICgQ+ugdXbsnQRpSh4YA=; b=UrxVzAkuFw5KXH+6kP+xafiSTq4F+JNNn6DOXNq58M8qL4cvf4vuOpYftNaZOGq0+O mlodideC1P7wE/tGGD0juc9RO9FSa3HbRPxwvhtiLXH9Q1DmQ6FvHo63QJ89FMwBQ+KF T3j+Rzgu+zwSkhwuqdherS31dWjE2GOOnvRnyWKZAZ//ultuphoVfHGi9BcxooQ1SzA5 TLWKU8KJ66ClqjDgEySdcSVVK/J/tJsdZQSGCSus0GfIgL3RhIUIrWcZvZhMk7d9JYRW eLn88niXIVem8dUtVtRdTfwEKNQ05Z6/TpfAQ1OysaRmNh7Y6RHy9K6o9IVVg6OTd7zR bZXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=2BpLAz/XkNoufetyttjidWAICgQ+ugdXbsnQRpSh4YA=; b=WUWih5gUVeDf39o8chkXgjMfqfGlNqr1s7iCN2z4Tn40onykctDR8gGPyBE+1/MR/n XH1qozjyiP1DeqBh/LfiYm7XTDokXX01zeH1yfbKogNXaJRyEt1mKdhG3icjEhqHuOTE mYfD2ColOa8lNf+8lrKMNQmKtbKDwJrV74hZKfZsr5xMdW9eAHo3/THVdbuK49MtCPOn X8vIrl61uOKHUtZlaCUwkL8DXms6IldpWz7N23GnnPbtmXC6zNPoWz8WbF4rQUiaSCKo c2Qpo5nnoTsjEaPFF0ymb3+M8RBrm6fLwmDjLKbbLR6u+xw/Jl8Jww5Xtwp0QFWfJLCy wc8g== X-Gm-Message-State: AA6/9Rngx10sjDjS99LKLilL+1WtOm1+bDS1U5R9UHQ06C14jH8fHO60/HZCR+HVMf3KB29k X-Received: by 10.194.113.35 with SMTP id iv3mr6654363wjb.169.1475661111570; Wed, 05 Oct 2016 02:51:51 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id f142sm8595679wmf.19.2016.10.05.02.51.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Oct 2016 02:51:50 -0700 (PDT) From: Thomas Monjalon To: jean.tourrilhes@hpe.com Cc: Sergio Gonzalez Monroy , dev@dpdk.org Date: Wed, 05 Oct 2016 11:51:48 +0200 Message-ID: <5999446.HPKiItx4sF@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20160921211049.GA27472@labs.hpe.com> <20161004171703.GA3053@labs.hpe.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/3] mem: fix hugepage mapping error messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 09:51:51 -0000 2016-10-04 20:07, Sergio Gonzalez Monroy: > On 04/10/2016 18:17, Jean Tourrilhes wrote: > > Running secondary is tricky due to the need to map the memory region > > at the right place in VM, which is whatever primary has chosen. If the > > base address for primary happens to by already mapped in the > > secondary, we will hit precisely these error messages (depending if we > > fail on the config region or the hugepages). This is why there is > > already a comment about ASLR. > > > > The issue is that in most cases, remapping does not happen and "errno" > > is not changed and therefore stale. In our case, we got a "permission > > denied", which sent us down the wrong track. It's such a common error > > for secondary that I feel this error message should be unambiguous and > > helpful. > > The call to close was also moved because close() may override errno. > > > > Signed-off-by: Jean Tourrilhes > > --- > > lib/librte_eal/linuxapp/eal/eal.c | 14 +++++++++++--- > > lib/librte_eal/linuxapp/eal/eal_memory.c | 16 ++++++++++++---- > > 2 files changed, 23 insertions(+), 7 deletions(-) > > Acked-by: Sergio Gonzalez Monroy Applied, thanks A rebase was necessary because of this patch: http://dpdk.org/commit/c00ae961 Please check everything is OK.