From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id BA583156
 for <dev@dpdk.org>; Fri,  4 Apr 2014 10:20:04 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga101.jf.intel.com with ESMTP; 04 Apr 2014 01:21:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,793,1389772800"; d="scan'208";a="506819420"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by fmsmga001.fm.intel.com with ESMTP; 04 Apr 2014 01:21:38 -0700
Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by
 IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Fri, 4 Apr 2014 09:21:37 +0100
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.172]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.180]) with mapi id 14.03.0123.003;
 Fri, 4 Apr 2014 09:21:37 +0100
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Cyril Chemparathy <cchemparathy@tilera.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 3/6] test-pmd: allow command line selection
 of	forwarding mode
Thread-Index: AQHPT2UgFqztn0PUP02YLOFXTuhzbpsBHntw
Date: Fri, 4 Apr 2014 08:21:36 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B01A9F8609@IRSMSX103.ger.corp.intel.com>
References: <1396546216-29200-1-git-send-email-cchemparathy@tilera.com>
 <1396546216-29200-4-git-send-email-cchemparathy@tilera.com>
In-Reply-To: <1396546216-29200-4-git-send-email-cchemparathy@tilera.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 3/6] test-pmd: allow command line selection
 of	forwarding mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Apr 2014 08:20:05 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Cyril Chemparathy
> Sent: Thursday, April 03, 2014 6:30 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 3/6] test-pmd: allow command line selection of=
 forwarding mode
>
> This commit allows testpmd forwarding mode selection through command line=
 parameters instead of having to set this up in=20
> interactive mode.
>
> Signed-off-by: Cyril Chemparathy <cchemparathy@tilera.com>
> ---
> app/test-pmd/parameters.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index =
18b52cc..67081d7 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -158,6 +158,7 @@ usage(char* progname)
> 	printf("  --disable-rss: disable rss.\n");
>  	printf("  --port-topology=3DN: set port topology (N: paired (default) o=
r "
> 	       "chained).\n");
> +	printf("  --forward-mode=3DN: set forwarding mode.\n");

The help text should probably include a list of what the modes are and what=
 values need to be provided for each one.