From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
 by dpdk.org (Postfix) with ESMTP id 1E4F2B0AE
 for <dev@dpdk.org>; Tue, 24 Jun 2014 19:39:41 +0200 (CEST)
Received: from azsmga001.ch.intel.com ([10.2.17.19])
 by azsmga101.ch.intel.com with ESMTP; 24 Jun 2014 10:39:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,539,1400050800"; d="scan'208";a="449435543"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by azsmga001.ch.intel.com with ESMTP; 24 Jun 2014 10:39:58 -0700
Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by
 IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS)
 id 14.3.123.3; Tue, 24 Jun 2014 18:39:57 +0100
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.31]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.233]) with mapi id 14.03.0123.003;
 Tue, 24 Jun 2014 18:39:52 +0100
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
Thread-Index: AQHPj8Z6o21eKPs7QkGzW0cqTAffyJuAhm7A
Date: Tue, 24 Jun 2014 17:39:52 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com>
References: <20140624090253.140206a7@nehalam.linuxnetplumber.net>
In-Reply-To: <20140624090253.140206a7@nehalam.linuxnetplumber.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jun 2014 17:39:42 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Tuesday, June 24, 2014 9:03 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
>=20
> The function rte_snprintf serves no useful purpose. It is the
> same as snprintf() for all valid inputs. Just remove it and
> replace all uses in current code.
>=20
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>=20

NAK to this as is.
Approve of replacing all instance of the rte_snprintf function with the sta=
ndard version in all our code and libraries.
However, rather than just removing the function completely, I think we shou=
ld just flag the function as deprecated initially, and then later on look t=
o remove it completely.

/Bruce