From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 86EE25944
 for <dev@dpdk.org>; Tue, 28 Oct 2014 11:10:17 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 28 Oct 2014 03:19:02 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="407179756"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by FMSMGA003.fm.intel.com with ESMTP; 28 Oct 2014 03:10:48 -0700
Received: from irsmsx154.ger.corp.intel.com (163.33.192.96) by
 IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Tue, 28 Oct 2014 10:18:27 +0000
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.56]) by
 IRSMSX154.ger.corp.intel.com ([169.254.12.116]) with mapi id 14.03.0195.001;
 Tue, 28 Oct 2014 10:18:27 +0000
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Zhang, Helin"
 <helin.zhang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes
 of redirection table
Thread-Index: AQHP8peI7gphHPm7UECIrxHaUqXnXpxFS5zA
Date: Tue, 28 Oct 2014 10:18:27 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B034434191@IRSMSX103.ger.corp.intel.com>
References: <1411634427-746-1-git-send-email-helin.zhang@intel.com>
 <4337777.fZJZ2Jprv9@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7AB9C4@SHSMSX104.ccr.corp.intel.com>
 <3230077.QOtjOU5lvA@xps13>
In-Reply-To: <3230077.QOtjOU5lvA@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple
	sizes	of redirection table
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2014 10:10:18 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, October 28, 2014 10:10 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple size=
s of
> redirection table
>=20
> 2014-10-28 00:33, Zhang, Helin:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2014-09-25 16:40, Helin Zhang:
> > > >  /* Definitions used for redirection table entry size */
> > > > -#define ETH_RSS_RETA_NUM_ENTRIES 128
> > > > -#define ETH_RSS_RETA_MAX_QUEUE   16
> > > > +#define ETH_RSS_RETA_SIZE_64  64
> > > > +#define ETH_RSS_RETA_SIZE_128 128
> > > > +#define ETH_RSS_RETA_SIZE_512 512
> > > > +
> > > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t))
> > >
> > > Are these constants really needed?
> >
> > These constants were defined for the third input parameter of
> > rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query(). End use=
rs
> need
> > to give the correct reta size listed as above, as other values is not v=
alid. So it
> would be
> > better to list the valid reta sizes in macros here.
>=20
If only limited range of values are allowed, would an enum work better than=
 a set of macros?=20

> OK, so you should explain that only these values are allowed.
> In general, it's something we explain in the comment of the function.
>=20
> By the way, why only these values are allowed?