From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 29CFC5698 for ; Wed, 20 May 2015 17:30:46 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 20 May 2015 08:30:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,464,1427785200"; d="scan'208";a="496112114" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by FMSMGA003.fm.intel.com with ESMTP; 20 May 2015 08:30:41 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.215]) by IRSMSX107.ger.corp.intel.com ([169.254.10.94]) with mapi id 14.03.0224.002; Wed, 20 May 2015 16:30:39 +0100 From: "Richardson, Bruce" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 02/19] drivers: create drivers and drivers/net directory Thread-Index: AQHQjyfPoWLN0G0yF0KR+8nejhxlOp2E7X2AgAAWQCA= Date: Wed, 20 May 2015 15:30:40 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0345399F8@IRSMSX103.ger.corp.intel.com> References: <1431450315-13179-1-git-send-email-bruce.richardson@intel.com> <1431705423-16134-1-git-send-email-bruce.richardson@intel.com> <1431705423-16134-3-git-send-email-bruce.richardson@intel.com> <5822237.JRlZbxOZb6@xps13> In-Reply-To: <5822237.JRlZbxOZb6@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 02/19] drivers: create drivers and drivers/net directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 15:30:46 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, May 20, 2015 4:05 PM > To: Richardson, Bruce > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 02/19] drivers: create drivers and > drivers/net directory >=20 > 2015-05-15 16:56, Bruce Richardson: > > Add a new top-level "drivers" directory to which all PMDs will be > > moved for easier maintenance of both lib folder and drivers > > themselves. This new directory is a dependency of all the apps in the > > app folder, so the makefiles for each app are updated. >=20 > Why drivers are a dependency of every apps? > Some of them don't even include rte_ethdev.h. Good point. I just got a broken build initially in the apps with missing de= pendencies, so I made the change so that dependencies were the same as befo= re. Looking at things, I imagine test-pmd and test-pipeline depend upon the dri= vers since they do packet IO, and the test app will depend on it as it has = unit tests for the bond-ethdev driver. Dump-cfg and the test-acl app should not have a dependency on the driver, I= imagine.=20 It appears that the cmdline-test app is missing a DEPDIRS-y line, but it pr= obably should depend on the libs, right? /Bruce