From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7934411F5 for ; Wed, 28 Oct 2015 18:36:17 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 28 Oct 2015 10:36:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,210,1444719600"; d="scan'208";a="673704135" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 28 Oct 2015 10:36:15 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.116]) by IRSMSX107.ger.corp.intel.com ([169.254.10.49]) with mapi id 14.03.0248.002; Wed, 28 Oct 2015 17:36:04 +0000 From: "Richardson, Bruce" To: Jan Viktorin , David Marchand Thread-Topic: [dpdk-dev] [PATCH v2 01/16] mk: Introduce ARMv7 architecture Thread-Index: AQHREA0D53iCLtI5XkmKLxrZ5+MCKJ6A6rAAgABCXgCAAACQMA== Date: Wed, 28 Oct 2015 17:36:03 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0359637EA@IRSMSX103.ger.corp.intel.com> References: <1445877458-31052-1-git-send-email-viktorin@rehivetech.com> <1445877458-31052-2-git-send-email-viktorin@rehivetech.com> <20151028183212.0ca50e6a@jvn> In-Reply-To: <20151028183212.0ca50e6a@jvn> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , Vlastimil Kosar Subject: Re: [dpdk-dev] [PATCH v2 01/16] mk: Introduce ARMv7 architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 17:36:17 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jan Viktorin > Sent: Wednesday, October 28, 2015 5:32 PM > To: David Marchand > Cc: dev@dpdk.org; Vlastimil Kosar > Subject: Re: [dpdk-dev] [PATCH v2 01/16] mk: Introduce ARMv7 architecture >=20 > On Wed, 28 Oct 2015 14:34:40 +0100 > David Marchand wrote: >=20 > > On Mon, Oct 26, 2015 at 5:37 PM, Jan Viktorin > > > > wrote: > > > > > From: Vlastimil Kosar > > > > > > Make DPDK run on ARMv7-A architecture. This patch assumes ARM > > > Cortex-A9. However, it is known to be working on Cortex-A7 and > > > Cortex-A15. > > > > > > Signed-off-by: Vlastimil Kosar > > > Signed-off-by: Jan Viktorin > > > --- > > > v1 -> v2: > > > * the -mtune parameter of GCC is configurable now > > > * the -mfpu=3Dneon can be turned off > > > > > > Signed-off-by: Jan Viktorin > > > --- > > > config/defconfig_arm-armv7-a-linuxapp-gcc | 78 > > > +++++++++++++++++++++++++++++++ > > > mk/arch/arm/rte.vars.mk | 39 ++++++++++++++++ > > > mk/machine/armv7-a/rte.vars.mk | 67 > ++++++++++++++++++++++++++ > > > 3 files changed, 184 insertions(+) > > > create mode 100644 config/defconfig_arm-armv7-a-linuxapp-gcc > > > create mode 100644 mk/arch/arm/rte.vars.mk create mode 100644 > > > mk/machine/armv7-a/rte.vars.mk > > > > > > > This patch comes too early in the patchset, I would put it once > > compilation is fine (more comment to come, btw), so once all headers > > are in place, not before. >=20 > Agree, this was done by watching the Power 8 patchset. But this seems > quite logical. >=20 > > > > Besides, do we really need this -a suffix ? >=20 > It is the full name of the ARM architecture - armv7, A profile. There are > 3 profiles: A - application, R - real time, M - microcontroller. > They differ in what MMU/MPU and other such things they support. But, > finally, we can omit. The M profile is unsuitable for DPDK anyway. The R > profile may be however used under certain circumstances (I believe, it ca= n > run Linux). >=20 If you do want to include the "a" maybe just drop the "-" before it, please= .=20 The "-" is used to separate the elements of the RTE_TARGET and so it doesn'= t look right. /Bruce