From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id E4D0491AA
 for <dev@dpdk.org>; Fri, 30 Oct 2015 15:56:16 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP; 30 Oct 2015 07:56:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,219,1444719600"; d="scan'208";a="838898924"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by orsmga002.jf.intel.com with ESMTP; 30 Oct 2015 07:56:16 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.116]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.183]) with mapi id 14.03.0248.002;
 Fri, 30 Oct 2015 14:56:14 +0000
From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 2/2] lib/lpm:fix an initialization issue
 of valid_group in the delete_depth_small()
Thread-Index: AQHREx5noZ5LT/e3SkibAP1gSPSMx56EFx6AgAAB7YCAAAbMwA==
Date: Fri, 30 Oct 2015 14:56:13 +0000
Message-ID: <59AF69C657FD0841A61C55336867B5B0359655E4@IRSMSX103.ger.corp.intel.com>
References: <1446210879-14242-1-git-send-email-jijiang.liu@intel.com>
 <20151030142227.GB10520@bricha3-MOBL3>
 <20151030142425.GC10520@bricha3-MOBL3> <2760784.4fBWi2jOBS@xps13>
In-Reply-To: <2760784.4fBWi2jOBS@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] lib/lpm:fix an initialization issue
 of valid_group in the delete_depth_small()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Oct 2015 14:56:17 -0000

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>=20
> 2015-10-30 14:24, Bruce Richardson:
> > On Fri, Oct 30, 2015 at 02:22:27PM +0000, Bruce Richardson wrote:
> > > On Fri, Oct 30, 2015 at 09:14:39PM +0800, Jijiang Liu wrote:
> > >
> > > Title can be shortened to: "lpm: fix initialization of valid_group
> field"
> > >
> > > > Fixes an initialization issue of 'valid_group' in the
> delete_depth_small function.
> > > >
> > > > In this function, use new rte_lpm_tbl8_entry we call A to replace
> > > > the old rte_lpm_tbl8_entry. But the valid_group do not set VALID, s=
o
> it will be INVALID.
> > > >
> > > > Then when adding a new route which depth is > 24,the tbl8_alloc()
> > > > function will search the rte_lpm_tbl8_entrys to find INVALID
> valid_group, and it will return the A to the add_depth_big function, so
> A's data is overridden.
> > > >
> > >
> > > Not sure this message is entirely clear.
> > > How about:
> > >   When adding an entry to a tbl8, the .valid_group field should alway=
s
> be set,
> > >   so that future adds do not accidently find and use this table,
> thinking it is
> > >   currently invalid, i.e. unused, and thereby overwrite existing
> entries.
> > >
> > > > Signed-off-by: NaNa <nana.nn@alibaba-inc.com>
> > > >
> > Assuming we get a little cleanup on commit title and log message
> > (Thomas, perhaps just a rewrite on commit?):
>=20
> Giving the name of a field in the title is not really useful for the
> overview.
> It's better to talk about the use case which is fixed.

"lpm: fix incorrect reuse of already allocated tbl8" ??