From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C60028E89 for ; Fri, 30 Oct 2015 16:05:56 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 30 Oct 2015 08:05:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,219,1444719600"; d="scan'208";a="675101265" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 30 Oct 2015 08:05:55 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.116]) by IRSMSX101.ger.corp.intel.com ([169.254.1.33]) with mapi id 14.03.0248.002; Fri, 30 Oct 2015 15:05:54 +0000 From: "Richardson, Bruce" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [PATCH v3] hash: fix scaling by reducing contention Thread-Index: AQHREyCELxqRbulsu0ag8m40j+VE556EIprQ Date: Fri, 30 Oct 2015 15:05:54 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B03596598C@IRSMSX103.ger.corp.intel.com> References: <1446207772-58543-1-git-send-email-pablo.de.lara.guarch@intel.com> <1446215848-122581-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1446215848-122581-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] hash: fix scaling by reducing contention X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 15:05:57 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, October 30, 2015 2:37 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; De Lara Guarch, Pablo > > Subject: [PATCH v3] hash: fix scaling by reducing contention >=20 > From: "De Lara Guarch, Pablo" >=20 > If using multiple cores on a system with hardware transactional memory > support, thread scaling does not work, as there was a single point in the > hash library which is a bottleneck for all threads, which is the > "free_slots" ring, which stores all the indices of the free slots in the > table. >=20 > This patch fixes the problem, by creating a local cache per logical core, > which stores locally indices of free slots, so most times, writer threads > will not interfere each other. >=20 > Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") >=20 > Signed-off-by: Pablo de Lara Acked-by: Bruce Richardson