From: "Richardson, Bruce" <bruce.richardson@intel.com>
To: "Bie, Tiwei" <tiwei.bie@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/2] Various fixes for contigmem
Date: Wed, 10 May 2017 14:05:19 +0000 [thread overview]
Message-ID: <59AF69C657FD0841A61C55336867B5B066763FE9@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20170509084707.29949-1-tiwei.bie@intel.com>
> -----Original Message-----
> From: Bie, Tiwei
> Sent: Tuesday, May 9, 2017 9:47 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: [PATCH 0/2] Various fixes for contigmem
>
> Tiwei Bie (2):
> contigmem: free the allocated memory when error occurs
> contigmem: don't zero the pages during each mmap
>
> lib/librte_eal/bsdapp/contigmem/contigmem.c | 186
> ++++++++++++++++++++++++----
> 1 file changed, 161 insertions(+), 25 deletions(-)
>
These look better solutions than the previous ones for multi-process.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Given that this is not a new bug in this release, I don't think we should take the risk of applying the patches this late in the 17.05 release cycle. I therefore suggest that they be merged for 17.08 and once tested in that release, backported to 17.05 stable.
/Bruce
next prev parent reply other threads:[~2017-05-10 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 8:47 Tiwei Bie
2017-05-09 8:47 ` [dpdk-dev] [PATCH 1/2] contigmem: free the allocated memory when error occurs Tiwei Bie
2017-05-09 8:47 ` [dpdk-dev] [PATCH 2/2] contigmem: don't zero the pages during each mmap Tiwei Bie
2017-05-10 14:05 ` Richardson, Bruce [this message]
2017-05-11 1:03 ` [dpdk-dev] [PATCH 0/2] Various fixes for contigmem Tiwei Bie
2017-05-22 9:03 ` [dpdk-dev] [PATCH v2 " Tiwei Bie
2017-05-22 9:03 ` [dpdk-dev] [PATCH v2 1/2] contigmem: free the allocated memory when error occurs Tiwei Bie
2017-05-22 9:03 ` [dpdk-dev] [PATCH v2 2/2] contigmem: don't zero the pages during each mmap Tiwei Bie
2017-05-22 10:15 ` [dpdk-dev] [dpdk-stable] " Shahaf Shuler
2017-06-04 5:53 ` [dpdk-dev] [PATCH v3 0/2] Various fixes for contigmem Tiwei Bie
2017-06-04 5:53 ` [dpdk-dev] [PATCH v3 1/2] contigmem: free the allocated memory when error occurs Tiwei Bie
2017-06-04 5:53 ` [dpdk-dev] [PATCH v3 2/2] contigmem: don't zero the pages during each mmap Tiwei Bie
2017-07-03 23:33 ` [dpdk-dev] [PATCH v3 0/2] Various fixes for contigmem Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59AF69C657FD0841A61C55336867B5B066763FE9@IRSMSX103.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).