From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id AE7632A58 for ; Tue, 13 Jun 2017 18:30:49 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2017 09:30:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,338,1493708400"; d="scan'208";a="97549649" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga004.jf.intel.com with ESMTP; 13 Jun 2017 09:30:46 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.26]) by IRSMSX152.ger.corp.intel.com ([169.254.6.83]) with mapi id 14.03.0319.002; Tue, 13 Jun 2017 17:30:46 +0100 From: "Richardson, Bruce" To: "Zhang, Qi Z" , "Ananyev, Konstantin" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Zhang, Helin" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH v4 1/2] net/ixgbe: add SSE4.1 support to vPMD's minimum requirement Thread-Index: AQHS5F7+XXDKj4QBL0u9Qp+lf2HDUqIi+gYw Date: Tue, 13 Jun 2017 16:30:44 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B07217DD56@IRSMSX104.ger.corp.intel.com> References: <1494991243-21940-1-git-send-email-qi.z.zhang@intel.com> <1497344306-24626-1-git-send-email-qi.z.zhang@intel.com> In-Reply-To: <1497344306-24626-1-git-send-email-qi.z.zhang@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmEwYzU2NWUtNDJiMi00MTYyLWJmODctZTRlNzI5NmQ0YTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Inc2Y2JIMndnN0VrVVdcL2pVZUNcL0ZhTXBjd3diU1R2azRHcmFwSmI3Wk5aUT0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/2] net/ixgbe: add SSE4.1 support to vPMD's minimum requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2017 16:30:50 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Tuesday, June 13, 2017 9:58 AM > To: Ananyev, Konstantin ; Yigit, Ferruh > > Cc: dev@dpdk.org; Lu, Wenzhuo ; Zhang, Helin > ; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v4 1/2] net/ixgbe: add SSE4.1 support to vPMD'= s > minimum requirement >=20 > x86 vPMD will be disabled if currently platform does not support SSE4.1. > This is the prework to enable vPMD ptype offload where SSE4.1 > instrunctions will be involved. >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > index a7bc199..fbbd872 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > @@ -652,5 +652,9 @@ ixgbe_txq_vec_setup(struct ixgbe_tx_queue *txq) int > __attribute__((cold)) ixgbe_rx_vec_dev_conf_condition_check(struct > rte_eth_dev *dev) { > + /* need SSE4.1 support */ > + if (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1)) > + return -1; > + > return ixgbe_rx_vec_dev_conf_condition_check_default(dev); > } Quite a few things for DPDK on x86 and x86_64 depend on SSE4.x now. I think= we should just up the minimum supported x86 CPU architecture for DPDK to r= equire SSE4.2 and be done with it. SSE4.2 has been around for almost a deca= de now (https://en.wikipedia.org/wiki/SSE4#SSE4.2), and so I would consider= it unlikely that anyone wants to use DPDK on a machine which does not have= that instruction set supported.=20 Doing so would mean we remove all conditional compilation settings for our = x86 vector drivers to add -msse flags, and can replace these runtime checks= in each driver with a single check in EAL init to ensure the CPU supports = SSE4.2. Possibly other cleanup could be done as well. Thoughts? any objections? /Bruce