From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4E06B26A8 for ; Fri, 8 Sep 2017 18:14:02 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Sep 2017 09:14:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,362,1500966000"; d="scan'208";a="309538633" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga004.fm.intel.com with ESMTP; 08 Sep 2017 09:14:00 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Fri, 8 Sep 2017 17:13:59 +0100 From: "Richardson, Bruce" To: "Van Haaren, Harry" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds Thread-Index: AQHTKLv75klqN3+clU+RagK71kMafKKrJ75g Date: Fri, 8 Sep 2017 16:13:58 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0721D3217@IRSMSX103.ger.corp.intel.com> References: <20170901100416.80264-1-bruce.richardson@intel.com> <20170901100416.80264-2-bruce.richardson@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGZkMjk5ODItODVkOC00YTZkLWJjOGEtZDJhZDgxZWI1YWE1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImExWW1aazVQUk5SekNVbDJmOFhhRDJNb3ZRbUhmSkFJcHJoYmlOaUFZcW89In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 16:14:03 -0000 > -----Original Message----- > From: Van Haaren, Harry > Sent: Friday, September 8, 2017 5:03 PM > To: Richardson, Bruce ; dev@dpdk.org > Cc: Richardson, Bruce > Subject: RE: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure > for meson & ninja builds >=20 > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Friday, September 1, 2017 11:04 AM > > To: dev@dpdk.org > > Cc: Richardson, Bruce > > Subject: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure > > for meson & ninja builds >=20 > >=20 > > diff --git a/config/meson.build b/config/meson.build > > > +# set the machine type and cflags for it machine =3D > > +get_option('machine') dpdk_conf.set('RTE_MACHINE', machine) > > +add_project_arguments('-march=3D@0@'.format(machine), language: 'c') # > > +some libs depend on maths lib add_project_link_arguments('-lm', > > +language: 'c') > > + > > +# add -include rte_config to cflags > > +add_project_arguments('-include', 'rte_config.h', language: 'c') > > + > > +# disable any unwanted warnings > > +unwanted_warnings =3D [ > > + '-Wno-address-of-packed-member', > > + '-Wno-format-truncation' > > +] >=20 >=20 > Feedback from usage while developing new features; > - Mis-matched integer sign comparison doesn't cause a warning > - And -Werror isn't set by default >=20 Will fix the former in V2. For the latter, I already have a patch for it that approximates the behavio= r of the existing system - i.e. a "developer build" setting, which is "off"= by default, except when you are building from a git checkout in which case= it defaults to "on". However, I don't think I'll include that in V2, as ha= ving Werror when we are not reasonably sure we have fixed all warnings in t= he code for all supported compilers and distros is a bad idea IMHO. > Adding these as per below fixes things... but for cleanliness "unwanted > warnings" should probably be renamed, we want more warnings! :D >=20 > # disable any unwanted warnings > unwanted_warnings =3D [ > '-Werror', > '-Wno-address-of-packed-member', > '-Wno-format-truncation', > '-Wsign-compare', > ] >=20 Actually, I'd rather keep it as a list of warnings to disable for now. Enab= ling warnings should be handled differently, as we may only enable specific= warnings depending on the build type being done. /Bruce